From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBC21436F2; Thu, 14 Dec 2023 18:03:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A86F34326C; Thu, 14 Dec 2023 18:03:04 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id DEF7B402C2 for ; Thu, 14 Dec 2023 18:03:03 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 0C8D820B74C0; Thu, 14 Dec 2023 09:03:03 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0C8D820B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1702573383; bh=nvaaS38lbn/C1K0rcTJJCLZ//NdV+QOtRHqBcIYrhkE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MHS0VHfbR88aaYUS+Wduwxms8Ti6pNrfcMYhOIs0m+mchmEWr3SzoB8viJBiNpEf6 Wo5SCA+COjwr0qpuH6GIb9iHZcOKlBbkVbJpfX1mSp0u2o4BWRp+10+rAabqViNWBY LaxCt7tu84Ips927hAjktOaawcZjwc33OuueCiKI= Date: Thu, 14 Dec 2023 09:03:03 -0800 From: Tyler Retzlaff To: Bruce Richardson Cc: dev@dpdk.org Subject: Re: [PATCH] app/test: remove ifdefs for cmdline library Message-ID: <20231214170303.GA22258@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20231214113021.517622-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214113021.517622-1-bruce.richardson@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 14, 2023 at 11:30:21AM +0000, Bruce Richardson wrote: > The DPDK unit test binary relies on cmdline library and cannot do > anything without it being present. As it's a mandatory dependency we can > remove the ifdefs for it from main.c > > Signed-off-by: Bruce Richardson > --- Acked-by: Tyler Retzlaff