* [PATCH] app/test: prevent exiting after skipped test
@ 2023-12-14 11:38 Bruce Richardson
2023-12-14 17:03 ` Tyler Retzlaff
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2023-12-14 11:38 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson
When processing a list of tests to run, the loop termination condition
was a test returning a value != 0. This means that if one of a series of
tests was skipped, i.e. returned TEST_SKIPPED, the whole execution run
was stopped. Since a test being skipped is not an error condition, we
put in an explicit check for that to keep executing any remaining tests.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/test/test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test.c b/app/test/test.c
index c818fda17b..8b25615913 100644
--- a/app/test/test.c
+++ b/app/test/test.c
@@ -235,7 +235,7 @@ main(int argc, char **argv)
ret = last_test_result;
end_of_cmd:
- if (ret != 0)
+ if (ret != 0 && ret != TEST_SKIPPED)
break;
}
if (n_skip_tests > 0)
--
2.40.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] app/test: prevent exiting after skipped test
2023-12-14 11:38 [PATCH] app/test: prevent exiting after skipped test Bruce Richardson
@ 2023-12-14 17:03 ` Tyler Retzlaff
2024-02-01 10:34 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Tyler Retzlaff @ 2023-12-14 17:03 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
On Thu, Dec 14, 2023 at 11:38:13AM +0000, Bruce Richardson wrote:
> When processing a list of tests to run, the loop termination condition
> was a test returning a value != 0. This means that if one of a series of
> tests was skipped, i.e. returned TEST_SKIPPED, the whole execution run
> was stopped. Since a test being skipped is not an error condition, we
> put in an explicit check for that to keep executing any remaining tests.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] app/test: prevent exiting after skipped test
2023-12-14 17:03 ` Tyler Retzlaff
@ 2024-02-01 10:34 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2024-02-01 10:34 UTC (permalink / raw)
To: Bruce Richardson; +Cc: Tyler Retzlaff, dev
On Thu, Dec 14, 2023 at 6:04 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> On Thu, Dec 14, 2023 at 11:38:13AM +0000, Bruce Richardson wrote:
> > When processing a list of tests to run, the loop termination condition
> > was a test returning a value != 0. This means that if one of a series of
> > tests was skipped, i.e. returned TEST_SKIPPED, the whole execution run
> > was stopped. Since a test being skipped is not an error condition, we
> > put in an explicit check for that to keep executing any remaining tests.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-01 10:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-14 11:38 [PATCH] app/test: prevent exiting after skipped test Bruce Richardson
2023-12-14 17:03 ` Tyler Retzlaff
2024-02-01 10:34 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).