From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39E034373D; Mon, 18 Dec 2023 18:14:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2782040E09; Mon, 18 Dec 2023 18:14:39 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 6A4514025F for ; Mon, 18 Dec 2023 18:14:37 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1d3b60c5054so6481315ad.2 for ; Mon, 18 Dec 2023 09:14:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1702919676; x=1703524476; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Z/RzNgtC3h/CpzfEzfT7ol5qBgrKfX6zufFIbwrS2XU=; b=BngJPdcwybT0lcPII73te5qtr0XYlOYgIejezaXaE4FPGu+LiDRhK10xldH5GOaQLg HAAPhlFRTNA7mnaPxhFTVDO1VqirfGQVmlB66tWOvvuji1rw4lf5d7DJnxwskdXmpxj7 A3OukvCICky4t4GljjoGhZFF5hc8gVQaaJI3Po1axii4L9QFxpZ/KsRgSxGjIEJdKwwM Pt2dFHwyrVcyxOYo4VQtWj9FRF1ZSagSUBU3QU5KLHEmMDeRZHEulzicFgq+XOUnb6Ag dl0qq6RNiuz+nHx11dBg+pWYx4SJn2eE6iOH9kH21JgyXCEPLcOO0WuwKugrMbyjsKfK q9lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702919676; x=1703524476; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z/RzNgtC3h/CpzfEzfT7ol5qBgrKfX6zufFIbwrS2XU=; b=UDm+96zgp3RVvetgCj2kzSCG9BLKJdZqerklm2tfKZbWvHgPFWpB1B5Oc8MyKuHT3h WnmPToMjaj5SJoQ8h8aaKLI3nlcqmPtI0oBwjIPvLD2d4ceAm0X96M2lYhGMx+pb7RCn anUpZ0FX5T+9mD+GR41jrvPwMzGfX6EFJwBHAVldc+Lb4iG0F4M39WBO999zKO1Lb5VW TyEPlV1FXly3US6eWcDWRgqf3UBmUEhSGOH5khmr39Zl/kAi7YXbLuy39uU1R3hj4T/P 84jsUgckfmM9MZeN1sCvoYznIsP/ZH1RfN+JZrAioKi7f0lWDFlKVq2lU/EiwGmol5OS uygQ== X-Gm-Message-State: AOJu0YyFXYIrIfIeclyWHGUCAm60VYMrAyrOK6UA2fr0KwVEZTq9VbGA byxXE+IRJrF0G3UVOMToENbqsw== X-Google-Smtp-Source: AGHT+IE5SHyrgVn9K+07FRxVIgWMa6VO0pe3uP68Q+5dD9aWWL1cj3ly2X6GHF1O2eq9xCe4GjK85w== X-Received: by 2002:a17:902:e892:b0:1d3:c0d9:ad52 with SMTP id w18-20020a170902e89200b001d3c0d9ad52mr937881plg.100.1702919676499; Mon, 18 Dec 2023 09:14:36 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id t8-20020a1709028c8800b001c5b8087fe5sm19368339plo.94.2023.12.18.09.14.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 09:14:36 -0800 (PST) Date: Mon, 18 Dec 2023 09:14:33 -0800 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, Gagandeep Singh , Hemant Agrawal , Nipun Gupta , Nikhil Agarwal , Sachin Saxena , Anoob Joseph , Jingjing Wu , Beilei Xing , Abdullah Sevincer , Igor Russkikh , Steven Webster , Matt Peters , Ajit Khaparde , Somnath Kotur , Ruifeng Wang , Bruce Richardson , Konstantin Ananyev , Apeksha Gupta , Junfeng Guo , Simei Su , Long Li , Vamsi Attunuru , Harman Kalra , Devendra Singh Rawat , Alok Prasad , Maxime Coquelin , Chenbo Xia , Jochen Behrens , Rosen Xu , Tianfei Zhang , Xiao Wang Subject: Re: [PATCH] drivers: use dedicated logtypes Message-ID: <20231218091433.12490a47@hermes.local> In-Reply-To: <20231218135932.1497163-1-david.marchand@redhat.com> References: <20231218135932.1497163-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 18 Dec 2023 14:59:31 +0100 David Marchand wrote: > When a driver dedicated logtype exists, use it instead of the generic > PMD logtype. > > This has been done partially automatically with: > > $ for file in $(git grep -l RTE_LOG.*PMD.*fmt drivers/'**.h' \ > :^drivers/common/cnxk/roc_platform.h) > do > tail=${file#drivers/*/*/} > dir=${file%%$tail} > ! git grep -q RTE_LOGTYPE_ $dir || \ > { echo $dir already done; continue; } > git grep -hE '^extern int .*log.*;$' $file | \ > sed -ne 's/^extern int \([^ ;]*\);$/\1/p' | \ > while read logtype > do > git grep -q 'RTE_LOG_REGISTER\(_DEFAULT\|\)('$logtype',' || \ > [ "$logtype" != "${logtype%%driver}" ] || \ > { echo Skipped $logtype; continue; } > abbrev=$(echo $logtype | sed -e 's/_logtype//' | tr '[a-z]' '[A-Z]') > sed -i -e 's/^\(extern int '$logtype'.*\)$/\1\n#define RTE_LOGTYPE_' \ > $abbrev' '$logtype'/' $file > sed -i -e 's/\(RTE_LOG.*, \)PMD,/\1'$abbrev',/' $file > break > done > done > > Then a manual update for: > - common/cpt, > - common/dpaax, > - common/idpf, > - mempool/dpaa, > - net/bnxt, > - net/octeon_ep, > - raw/ifpga, > - vdpa/ifc, > > Signed-off-by: David Marchand I have some additional manual fixes on top of this. Reviewed-by: Stephen Hemminger