From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06AB94373D; Mon, 18 Dec 2023 20:52:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCC22406BC; Mon, 18 Dec 2023 20:52:27 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 8F54140151 for ; Mon, 18 Dec 2023 20:52:26 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id DC8F820B3CC1; Mon, 18 Dec 2023 11:52:25 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DC8F820B3CC1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1702929145; bh=ygpAc5/rFlKPXleqgh2DRg0Sy/JW+7TmHNyw7GWvGj4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Fbruej7Ko7l7gPYdzCSNncMy5ZYY2iIewicxx3TyycxB13CHQzubCYA/sXMXPVqWF HTOlLPJOX+proBLj14DQAxXfXxyJxSUEPrzQiwxhG1bdDxWHOkvYUuzVDGSLBA+4Bn yWwQ1Sr3LEhOETZTBESz1GS7GfADesGICV5U3fvU= Date: Mon, 18 Dec 2023 11:52:25 -0800 From: Tyler Retzlaff To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, stephen@networkplumber.org, mb@smartsharesystems.com, Honnappa Nagarahalli Subject: Re: [RFC v2 09/14] rcu: introduce a logging helper Message-ID: <20231218195225.GA6425@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231208145950.2184940-1-david.marchand@redhat.com> <20231208145950.2184940-10-david.marchand@redhat.com> <20231208212749.GH5699@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20231212191117.GA1160@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Dec 18, 2023 at 10:37:12AM +0100, David Marchand wrote: > On Tue, Dec 12, 2023 at 8:11 PM Tyler Retzlaff > wrote: > > On Tue, Dec 12, 2023 at 04:00:35PM +0100, David Marchand wrote: > > > On Fri, Dec 8, 2023 at 10:27 PM Tyler Retzlaff > > > wrote: > > > > > > > > On Fri, Dec 08, 2023 at 03:59:43PM +0100, David Marchand wrote: > > > > > Signed-off-by: David Marchand > > > > > --- > > > > > > > > Reviewed-by: Tyler Retzlaff > > > > > > > > > lib/rcu/rte_rcu_qsbr.c | 62 ++++++++++++++++-------------------------- > > > > > lib/rcu/rte_rcu_qsbr.h | 1 + > > > > > 2 files changed, 24 insertions(+), 39 deletions(-) > > > > > > > > > > diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c > > > > > index 41a44be4b9..5b6530788a 100644 > > > > > --- a/lib/rcu/rte_rcu_qsbr.c > > > > > +++ b/lib/rcu/rte_rcu_qsbr.c > > > > > @@ -19,6 +19,9 @@ > > > > > #include "rte_rcu_qsbr.h" > > > > > #include "rcu_qsbr_pvt.h" > > > > > > > > > > +#define RCU_LOG(level, fmt, args...) \ > > > > > + RTE_LOG(level, RCU, "%s(): " fmt "\n", __func__, ## args) > > > > > + > > > > > > > > Since you are looking in the area for all the versions of gcc/clang we > > > > use able to support the non-standard __VA_ARGS__ that discard the comma? > > > > > > I suspect there is some typo (maybe s/for all/are all/ ?). > > > Can you please clarify? > > > > > > > > > > > > > > I know that some versions of gcc do and if it does I would like to move > > > > to using __VA_ARGS__ instead of args so we can use the same thing with > > > > msvc. > > > > > > If the request is to translate the ## args stuff to __VA_ARGS__, I > > > would prefer this is done in a separate series and not to mix with > > > this already huge series. > > > > Yes. > > > > I was asking if translation was possible from ## args to __VA_ARGS__. > > > > I was also asking if you could help do the translation. I didn't mean to > > suggest it should be done in this series. > > Ok, I'll see if I can spend some cycles on this, but in January. fantastic i'd appreciate that a lot, i'll focus on some other things then. ty > > > -- > David Marchand