* [PATCH] devtools: forbid writing to standard output streams
@ 2023-12-21 13:31 David Marchand
2023-12-21 14:52 ` Bruce Richardson
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: David Marchand @ 2023-12-21 13:31 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Thomas Monjalon
No output on stdout or stderr!
Drivers and libraries must use the logging framework.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/checkpatches.sh | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 10d1bf490b..c9e466f736 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -61,6 +61,14 @@ check_forbidden_additions() { # <patch>
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
+ # no output on stdout or stderr
+ awk -v FOLDERS="lib drivers" \
+ -v EXPRESSIONS="\\\<printf\\\> \\\<fprintf\\\(stdout, \\\<fprintf\\\(stderr," \
+ -v RET_ON_FAIL=1 \
+ -v MESSAGE='Writing to stdout or stderr' \
+ -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+ "$1" || res=1
+
# refrain from new additions of rte_panic() and rte_exit()
# multiple folders and expressions are separated by spaces
awk -v FOLDERS="lib drivers" \
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] devtools: forbid writing to standard output streams
2023-12-21 13:31 [PATCH] devtools: forbid writing to standard output streams David Marchand
@ 2023-12-21 14:52 ` Bruce Richardson
2023-12-21 16:30 ` Stephen Hemminger
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Bruce Richardson @ 2023-12-21 14:52 UTC (permalink / raw)
To: David Marchand; +Cc: dev, ferruh.yigit, Thomas Monjalon
On Thu, Dec 21, 2023 at 02:31:20PM +0100, David Marchand wrote:
> No output on stdout or stderr!
> Drivers and libraries must use the logging framework.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> devtools/checkpatches.sh | 8 ++++++++
> 1 file changed, 8 insertions(+)
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] devtools: forbid writing to standard output streams
2023-12-21 13:31 [PATCH] devtools: forbid writing to standard output streams David Marchand
2023-12-21 14:52 ` Bruce Richardson
@ 2023-12-21 16:30 ` Stephen Hemminger
2023-12-21 17:06 ` Tyler Retzlaff
2024-01-19 11:09 ` David Marchand
3 siblings, 0 replies; 5+ messages in thread
From: Stephen Hemminger @ 2023-12-21 16:30 UTC (permalink / raw)
To: David Marchand; +Cc: dev, ferruh.yigit, Thomas Monjalon
On Thu, 21 Dec 2023 14:31:20 +0100
David Marchand <david.marchand@redhat.com> wrote:
> No output on stdout or stderr!
> Drivers and libraries must use the logging framework.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> devtools/checkpatches.sh | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index 10d1bf490b..c9e466f736 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -61,6 +61,14 @@ check_forbidden_additions() { # <patch>
> -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
> "$1" || res=1
>
> + # no output on stdout or stderr
> + awk -v FOLDERS="lib drivers" \
> + -v EXPRESSIONS="\\\<printf\\\> \\\<fprintf\\\(stdout, \\\<fprintf\\\(stderr," \
> + -v RET_ON_FAIL=1 \
> + -v MESSAGE='Writing to stdout or stderr' \
> + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
> + "$1" || res=1
> +
> # refrain from new additions of rte_panic() and rte_exit()
> # multiple folders and expressions are separated by spaces
> awk -v FOLDERS="lib drivers" \
Ok, noticed a lot of this in the crypto drivers dump code.
Probably other drivers have buried debug code as well.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] devtools: forbid writing to standard output streams
2023-12-21 13:31 [PATCH] devtools: forbid writing to standard output streams David Marchand
2023-12-21 14:52 ` Bruce Richardson
2023-12-21 16:30 ` Stephen Hemminger
@ 2023-12-21 17:06 ` Tyler Retzlaff
2024-01-19 11:09 ` David Marchand
3 siblings, 0 replies; 5+ messages in thread
From: Tyler Retzlaff @ 2023-12-21 17:06 UTC (permalink / raw)
To: David Marchand; +Cc: dev, ferruh.yigit, Thomas Monjalon
On Thu, Dec 21, 2023 at 02:31:20PM +0100, David Marchand wrote:
> No output on stdout or stderr!
> Drivers and libraries must use the logging framework.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] devtools: forbid writing to standard output streams
2023-12-21 13:31 [PATCH] devtools: forbid writing to standard output streams David Marchand
` (2 preceding siblings ...)
2023-12-21 17:06 ` Tyler Retzlaff
@ 2024-01-19 11:09 ` David Marchand
3 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2024-01-19 11:09 UTC (permalink / raw)
To: dev
Cc: ferruh.yigit, Thomas Monjalon, Bruce Richardson,
Stephen Hemminger, Tyler Retzlaff
On Thu, Dec 21, 2023 at 2:31 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> No output on stdout or stderr!
> Drivers and libraries must use the logging framework.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-19 11:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-21 13:31 [PATCH] devtools: forbid writing to standard output streams David Marchand
2023-12-21 14:52 ` Bruce Richardson
2023-12-21 16:30 ` Stephen Hemminger
2023-12-21 17:06 ` Tyler Retzlaff
2024-01-19 11:09 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).