From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
by dpdk.org (Postfix) with ESMTP id 0F5738E69
for <dev@dpdk.org>; Thu, 19 May 2016 14:26:14 +0200 (CEST)
Received: by mail-wm0-f47.google.com with SMTP id n129so228144367wmn.1
for <dev@dpdk.org>; Thu, 19 May 2016 05:26:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=TT4WRYrHcem7mHAqJJik+8mkqH5GbZ7QeH4jzqrpdk8=;
b=GmI/N0tn12iFUnVJ7TQbbRmV5OXtvEysR6g3+FaLtTlA3FfgKpylhCTJsYBxwtB7xE
mbfjJ+8rPlQD/D9ZiQ2S51YzLwn4Kc4ulKKOPm+KUnUXRK/06Rlw13e87OZ36nlCgltP
NWLabHsBT3n6dGcBpo7NsKDS6l4sI2sA3pO1rEBYfRonkHb20nujImsdlCu9+G7pIYKX
ZhGFCGjzCA0hTqZF1YDeSUZEGIAZl7KweZ6aYCxaV4xl5pB99s4ZindomI4RhQBRiKKa
hzKgj/cREcj6EsYz363Mgjz9qyp32r8HJoPwnKDoWI8EywdjAJvKlQF45v9upHSGT62Y
xAZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
:in-reply-to:references:mime-version:content-transfer-encoding;
bh=TT4WRYrHcem7mHAqJJik+8mkqH5GbZ7QeH4jzqrpdk8=;
b=kgbUHakv7uJdqM/GfLknp48r7R+Mloy4u7CClZEt6CKYwP3Skm17ISDpGdKsM0GDpS
DoZ8gj8gAdrjLXYbOrofree+i5hc+IWrpa9C15F1OsA3tirdHLFAsvBYgrua7WqcKirA
ukzoLsVtS1n8A5pIix2L9KBhS3PQEZbC9R5aROIIbwrse9LVdjRUhv33Zphp+iyFna1w
crKdljNxv4h1FmPXPUJ0qQANqwjjLKqBU/PHJtjcedc/3YOm/6VBQsTzHsJLbekHIkxw
O3vxvVdI+uXTnSR9uKYK5RdLFQn3s74DrYFBmGjFcFtuO9jHshfEQ//Bsien060Bm3bl
EVtg==
X-Gm-Message-State: AOPr4FWgnuzd7gmBpra5zPZU2U4jma+HwFpXH6Hc5c/8Kpd/ZL5k1APe9KIugEuBsPYKFh8M
X-Received: by 10.28.11.82 with SMTP id 79mr13490031wml.33.1463660773844;
Thu, 19 May 2016 05:26:13 -0700 (PDT)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
[82.239.227.177])
by smtp.gmail.com with ESMTPSA id pm4sm14097862wjb.35.2016.05.19.05.26.12
(version=TLSv1/SSLv3 cipher=OTHER);
Thu, 19 May 2016 05:26:12 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>, marcinx.kerlin@intel.com
Cc: dev@dpdk.org
Date: Thu, 19 May 2016 14:26:02 +0200
Message-ID: <2023616.jWtzSNvIF8@xps13>
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1463474217-30875-1-git-send-email-olivier.matz@6wind.com>
References: <1463411889-22245-1-git-send-email-marcinx.kerlin@intel.com>
<1463474217-30875-1-git-send-email-olivier.matz@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] cmdline: check return value at
initialization
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 19 May 2016 12:26:14 -0000
2016-05-17 10:36, Olivier Matz:
> From: Marcin Kerlin <marcinx.kerlin@intel.com>
>
> The value returned by rdline_init() was not checked in cmdline_new().
> On error, free the allocated memory and return NULL.
>
> This condition should not happen today, but it's safer to do the check
> in case rdline_init() is updated.
>
> Fixes: af75078fece3 ("first public release")
> Coverity ID 13204
>
> Signed-off-by: Marcin Kerlin <marcinx.kerlin@intel.com>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>
> Hi Marcin,
>
> I updated the commit log and title to be clearer.
Applied, thanks