From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C1E04380F; Thu, 4 Jan 2024 02:04:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A651402BF; Thu, 4 Jan 2024 02:04:03 +0100 (CET) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by mails.dpdk.org (Postfix) with ESMTP id 77BE140266 for ; Thu, 4 Jan 2024 02:04:01 +0100 (CET) Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-6dbca115636so25105a34.2 for ; Wed, 03 Jan 2024 17:04:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1704330240; x=1704935040; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=p8Z3ag5n9BtuBdr8mZwIMyVdIBBOx5PC0r8wIgH8tT8=; b=j6Na5uTTj4VkjR0vbqrtwG2uKy/VlRImlBp8/V8YvePLuAGml2a6ABx5g2qgEYRIMM Ki4pbCMyHncLWG5/NFxQ7SlpQErE3sPnBKH2Ttlg2KG1x84T1zMUO/VgsNLFT3qdArao hJld+nucOl1dI1E1LoCdFT66gYPEKvrtETNkgWF6/0rZOCR4QzWyxRBHE+4q878fRCs4 AVrhzoWXq9grhIDP87LCWxqcCZaDF6sXiGPLlpLTmQrhML27fzUzwhcLrb9SfHbo+vCU J56DtH9mH+7gORx++U6QFEnXFLVD8/jnDVhevQVbwWN7DejYo3GIu0iDwcgXwQtsKUvU 3Yng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704330240; x=1704935040; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p8Z3ag5n9BtuBdr8mZwIMyVdIBBOx5PC0r8wIgH8tT8=; b=XBsBk+RgFF0MCLLdiIdGBVH1Ksg8N3E9Ol6c8HvDuXLdds+NVngMKNgBu8xL7fuWYd edSFI8cIqMbki2/A2W0UT71XwyW6hc1cqzVlaC+tQjY0Zc8n0GagHr2o8CElw8t1NIO+ Y9/BI0i+kcs3R5VQ6/G7f1fhQbTtZiICIyMcR+d+7gfVZ9JAYuB1Es7JLCJx3Uk8ToBd VsSkMmxvjvctWKa2GWkZ9hal1erX0euBXoyLrT3vAPnNkLFjr799XEaT3CPOHiHwpnTE dnKd+VKprtSaa0GE4lq9uLk9J8gIYkiBEAqsuHp8ouIvFqgxAhce4CT1mIlO0QOpDKHs MCZw== X-Gm-Message-State: AOJu0Yzb4unns0CenhP2UvGPr4Us1cFivo0dtZ7ID7qR7gY0bpApVTKQ O+2ixyy2OVjH1xHJpkbAMycu1RXa3bT+JA== X-Google-Smtp-Source: AGHT+IEVIimGF27lqJ3VnjD1cr+MGNAh+gNgHPcQidM0IauIFLjyoXqeba7K4sVj7cMFFvu0is42Gg== X-Received: by 2002:a05:6358:9214:b0:175:565c:b07f with SMTP id d20-20020a056358921400b00175565cb07fmr2049525rwb.43.1704330240513; Wed, 03 Jan 2024 17:04:00 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id j22-20020a62e916000000b006d97cc5cc13sm22548837pfh.8.2024.01.03.17.03.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 17:04:00 -0800 (PST) Date: Wed, 3 Jan 2024 17:03:58 -0800 From: Stephen Hemminger To: Kaiwen Deng Cc: dev@dpdk.org, stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com, Aman Singh , Yuying Zhang , David Marchand , Ferruh Yigit Subject: Re: [PATCH v1] app/testpmd: use Tx preparation in txonly engine Message-ID: <20240103170358.6762efb8@hermes.local> In-Reply-To: <20240103012912.4334-1-kaiwenx.deng@intel.com> References: <20240103012912.4334-1-kaiwenx.deng@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 3 Jan 2024 09:29:12 +0800 Kaiwen Deng wrote: > > - nb_tx = common_fwd_stream_transmit(fs, pkts_burst, nb_pkt); > + nb_prep = rte_eth_tx_prepare(fs->tx_port, fs->tx_queue, > + pkts_burst, nb_pkt); > + if (unlikely(nb_prep != nb_pkt)) { > + fprintf(stderr, > + "Preparing packet burst to transmit failed: %s\n", > + rte_strerror(rte_errno)); The main failure likely is mismatched offload flags, so it might be helpful to print offload flags of that mbuf. > + fs->fwd_dropped += (nb_pkt - nb_prep); Nit: no parenthesis needed here. > + rte_pktmbuf_free_bulk(&pkts_burst[nb_prep], nb_pkt - nb_prep); > + } > + > + nb_tx = common_fwd_stream_transmit(fs, pkts_burst, nb_prep); >