From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1AF94383F; Fri, 5 Jan 2024 18:41:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF0C4402D8; Fri, 5 Jan 2024 18:41:31 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 338C3402CC for ; Fri, 5 Jan 2024 18:41:30 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1d3f8af8297so11049655ad.2 for ; Fri, 05 Jan 2024 09:41:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1704476489; x=1705081289; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=AEPJ4jTsSqx5qmsXGTHd6Rw5FPpppfrMk+WEv4+cbbE=; b=EyOHymUd5AO8kgEVghJX4ia3zhlSOb0crUkTipJs9xLNhZ5n0R22qQ/iFlHWzqFFtL uf6MhhbIQes/0kHhzedupkJERY1+VAJH+SKU24sy9xf0WKR527EuABEczHhYjxPan2uV xyzTSHPjmCe0iLwTJsaEfgw1/670gpuxxhRfvk/87ac4DJX39RngQpsA/dQNNLIUCBjQ I/s4fAKb47A3YSe/PalyeY0hpe9hElEDCYknTmasvhGTTy3TRV/l6YZ3WkjjzsVY2su7 Pmr7EQx77skG0ce6FlcMKWIACgDrAXMk7ujNZ/3huyuEsk46976O3DcThZmCNTpDUDgP WpKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704476489; x=1705081289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AEPJ4jTsSqx5qmsXGTHd6Rw5FPpppfrMk+WEv4+cbbE=; b=iCo/tpIBrH9PCQ/wYa8MpocvpgWyMC34Kb4AkYM3jLOuN21tWHcnST1Mv4maqs5+mQ UnBjbXXZ54rSQDO6foFfND5Iiu0PiR9FQoacJDzNm0kXiZTAyARkk4Og59w5ExO+R1dH k0RdlVWgEX5DTFdzDDU55LBMT4c+3r6yn9b9vr7MsGgH7wHpy2EnNMt4LJ6uTPWwvBCy hUp9d0v3hk7gckVALWAB4JKxhqGsFjcjBwKs7x6szmYZUypQVKiO5ht/S+UoTxOv9+c5 tN+OfHAqDpQDCSVYtv1wH0IN37iEze+ORgtJ6jdFI/jXwmKHoisToLgQ08uDyBWaWxuy Pjzw== X-Gm-Message-State: AOJu0YwtaTuogpMS1N0kM6lDfyM10ExeWG1KIGULxQ3H3VUL55f6osEK WDFf4Zq4FKkUNn696P8LUT2rmc7oMu9WwA== X-Google-Smtp-Source: AGHT+IFo8RASecNj1zXaqWrFqxTeGehLt/YOocGHr5MzRuUw06Zq1tgNzJ0K3rXh4Ua+ufJkwoO7MA== X-Received: by 2002:a17:903:11cf:b0:1d4:e2ef:b990 with SMTP id q15-20020a17090311cf00b001d4e2efb990mr2234562plh.45.1704476489291; Fri, 05 Jan 2024 09:41:29 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id q9-20020a170902a3c900b001d497c8eb92sm1693099plb.109.2024.01.05.09.41.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 09:41:28 -0800 (PST) Date: Fri, 5 Jan 2024 09:41:27 -0800 From: Stephen Hemminger To: Madhuker Mythri Cc: "ferruh.yigit@amd.com" , "dev@dpdk.org" Subject: Re: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements. Message-ID: <20240105094127.62346585@hermes.local> In-Reply-To: References: <20240104172756.2213-1-madhuker.mythri@oracle.com> <20240104124115.6e6806eb@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 5 Jan 2024 15:11:22 +0000 Madhuker Mythri wrote: > By using this " bpf_skb_load_bytes_relative()" helper function we can directly retrieve the Network header data fields, so we no need to check for L2-header VLAN presence. > > Thanks, > Madhuker. No problem, the vlan code was already broken. The kernel offloads vlan header to skb but who ever wrote the original did not know that is what happens in modern kernels.