From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A01E443867; Mon, 8 Jan 2024 18:03:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C88E40273; Mon, 8 Jan 2024 18:03:42 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 415E240261 for ; Mon, 8 Jan 2024 18:03:40 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1d45f182fa2so17831635ad.3 for ; Mon, 08 Jan 2024 09:03:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1704733419; x=1705338219; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Psjx/yyo98tN8x2Qi1kQftWdrWUezVQkjflLfuoZHFg=; b=Ywec8BxMvFi+qka3cOwMZcZp0I0/tFM/XPkos5U5anE6CQGmX7WZ00AT5KXGB3Kl7Q baTWr70NvE8/vN5Kwucfvi8Xf3ScPWfVFdCz4HlE9CG4U2lNjVQmOOGNEMB9gDO2xfc0 DR4KLmibTGhSiph9y8Gq/B02UeJevfbAdbFmThVhJvjQiZshHLlvwmyfVm8JDJicJG4c 1EiRylCr3qo9MqQejQ3YjYn1XHG0JHgeCkPtu8iQVe142jsEDGMrYjZRATb4F0NYoRyo hxw+aKTCV1jce+fPHm16LFwUke7TCZ10rd8f15eyYpuItJ7VpAv7pFC8yjFShLIEsZkU uXTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704733419; x=1705338219; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Psjx/yyo98tN8x2Qi1kQftWdrWUezVQkjflLfuoZHFg=; b=RlyIH9j7iBlX5+83iYGcJmoL2jMHrGnyP9bT6GkE/dY8k1y975eMr9VHAbmTzuQWN6 acuOsDIyN6nno00O0fQ/uW808MaJslNSq1yXTadWFJ9rJYMQU+/94xvP3BRnu7/OxZxq buMQ5uGvhO9ovEubqlaSMN12+LRvI/RLRZvuqzxKLt4EQqh8W2LfEOqa9H+KIjCUQvU6 bRI7rR6IjZ8Sh72yKJ6VIEZcQ8DkiRghnuQyS03nTXX16HihThBt0oCDk3ReeXl6RC5g UwwOtgZ7BTrnkz+n3Zoj1wdH8HM0hgvAfujPhDdrSKte1tvObzq37NHqLglbeaeLjpUN xLgA== X-Gm-Message-State: AOJu0Yxk96UrCA41ofSiLDujNncWTiHDetuQuhKbI5T5RZoYlLbDz6Rt G3OIdJZ3ovNi8MmXw2QTRmW6/Yee2xMmZQ== X-Google-Smtp-Source: AGHT+IGT3o4gvQ8ntOlXj2zV7LU7YKhghcSotkcu+b8Dr1tQsVFehzYh8YCYEFRRup5MfOAxRJonaw== X-Received: by 2002:a17:902:ec88:b0:1d4:f77c:a8e6 with SMTP id x8-20020a170902ec8800b001d4f77ca8e6mr5082888plg.114.1704733419305; Mon, 08 Jan 2024 09:03:39 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id h16-20020a170902ac9000b001d40cc2c9c3sm141248plr.35.2024.01.08.09.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 09:03:39 -0800 (PST) Date: Mon, 8 Jan 2024 09:02:55 -0800 From: Stephen Hemminger To: Konstantin Ananyev Cc: "dev@dpdk.org" , "arshdeep.kaur@intel.com" , "Gowda, Sandesh" , Reshma Pattan Subject: Re: Issues around packet capture when secondary process is doing rx/tx Message-ID: <20240108090255.74d13f9d@hermes.local> In-Reply-To: <5c28d2a26f5142c3a509cc8bda2fca75@huawei.com> References: <20240107175900.1276c0a5@hermes.local> <5c28d2a26f5142c3a509cc8bda2fca75@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 8 Jan 2024 15:13:25 +0000 Konstantin Ananyev wrote: > > > > 2. Replace use of rx/tx callback in pdump with change to rte_ethdev to have > > a capture flag. (i.e. don't use indirection). Likely ABI problems. > > Basically, ignore the rx/tx callback mechanism. This is my preferred > > solution. > > It is not only the capture flag, it is also what to do with the captured packets > (copy? If yes, then where to? examine? drop?, do something else?). > It is probably not the best choice to add all these things into ethdev API. The part that pdump does is trivial, it just copies and puts in ring. This will work from any process.