From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: dev@dpdk.org, Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Remy Horton <remy.horton@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH] testpmd: do not print bitrate-stats in help if not configured
Date: Wed, 10 Jan 2024 15:25:59 -0800 [thread overview]
Message-ID: <20240110152559.0f9642d4@hermes.local> (raw)
In-Reply-To: <da2b1921-e9af-472f-a167-3c676b55c181@amd.com>
On Wed, 10 Jan 2024 18:52:39 +0000
Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> On 1/9/2024 11:09 PM, Stephen Hemminger wrote:
> > Like other #ifdef options, bitrate-stats should not be printed
> > in help if not configured.
> >
> > Fixes: e25e6c70fb56 ("app/testpmd: add --bitrate-stats option")
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
>
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
> Applied to dpdk-next-net/main, thanks.
>
>
> Moved 'latencystats' help string next to bitrate-stats, to group them
> together and keep same order with documentation.
> It makes this patch do two things but I didn't want to make separate
> patch just reorder help string, instead squeezed it into this one.
>
Make sense. Just wanted to make command matched help and documentation overall.
prev parent reply other threads:[~2024-01-10 23:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 23:09 Stephen Hemminger
2024-01-10 18:52 ` Ferruh Yigit
2024-01-10 23:25 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240110152559.0f9642d4@hermes.local \
--to=stephen@networkplumber.org \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=remy.horton@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).