From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34F0E43888; Thu, 11 Jan 2024 00:26:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B64C40278; Thu, 11 Jan 2024 00:26:04 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 2729D40266 for ; Thu, 11 Jan 2024 00:26:03 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1d54b86538aso22645835ad.0 for ; Wed, 10 Jan 2024 15:26:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1704929162; x=1705533962; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=04F9bjtMPEKs3TE5PTgx5S9dxrTvaUZwh4JSzwp7bxQ=; b=hOnLxP0N5FzgTX1S4GJmpjt3EJQogE6KzXK/53TopOEsBuUCMgntDzZj3RU5Q6YyV0 GOGDBgHxZ1erGGL4Ef6d/Yz2mkRrhdvFEuQhQoUOXWeysbhf2q+/vHeLmkcIklqKWcLk tXWNRIidQtPemHGlp5E6ZOIFyh4nOQKGJSbo4g8mKTui3QW83c8keWWNHjcHrPVR6WZ2 q3CNDrcunAbTMB1nteaTLvPgV9S5YOij9brvT0o0LUJua6ke7uWB2xLuuEsZrwLxewvU FbrA15dTrmLSt/HLDGOrqHAAu42Y/8OmHEjtRFj4pSnT00MfuXES9rRrY2y4yebFaF2I QZ4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704929162; x=1705533962; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=04F9bjtMPEKs3TE5PTgx5S9dxrTvaUZwh4JSzwp7bxQ=; b=NSgL9toxCSUVdBvRhRqiMay4ejdzH14QkNJPCB3Ix/ktntC01UiTlNoZzeSefEHIyZ 9jopd4lb4KsmS6oOhji13WO/TOabm+woFsd1GMOjmvoTNdijTmJ01Oq/U1+YEX+arNkG GaE7V1KysFyMU7yka8Dsb3WWtnwFsh1ZUlswR0RKkS0N8bK4yLbgbfhOJEa9Jcy8O4Xr 1MZOBiz9GEYVAGmyfHpsxJ5KbtYldQ2yJaqlJDW/H8kZpojx0h6PHbeBQIROQM2TzBXK 73MykUATlo0icG+Cb4x6DfUuJ9mpOf9CQKzUnF46JLBOEODT8LrwtIrd8r5Lg0UfEE/o wjXQ== X-Gm-Message-State: AOJu0YxVNO1vlzFfjlQ9bJYieBurxkNR1Fh3WkOUpeuxC5IUb/hbeXh6 Gjgv40GwdJcy0LsefQexY8meO8negE8uuA== X-Google-Smtp-Source: AGHT+IF/iS4LjxyhSmteA94GZ3+KXu/YHFGm3yKhus9xGiiuX/57CFGmnxJv7E9hSvKXFfWmjHDqWQ== X-Received: by 2002:a17:902:e841:b0:1cf:c9c3:e79d with SMTP id t1-20020a170902e84100b001cfc9c3e79dmr318488plg.59.1704929162165; Wed, 10 Jan 2024 15:26:02 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id n22-20020a170902969600b001d50766546dsm4156266plp.184.2024.01.10.15.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 15:26:01 -0800 (PST) Date: Wed, 10 Jan 2024 15:25:59 -0800 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org, Aman Singh , Yuying Zhang , Remy Horton , Pablo de Lara Subject: Re: [PATCH] testpmd: do not print bitrate-stats in help if not configured Message-ID: <20240110152559.0f9642d4@hermes.local> In-Reply-To: References: <20240109230927.6417-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 10 Jan 2024 18:52:39 +0000 Ferruh Yigit wrote: > On 1/9/2024 11:09 PM, Stephen Hemminger wrote: > > Like other #ifdef options, bitrate-stats should not be printed > > in help if not configured. > > > > Fixes: e25e6c70fb56 ("app/testpmd: add --bitrate-stats option") > > Signed-off-by: Stephen Hemminger > > > > Acked-by: Ferruh Yigit > > Applied to dpdk-next-net/main, thanks. > > > Moved 'latencystats' help string next to bitrate-stats, to group them > together and keep same order with documentation. > It makes this patch do two things but I didn't want to make separate > patch just reorder help string, instead squeezed it into this one. > Make sense. Just wanted to make command matched help and documentation overall.