From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F0BC4388B; Fri, 12 Jan 2024 17:46:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD90A402C5; Fri, 12 Jan 2024 17:46:51 +0100 (CET) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id 87CB2402AD for ; Fri, 12 Jan 2024 17:46:50 +0100 (CET) Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6d9bc8939d0so4306815b3a.0 for ; Fri, 12 Jan 2024 08:46:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1705078009; x=1705682809; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zhH/XCtlqZLBYhbr/j0fA/NYOC7NJ+alF0+1+g4cpOs=; b=XdYrWZzk6EgcXajx9t2Trtf5yfSVh8mzyJiGi+ICwOU5JyOJE9+9FxJ1UQcqY7SH9g zEvF+TW94Bi+aKpIDmx8awctRltAKbWAkMJZ0jfKRqaPmYLYVJLv2IonLaMYXeL8g55a Ov+FwIjNqNljSyM3yNwElCGzSbk+/RnxyPfxzokXdvrwIdX0ChR7KHLqhLSgNLG+UgnJ GEwxwhtB9XswyT9quOx/irxp2BhMVbiaFWB/a+dPiUv2h0yWDObCMdzFDYToYJQgMw3m l3GqTmaJWQvGJ2xmx1t/+1nkGI+lnwVG6t9uKv/TvsbAuRM5K7ewZzwnNDEBnWHmVMp5 h5/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705078009; x=1705682809; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zhH/XCtlqZLBYhbr/j0fA/NYOC7NJ+alF0+1+g4cpOs=; b=BPT5mPoDHeEvy7aHmP6A46NV4EuV15DjXVwXpvNbakZ9iRBgZg/ML+W9WNIk1dQTz5 iypfXiWsm9Y9RmSoHHNbJ6hef/aI/ekgqduFo5xDBFo4fuyI5xwY09tbQw9QKy0KOcIw YPk8ChSwcRnfDzsKPBAsOxO7vZVFb5/BpWPf8q6RPpjRBZyUSPRWLimBMvHVaNTindCe /MK0c9iGJm2WPN/GXqYpU8zXInpMK66SJR8G+eMx/IdShYqn261ygs/Ka0a0FIdDOj5o I8/JYEVWVfkgZ9WswVClDHl/F1J88Z3g1JbGRLGU98tyBOtf0ByBkUlkBXrlMkaWEccN 0waw== X-Gm-Message-State: AOJu0Yw839ksoWgTSeUsSfFZVbvwi6uVQZVM6zw7i8L7yXtWvxvImgn8 K3ZqHkoT6OVa3pFK4YeSYNkIEmMvg3cOew7u0UcnSBJt3rOPAhW3 X-Google-Smtp-Source: AGHT+IHSw8T1YnKUO9zd6bdKJGlS4LGngJC8xUM5I/cNCoAhxGBcge/Li03GHcwwx0IcGrW3NbTKAQ== X-Received: by 2002:a05:6a00:39aa:b0:6d9:b6c0:d4f1 with SMTP id fi42-20020a056a0039aa00b006d9b6c0d4f1mr1135818pfb.29.1705078009499; Fri, 12 Jan 2024 08:46:49 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id fh28-20020a056a00391c00b006d9bb753d2esm3388217pfb.166.2024.01.12.08.46.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 08:46:49 -0800 (PST) Date: Fri, 12 Jan 2024 08:46:48 -0800 From: Stephen Hemminger To: madhuker.mythri@oracle.com Cc: dev@dpdk.org, ferruh.yigit@amd.com Subject: Re: [PATCH] net/tap: Modified TAP BPF program as per the Kernel-version upgrade requirements. Message-ID: <20240112084648.7f7ff52a@hermes.local> In-Reply-To: <20240112134821.2067-1-madhuker.mythri@oracle.com> References: <20240112134821.2067-1-madhuker.mythri@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 12 Jan 2024 19:18:21 +0530 madhuker.mythri@oracle.com wrote: > struct ipv4_l3_l4_tuple v4_tuple = { > - .src_addr = IPv4(*(src_dst_addr + 0), > - *(src_dst_addr + 1), > - *(src_dst_addr + 2), > - *(src_dst_addr + 3)), > - .dst_addr = IPv4(*(src_dst_addr + 4), > - *(src_dst_addr + 5), > - *(src_dst_addr + 6), > - *(src_dst_addr + 7)), > + .src_addr = bpf_ntohl(nh.iph.saddr), > + .dst_addr = bpf_ntohl(nh.iph.daddr), Not sure this is correct. The RSS calculation (Toeplitz) expects that data is in network byte order. See app/test/test_thash.c for example.