From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1A8594388B;
	Fri, 12 Jan 2024 17:52:40 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 88F5B402C5;
	Fri, 12 Jan 2024 17:52:39 +0100 (CET)
Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com
 [209.85.210.177])
 by mails.dpdk.org (Postfix) with ESMTP id F2D14402AD
 for <dev@dpdk.org>; Fri, 12 Jan 2024 17:52:37 +0100 (CET)
Received: by mail-pf1-f177.google.com with SMTP id
 d2e1a72fcca58-6d9b5c4f332so4130164b3a.3
 for <dev@dpdk.org>; Fri, 12 Jan 2024 08:52:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1705078357;
 x=1705683157; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=pks+atFbBxYjYny5j5VnKPC41mhFo0xQLOfq/+HzAo4=;
 b=z9j60WRN0Ib4FwYmwMrF5lsvq7uO+vxQItdgSOB2JTwQTYL8AeEsRCId8gxomhjUDT
 rZ2cUd4mkwMfZsVYHNI7J7rrboErgKYTLlDk+e3ORB17/XB2PIT7oEviRDjMcLdMc5Mg
 tWnvmDsUON4OZp0i3cR1WHOCQwoozQL/SHds5ew8sY9M9mBvuGOnF74UkITWfJtCZagH
 ToT/rB7FxqJGN0+gPny/g7tjMXjrVcYhjZzFY8GPxqWUbLN4LhF8/XeN0Ou703XhK+Le
 0y2SpcXJ7gQDUpGvyeKZ0OYrwd5dbej5690ZCJUtkTApVxrHajbtG71lBAqDPqhklP53
 Bobg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1705078357; x=1705683157;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=pks+atFbBxYjYny5j5VnKPC41mhFo0xQLOfq/+HzAo4=;
 b=rS9jhNQKdK0ZxasgpypIVnf/osN21rfUTTl1ADII+yCwtEKbsoboFRKW35NQOvPP8W
 R1UI2uhB4P7exKDRt7g+9v28bFZiKl1Q4gf8DaWCo0PaBYmJjUWGwLLkYUs5FJ6SG4vj
 4Ern1ICzGiYIysdq57BBDjBvVwUxZOEWb7Cwx/4rKJZDPDeGU2tfVYc2EDoELy/3IPfg
 8HrcGJT5Y/b7PYlIkOHIP0YnjkABPdwyBjrzt8YARpqJZ7ftg4NV5PIMHdgwfX5ThQY4
 SgSuWDjQs0/LrdgT3vh3/rvvF9YYufYA1NEfx+3FL4otuNywccUOFvqIvbT4/8psn8Io
 WL7g==
X-Gm-Message-State: AOJu0Yyck/CMX8pLs8bnINFvPhxOi0ufsD6ISpAWKD1aErV1PcHNLTyc
 BSZh65Hmd/6iw7/rANDNCW3hLrkArP085w==
X-Google-Smtp-Source: AGHT+IGexjJ15rOWegLatu9EDfShEG+XcXsXl033XdE5Uf3WcPWCzeXgwWHVJf04UC91kIuu1LxJ4A==
X-Received: by 2002:a05:6a20:3ca2:b0:19a:7ad4:416 with SMTP id
 b34-20020a056a203ca200b0019a7ad40416mr1225188pzj.24.1705078357052; 
 Fri, 12 Jan 2024 08:52:37 -0800 (PST)
Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])
 by smtp.gmail.com with ESMTPSA id
 mf15-20020a17090b184f00b0028cef2025ddsm4439051pjb.15.2024.01.12.08.52.35
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 12 Jan 2024 08:52:36 -0800 (PST)
Date: Fri, 12 Jan 2024 08:52:33 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: <jerinj@marvell.com>
Cc: <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit
 <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 <ferruh.yigit@xilinx.com>, <ajit.khaparde@broadcom.com>,
 <aboyer@pensando.io>, <beilei.xing@intel.com>,
 <bruce.richardson@intel.com>, <chas3@att.com>, <chenbo.xia@intel.com>,
 <ciara.loftus@intel.com>, <dsinghrawat@marvell.com>,
 <ed.czeck@atomicrules.com>, <evgenys@amazon.com>, <grive@u256.net>,
 <g.singh@nxp.com>, <zhouguoyang@huawei.com>, <haiyue.wang@intel.com>,
 <hkalra@marvell.com>, <heinrich.kuhn@corigine.com>,
 <hemant.agrawal@nxp.com>, <hyonkim@cisco.com>, <igorch@amazon.com>,
 <irusskikh@marvell.com>, <jgrajcia@cisco.com>, <jasvinder.singh@intel.com>,
 <jianwang@trustnetic.com>, <jiawenwu@trustnetic.com>,
 <jingjing.wu@intel.com>, <johndale@cisco.com>,
 <john.miller@atomicrules.com>, <linville@tuxdriver.com>,
 <keith.wiles@intel.com>, <kirankumark@marvell.com>, <oulijun@huawei.com>,
 <lironh@marvell.com>, <longli@microsoft.com>, <mw@semihalf.com>,
 <spinler@cesnet.cz>, <matan@nvidia.com>, <matt.peters@windriver.com>,
 <maxime.coquelin@redhat.com>, <mk@semihalf.com>, <humin29@huawei.com>,
 <pnalla@marvell.com>, <ndabilpuram@marvell.com>, <qiming.yang@intel.com>,
 <qi.z.zhang@intel.com>, <radhac@marvell.com>,
 <rahul.lakkireddy@chelsio.com>, <rmody@marvell.com>, <rosen.xu@intel.com>,
 <sachin.saxena@oss.nxp.com>, <skoteshwar@marvell.com>,
 <shshaikh@marvell.com>, <shaibran@amazon.com>,
 <shepard.siegel@atomicrules.com>, <asomalap@amd.com>,
 <somnath.kotur@broadcom.com>, <sthemmin@microsoft.com>,
 <steven.webster@windriver.com>, <skori@marvell.com>, <mtetsuyah@gmail.com>,
 <vburru@marvell.com>, <viacheslavo@nvidia.com>, <xiao.w.wang@intel.com>,
 <cloud.wangxiaoyun@huawei.com>, <yisen.zhuang@huawei.com>,
 <yongwang@vmware.com>, <xuanziyang2@huawei.com>,
 <cristian.dumitrescu@intel.com>
Subject: Re: [dpdk-dev] [v1] ethdev: support Tx queue used count
Message-ID: <20240112085233.0164f8d8@hermes.local>
In-Reply-To: <20240111151745.3800170-1-jerinj@marvell.com>
References: <20231219172948.3909749-1-jerinj@marvell.com>
 <20240111151745.3800170-1-jerinj@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, 11 Jan 2024 20:47:44 +0530
<jerinj@marvell.com> wrote:

> @@ -116,7 +119,9 @@ struct rte_eth_fp_ops {
>  	eth_tx_descriptor_status_t tx_descriptor_status;
>  	/** Copy used mbufs from Tx mbuf ring into Rx. */
>  	eth_recycle_tx_mbufs_reuse_t recycle_tx_mbufs_reuse;
> -	uintptr_t reserved2[2];
> +	/** Get the number of used Tx descriptors. */
> +	eth_tx_queue_count_t tx_queue_count;
> +	uintptr_t reserved2[1];
>  	/**@}*/

This does introduce the question of were the reserved fields checked
in earlier versions. (ie. must be NULL).  But since the DPDK only expects rte_eth_fp_ops
to come from driver, and we don't guarantee ABI for driver API's, it is not a problem.