From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61165438AB; Fri, 12 Jan 2024 23:22:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD517402C5; Fri, 12 Jan 2024 23:22:56 +0100 (CET) Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by mails.dpdk.org (Postfix) with ESMTP id 30676402A9 for ; Fri, 12 Jan 2024 23:22:55 +0100 (CET) Received: by mail-il1-f179.google.com with SMTP id e9e14a558f8ab-3608cfa5ce6so27624875ab.0 for ; Fri, 12 Jan 2024 14:22:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1705098174; x=1705702974; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zedu6lzX0SG48jjHC1L7EAjmOpLdKlaHqHYsydPOIHw=; b=0TCIxj3/C1w+l9OQPxQ7ox5TgqEBKSkegSAbqqmNrqd3ehP+rbnkWcmZdQ+8BIamVO 5yLR42DtKIm0MphVitGC2PbC6cesaZhBgGHDWf82B6fvDhqh5PNuEsJ58CaMYh1RhDwa BOxrHQd+MldGrWEMGtrOTg2/GTIFBw+DMApPFnHvoM43X9Czk8yD0GTKNGg3YCtTnd6r alQdAtmuN2BdnXx2k3pdvCxrPWXpThv1g1jXgoA2TtrM1r4o78xb3Oy09GxrjLRV31/V yKTxgfzoiwzRLWTb+P7/2zppwtXSTWqUc0LtVSDzvnwgIT+Ld0Y1Ryi3Q7dAJKrwxS15 BrpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705098174; x=1705702974; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zedu6lzX0SG48jjHC1L7EAjmOpLdKlaHqHYsydPOIHw=; b=Fj9Z1/2NMiX6aoRCLpXeNjNnBcWLnBe8JRHzMfTYWneeTjUs22HRW8iWqn73UFidJq Z+IsH/bfxQet3xB+5jEjXcI19qYk9I3wCGAtuoLqx0bPrZnj199O00ItHHE4YbLHFgcN riJl7rzAkEtj537wkZsSRyJC+2gpqSwfELxL6CaZxOvp0dxBRAFgvy2ZqoCEGgnUZgai S6fPXl/sS2tXqpBOL9qqGDhjfKjMRUOZ/USRaRMemoFULzO+jtaeKY5tzPl93nKsDSaD 0Ke8JCoNLfzKv7NUG7ie8bC8xr57THrxfvCyHI+XHyFJrFB+oOErNQHW5Wd0qXyDryKh VurA== X-Gm-Message-State: AOJu0Yxi0yADo5sLLF6tk/IY6yJW8cP4UBKymxQimLQqoye0ePcSZMG1 kaZNVPhkhu3Oea+iKv+78+NYA7WIC6KiffftX3/vcMwHNUk2WQ== X-Google-Smtp-Source: AGHT+IFzPmkEBAUUVlkbr+EATfYgRGjb2fq6qPs6UsmNrvmUrGf5JTp0kItj+O8nMpwO1rNZxBHr9Q== X-Received: by 2002:a92:cdac:0:b0:360:5840:64be with SMTP id g12-20020a92cdac000000b00360584064bemr2083729ild.38.1705098174237; Fri, 12 Jan 2024 14:22:54 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id b14-20020a6567ce000000b005ce979b861dsm3212119pgs.84.2024.01.12.14.22.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 14:22:53 -0800 (PST) Date: Fri, 12 Jan 2024 14:22:52 -0800 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: "Tyler Retzlaff" , "Bruce Richardson" , Subject: Re: [PATCH] build: fix linker warnings about undefined symbols Message-ID: <20240112142252.40a46934@hermes.local> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F14E@smartserver.smartshare.dk> References: <20240110150103.529080-1-bruce.richardson@intel.com> <20240110165814.GA25069@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <98CBD80474FA8B44BF855DF32C47DC35E9F125@smartserver.smartshare.dk> <20240112201102.GA21063@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <98CBD80474FA8B44BF855DF32C47DC35E9F14E@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 12 Jan 2024 21:49:13 +0100 Morten Br=C3=B8rup wrote: > > you can use symver in combination with visibility default > >=20 > > https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html > >=20 > > anyway just food for thought, it would get me out of having to hack & > > enhance the .def from .map generation and unfortunately even with that > > there are going to be cases where i still have to annotate the actual > > symbol export in code (for windows). > >=20 > > just thought a more unified approach for all might appeal. =20 >=20 > Assuming that we truly want DPDK to support Windows, a more unified appro= ach is a reasonable ask. >=20 > If we can eliminate the technical obstacles, we should pursue it. >=20 > We may have to sacrifice some "nice to have" advantages of the version.ma= p files along the way, such as having easy access to the list of experiment= al functions in the version.map file. Ideally __rte_experimental macro would do the right thing to make it public= ly visible in the right section.