From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: ktraynor@redhat.com, john.mcnamara@intel.com,
ian.stokes@intel.com, stable@dpdk.org,
Jingjing Wu <jingjing.wu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Mingjin Ye <mingjinx.ye@intel.com>
Subject: [PATCH] net/iavf: fix application reset callback calls
Date: Wed, 17 Jan 2024 12:54:10 +0100 [thread overview]
Message-ID: <20240117115410.3984237-1-david.marchand@redhat.com> (raw)
Don't trigger an application reset callback if the port is not started.
Bugzilla ID: 1337
Fixes: 675a104e2e94 ("net/iavf: fix abnormal disable HW interrupt")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/iavf/iavf_vchnl.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 0a3e1d082c..14dfe313b7 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -88,7 +88,10 @@ iavf_dev_event_handle(void *param __rte_unused)
continue;
}
- rte_eth_dev_callback_process(pos->dev, pos->event, pos->param);
+ /* Don't invoke an application reset callback if not started yet. */
+ if (pos->event != RTE_ETH_EVENT_INTR_RESET ||
+ pos->dev->data->dev_started != 0)
+ rte_eth_dev_callback_process(pos->dev, pos->event, pos->param);
rte_free(pos);
}
}
--
2.43.0
next reply other threads:[~2024-01-17 11:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 11:54 David Marchand [this message]
2024-02-01 8:58 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240117115410.3984237-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=ktraynor@redhat.com \
--cc=mingjinx.ye@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).