From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0CC043901; Fri, 19 Jan 2024 17:58:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE7CD42D92; Fri, 19 Jan 2024 17:58:34 +0100 (CET) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id 4C7A942D95 for <dev@dpdk.org>; Fri, 19 Jan 2024 17:58:33 +0100 (CET) Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-5cf87cdc4c5so849185a12.1 for <dev@dpdk.org>; Fri, 19 Jan 2024 08:58:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1705683512; x=1706288312; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=mLk/LNZO9Apvg3EsbO4J0QiiLZLeLI6eMseDx7zWTFw=; b=Tv690VXJwdYZkgswDeq6kezXKUuWPOGnwnDZWrSlvyJBJVySUBYFitHGbHm8LbDtDd Tf6URKoKxumu5Ii/hr0IZ++3qnJD8YZF5g74P7e2uRVA7dNbdrB36cYfIFyyy6Xh071U 6gAUZKd+TqgeK519pJs0oBw8GUMfkUIGNYTyEtyYvEW5gds1FdvjXqzV99lwGQ8HFTi0 BFTa+fF2KeLwzpYsLRYNcIY5dUF09w0RUuBvWJlIQGlm0R7S08SfqnBWNXOdKUo3PSp5 3oZSDXvTifC8FU+8ic6LZNIv8wulZbL4/HKTToGvxklNhxlsf8SWNqJgXjsxyX/eBQbO CXTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705683512; x=1706288312; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mLk/LNZO9Apvg3EsbO4J0QiiLZLeLI6eMseDx7zWTFw=; b=GR9q9a3xneiVbM5ZQN4cW/2Wq2WsiaEu342BQsDIpgnSVR2I9bB/28VqOJdv3Sselm 2Uu7O3fPj6emZiGkeq/py/FXoid4vWE6/Y/0oWYoa1iKjTOeD6eD8ZRDcA0sKjhg3ctC t5uyQtN+rcUIeE43/I9YTNJCfsUIDO3ZHyBVI/CFiEkmxJpPKUGY0Znfk0wL7GLWFhus u4+M1FaKjY63v+O7zSMC4LKsEsugM5agerGXdanK0HYrXT41Gv34EwpxapR23SJQ59Gs F5y7p/acUcrJvUNpzOhWC/hi/i65eHk8T86yi77fFDfFEUSEikcs5qMYbDOzD/51S1QS QxUg== X-Gm-Message-State: AOJu0YyZCH8UrxaQqpA1D2XKoBaunvVXFC25A8b4b/M5P71hnhXX6rr8 m0WhwVhDchzY4OeKTOJoONSXVfcbFmKvjrGwJ00C/3fGXkQHHuKwKQzt+BqLnWpjHgJZdjSeKj/ S4Kg= X-Google-Smtp-Source: AGHT+IFwENKc4P3fKp2hPzodcBYFFrQvg6B0U8Nv/Rqm9c8SwLtYR5JPLys5R23XiR2T4xlU0MzYPA== X-Received: by 2002:a05:6a20:160f:b0:19a:7698:fe06 with SMTP id l15-20020a056a20160f00b0019a7698fe06mr170804pzj.20.1705683512514; Fri, 19 Jan 2024 08:58:32 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id d7-20020aa78147000000b006dbc6a5daa5sm892413pfn.154.2024.01.19.08.58.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 08:58:32 -0800 (PST) Date: Fri, 19 Jan 2024 08:58:30 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: David Marchand <david.marchand@redhat.com> Cc: dev@dpdk.org Subject: Re: [PATCH v6 00/20] Remove uses of PMD logtype Message-ID: <20240119085830.45bd6a67@hermes.local> In-Reply-To: <CAJFAV8xd=706Ofga8Z0NcBLJ39V8CGoqzEFFDY_r652kw1RSrQ@mail.gmail.com> References: <20231213014408.612051-1-stephen@networkplumber.org> <20231222171820.8778-1-stephen@networkplumber.org> <CAJFAV8xd=706Ofga8Z0NcBLJ39V8CGoqzEFFDY_r652kw1RSrQ@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, 19 Jan 2024 14:59:58 +0100 David Marchand <david.marchand@redhat.com> wrote: > This series mixes unrelated changes, like adding missing \n or > removing some of them. > I identified a couple of places where it introduces issues by doing so. > > Please focus on changing the logtype / log macros and not silently > "fix" other log issues. > We can fix the latter, later. > > > Details of what I spotted: > > - there is the "funny" case of event/dlb2 where the DLB2_LOG_DBG macro > does not add a \n, while _INFO and _ERR do, > > - there is also the case of some _DP log macros in some drivers. > For the drivers below, the _DP macro won't add a \n, while their non > _DP macro equivalent do add one... I wonder should _DP macros behave same as non _DP versions around newline. It makes sense to me that it should always be the same. If so, let me split that as step 1 in these cases.