From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 466F043902;
Fri, 19 Jan 2024 17:41:42 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 158EC40297;
Fri, 19 Jan 2024 17:41:42 +0100 (CET)
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
(mail-bn8nam12on2077.outbound.protection.outlook.com [40.107.237.77])
by mails.dpdk.org (Postfix) with ESMTP id A85D740279
for <dev@dpdk.org>; Fri, 19 Jan 2024 17:41:40 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=LEp40g1QVaAKnrZDzRmrSKZ1T9iMDps2+omQaMGEwxqn9fe4SRafcQBLx6snz8K4grcCmKFOuT4h6R4eV+SR13IwA2qLr89xCbDlvTsGj3Ee4PKlsm80W/yQDyOVMadf9ZGiNuMV/Cnp1D8Qg2ILe7IU5vksXkyPfCvK+rTXae1WKOjGnHupI0aJ/YPSPiWkpcZ5CiqKVWBECDt5ysFWP01D7SMNK2m1TiUCwDLFOIlJzPUdlhisdhDlVCJAhMGi5RdSXhFG9HBnGUZIWdYj/vEKlmnnFxQ2EMZMGHPrh4jRXORi/qbPFc6BoLMxxtN8d+Ozrtgvc60A54eH6Gl51Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=eRe24UN5aF9AUOmRaumPS7tP2JBWtqQQkte+633Qapk=;
b=Lm8NkumH17d6YhoGPrc5QbAYMCPkvT6/DJLrUTsUp1AJ312mCl09VceOuZh2Adz3lTc1MJTOYp8k93WOuU5ERvLb3ZEae8uLfWIGNvr7hGcOUvEoh2IP+R38ScHjc/VLgknCWSHxaSMqfkb5AgehrpgDfGO38ImuV/OSIkNshheFEfzmRgmv8i9it77djlwIdFVGMVg6zWQE0t7qM568saISLQFCHdfB2OCh9nWCXARDJWmz01IawsqlajUeyF3G1iqcKM6yEUhFaD9Llu7V97QzeLCD7BurjcHdEvkdHcK+1fSi2ahwbG1MuopMtScQinr3y4rM4Uru7aEz4uO0ow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass
(p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
dkim=none (message not signed); arc=none (0)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=eRe24UN5aF9AUOmRaumPS7tP2JBWtqQQkte+633Qapk=;
b=yhK/8I8q9q08yl9RZRgnqVgDQttA1DMMF6Xkk3GpLFOldHsmEEgnelYcw8sFpeHZkRQg6y0Asb4vAkd8mP7cRnFSJ4Gfvb9HKOJZV6fwlH94qkUGQxlAxa/F/72Yg2C+uw689/V/sR77QLMytnhW2m4XsQ3r4m2cmB/AbVPK2d4=
Received: from BLAPR03CA0126.namprd03.prod.outlook.com (2603:10b6:208:32e::11)
by PH0PR12MB5433.namprd12.prod.outlook.com (2603:10b6:510:e1::22)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.24; Fri, 19 Jan
2024 16:41:38 +0000
Received: from BL6PEPF0001AB58.namprd02.prod.outlook.com
(2603:10b6:208:32e:cafe::6a) by BLAPR03CA0126.outlook.office365.com
(2603:10b6:208:32e::11) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.26 via Frontend
Transport; Fri, 19 Jan 2024 16:41:38 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
smtp.mailfrom=amd.com; dkim=none (message not signed)
header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
165.204.84.17 as permitted sender) receiver=protection.outlook.com;
client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Received: from SATLEXMB04.amd.com (165.204.84.17) by
BL6PEPF0001AB58.mail.protection.outlook.com (10.167.241.10) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.20.7181.14 via Frontend Transport; Fri, 19 Jan 2024 16:41:38 +0000
Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com
(10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 19 Jan
2024 10:41:37 -0600
From: Andrew Boyer <andrew.boyer@amd.com>
To: <dev@dpdk.org>
CC: Akhil Goyal <gakhil@marvell.com>, Andrew Boyer <andrew.boyer@amd.com>
Subject: [PATCH] cryptodev: add a simple mapping cache to speed up ops pool
create
Date: Fri, 19 Jan 2024 08:41:22 -0800
Message-ID: <20240119164122.11829-1-andrew.boyer@amd.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.180.168.240]
X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com
(10.181.40.145)
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB58:EE_|PH0PR12MB5433:EE_
X-MS-Office365-Filtering-Correlation-Id: 217ed90e-67c2-44bc-7070-08dc190d81bc
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: g7QeARfiMZ+HKKSQ2wPwndD13DJ8MYIttuTTM+IAUOVXGLehogi6SyoebE0i24bpkNpTKed26NhBPfvjWf492od0xUel0BjkgJ538oxMdtyQ3FgZ40eylsxUlAIeLXeYe+hmpL5W/eCTzSnfjgs5g8DDZ/Y8whptBTzjZVVonWgjRKLoDNx3CAya6QM37tp07Wpidpo+i9Eaxka4h38UtSLfnuurAjAnwT0H2Opaw+vP4rGammoAZb0P0bDKzRJ8OvTLiZsO1PCiWHAwdvd8Vl67zuxXFUoHac3E8LKX8N9/H856KbIifjePtzWSO6191/TjpjOZP2OFdagibEJ7zWQS9uXCX0CNkGxUvxhgcOt6IZKFTWXm3K6zcA81kajsTLJqrTHGCQaGbbN4mWjESKleBAdNgNPDw+RRs1s50pjDUYu6zxBeKNMwhXPyKgP4nwkD1/tOrsiE+1iCcaLBOnToP/9xp1EHXIkdu7hBDbiNNpOBVSf+jly+MfEggOV4zprwlUUiPCk8B1Y3ixaHTjZogzenSecp6LVCbZqEYq29ZRwdX4/x3wi3G8yyhwmFeTefSJB+9Gu+cQb1GeLPyRqHNPCA9OMPt09Kao+vP5Hzmpu/12nomkYEVK5yEJKVWdBx6aTVLBPTi6sq2gYF7yXV5nNa9OKIbbbln/2PXitq0zXtkRQVu+6Yoeo9FAz1VCkYPrWol/gp5alOJyd19Uk4gzU43WDSUupJTYiCe4Ou/NxiMtvaijXGLfeaYuGo0JOwn+TZrxvDh3fBStquzw==
X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;
IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;
SFS:(13230031)(4636009)(136003)(396003)(376002)(346002)(39860400002)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(82310400011)(36840700001)(40470700004)(46966006)(4326008)(2616005)(26005)(16526019)(1076003)(6666004)(336012)(426003)(83380400001)(44832011)(6916009)(316002)(86362001)(8936002)(8676002)(70586007)(54906003)(356005)(70206006)(478600001)(36860700001)(81166007)(82740400003)(47076005)(41300700001)(40460700003)(36756003)(5660300002)(40480700001)(2906002)(36900700001);
DIR:OUT; SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2024 16:41:38.1334 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 217ed90e-67c2-44bc-7070-08dc190d81bc
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];
Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB58.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5433
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Cache the most recent VA -> PA mapping found so that we can skip
most of the system calls. With 4K pages this reduces pool create
time by about 90%.
Signed-off-by: Andrew Boyer <andrew.boyer@amd.com>
---
lib/cryptodev/rte_crypto.h | 5 +++++
lib/cryptodev/rte_cryptodev.c | 23 ++++++++++++++++++++++-
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/lib/cryptodev/rte_crypto.h b/lib/cryptodev/rte_crypto.h
index dbc2700da5..ee6aa1e40e 100644
--- a/lib/cryptodev/rte_crypto.h
+++ b/lib/cryptodev/rte_crypto.h
@@ -220,6 +220,11 @@ struct rte_crypto_op_pool_private {
/**< Crypto op pool type operation. */
uint16_t priv_size;
/**< Size of private area in each crypto operation. */
+
+ unsigned long vp_cache;
+ /* Virtual page address of previous op. */
+ rte_iova_t iovp_cache;
+ /* I/O virtual page address of previous op. */
};
diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
index b233c0ecd7..d596f85a57 100644
--- a/lib/cryptodev/rte_cryptodev.c
+++ b/lib/cryptodev/rte_cryptodev.c
@@ -10,6 +10,7 @@
#include <errno.h>
#include <stdint.h>
#include <inttypes.h>
+#include <unistd.h>
#include <rte_log.h>
#include <rte_debug.h>
@@ -2568,12 +2569,32 @@ rte_crypto_op_init(struct rte_mempool *mempool,
{
struct rte_crypto_op *op = _op_data;
enum rte_crypto_op_type type = *(enum rte_crypto_op_type *)opaque_arg;
+ struct rte_crypto_op_pool_private *priv;
+ unsigned long virt_addr = (unsigned long)(uintptr_t)_op_data;
+#ifdef RTE_EXEC_ENV_WINDOWS
+ unsigned long page_mask = 4095;
+#else
+ unsigned long page_mask = sysconf(_SC_PAGESIZE) - 1;
+#endif
+ unsigned long virt_page = virt_addr & ~page_mask;
memset(_op_data, 0, mempool->elt_size);
__rte_crypto_op_reset(op, type);
- op->phys_addr = rte_mem_virt2iova(_op_data);
+ priv = (struct rte_crypto_op_pool_private *)
+ rte_mempool_get_priv(mempool);
+
+ if (virt_page == priv->vp_cache) {
+ op->phys_addr = priv->iovp_cache + (virt_addr & page_mask);
+ } else {
+ op->phys_addr = rte_mem_virt2iova(_op_data);
+
+ /* Update cached values */
+ priv->vp_cache = virt_page;
+ priv->iovp_cache = op->phys_addr & ~page_mask;
+ }
+
op->mempool = mempool;
}
--
2.17.1