From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D05F439C9; Fri, 26 Jan 2024 01:29:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2063B402A7; Fri, 26 Jan 2024 01:29:23 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 2B23840289 for ; Fri, 26 Jan 2024 01:29:21 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1d71cb97937so48330055ad.3 for ; Thu, 25 Jan 2024 16:29:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706228960; x=1706833760; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=0SpkVk9PoXZ61MNflMDrJ5rAg/+DZEJn0wXyW4OqTSs=; b=BnkO32JWSmoqW+Ij5cQ+7d9r6RBGOulTbnk1zIGyZ3nMVyurooLn/2n7LUyPUk8Pfz ly80/oD9SlRFK93jR/1vsAh02HCOWj+f8MgumXfEVa+7L3huL+0C3lA8Qm1+c7k/O3uJ nL3PvVIb3Nzm0K5H6vIORrN8zjxgXFCeSr8HaA5W+pEvx0gB7oQbkCDUP7qaf0KiqzDz 0x7oFjc/LGPRDNFe0R2+SNm+f2AUBugahck/YjLabs/Ls3hYYSUsD5lB3VVlB4Sn1mlk lJth5rk39juf/wxCo0B/h9QCbUwdLuQzgaHQ+BEnaCNHHGc2oB8a1Xqyln9H2gSA/HAy 0Lfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706228960; x=1706833760; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0SpkVk9PoXZ61MNflMDrJ5rAg/+DZEJn0wXyW4OqTSs=; b=uPCkQdwbRncajx2HylwU6H0uTZuGsOk+Nd40F2CDHPdqnqfM9h6Nf+ZYuC9oYfJ673 LwrbREqFUAmB6EejvOlESg3feEuStcuBzfOf++TLDGBk+3sTDf3Sd5iiDfpaQfo2l3vn ga1UZ9BM3hJqNxcOKV1Ie6qjujG6n0BSJoMSkmnj41mcydP5NMlWNoS1qGx5X2rBQW3d yRqhfJtShPB9qOtyCMXn5uH/kITMJVUSqqYEtC57cgZcQIlpF0gs8TE1uvQosCIWzBZm Osy8xNwH7FGs6lbb94jIz4jvCg4lz1CO1HP6QzhC33BdN2PyNTYLpESvKT4e18A2tihW Mw/Q== X-Gm-Message-State: AOJu0Yzprrw3FisNhJaCmdPU4jUGU9+3Fgx+DBHbjlxMd+bFAp3GiVVX wt6IooFg19pw5i94525iRq+j2pTiaSZD84QKzPBas52BONFJty5KAio/z7qsILA= X-Google-Smtp-Source: AGHT+IH6PMoYgRt7Dr3wT/1/z/eoPDf2iwEnC5rC4MEJoXS5lCCJ++ReLac6V6yDkF+mk79P9vuFpQ== X-Received: by 2002:a17:902:e74b:b0:1d8:877f:51d9 with SMTP id p11-20020a170902e74b00b001d8877f51d9mr545096plf.8.1706228960240; Thu, 25 Jan 2024 16:29:20 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id t6-20020a170902bc4600b001d704905e9fsm73249plz.259.2024.01.25.16.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 16:29:20 -0800 (PST) Date: Thu, 25 Jan 2024 16:29:18 -0800 From: Stephen Hemminger To: longli@linuxonhyperv.com Cc: Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org, Long Li Subject: Re: [PATCH] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs Message-ID: <20240125162918.15a066da@hermes.local> In-Reply-To: <1706150562-23248-1-git-send-email-longli@linuxonhyperv.com> References: <1706150562-23248-1-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 24 Jan 2024 18:42:42 -0800 longli@linuxonhyperv.com wrote: > + struct rte_mbuf **mbufs; > + > + mbufs = rte_calloc("mana_rx_mbufs", count, sizeof(struct rte_mbuf *), 0); > + if (!mbufs) > + return -ENOMEM; Looks good, you might want to make this numa aware in some future version. Reviewed-by: Stephen Hemminger