* [PATCH] meson: link static libs with whole-archive in subproject
@ 2024-01-29 12:47 Robin Jarry
2024-01-29 12:55 ` David Marchand
0 siblings, 1 reply; 4+ messages in thread
From: Robin Jarry @ 2024-01-29 12:47 UTC (permalink / raw)
To: dev, Bruce Richardson, Stephen Hemminger, Ben Magistro; +Cc: stable
When DPDK is used as a subproject, declare static libs to be linked with
-Wl,--whole-archive along with the drivers. This is already done this
way in pkg-config.
Fixes: f93a605f2d6e ("build: add definitions for use as Meson subproject")
Cc: stable@dpdk.org
Signed-off-by: Robin Jarry <rjarry@redhat.com>
---
buildtools/subproject/meson.build | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/buildtools/subproject/meson.build b/buildtools/subproject/meson.build
index 985ce76a9384..aa28f5fae152 100644
--- a/buildtools/subproject/meson.build
+++ b/buildtools/subproject/meson.build
@@ -8,8 +8,7 @@ if get_option('default_library') == 'static'
dependencies: dpdk_static_lib_deps,
# static library deps in DPDK build don't include "link_with" parameters,
# so explicitly link-in both libs and drivers
- link_with: dpdk_static_libraries,
- link_whole: dpdk_drivers,
+ link_whole: dpdk_static_libraries + dpdk_drivers,
link_args: dpdk_extra_ldflags)
else
dpdk_dep = declare_dependency(
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] meson: link static libs with whole-archive in subproject
2024-01-29 12:47 [PATCH] meson: link static libs with whole-archive in subproject Robin Jarry
@ 2024-01-29 12:55 ` David Marchand
2024-01-29 13:17 ` Bruce Richardson
0 siblings, 1 reply; 4+ messages in thread
From: David Marchand @ 2024-01-29 12:55 UTC (permalink / raw)
To: Robin Jarry
Cc: dev, Bruce Richardson, Stephen Hemminger, Ben Magistro, stable
On Mon, Jan 29, 2024 at 1:47 PM Robin Jarry <rjarry@redhat.com> wrote:
>
> When DPDK is used as a subproject, declare static libs to be linked with
> -Wl,--whole-archive along with the drivers. This is already done this
> way in pkg-config.
>
> Fixes: f93a605f2d6e ("build: add definitions for use as Meson subproject")
> Cc: stable@dpdk.org
>
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
Tested-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] meson: link static libs with whole-archive in subproject
2024-01-29 12:55 ` David Marchand
@ 2024-01-29 13:17 ` Bruce Richardson
2024-02-18 17:46 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2024-01-29 13:17 UTC (permalink / raw)
To: David Marchand; +Cc: Robin Jarry, dev, Stephen Hemminger, Ben Magistro, stable
On Mon, Jan 29, 2024 at 01:55:36PM +0100, David Marchand wrote:
> On Mon, Jan 29, 2024 at 1:47 PM Robin Jarry <rjarry@redhat.com> wrote:
> >
> > When DPDK is used as a subproject, declare static libs to be linked with
> > -Wl,--whole-archive along with the drivers. This is already done this
> > way in pkg-config.
> >
> > Fixes: f93a605f2d6e ("build: add definitions for use as Meson subproject")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Robin Jarry <rjarry@redhat.com>
> Tested-by: David Marchand <david.marchand@redhat.com>
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] meson: link static libs with whole-archive in subproject
2024-01-29 13:17 ` Bruce Richardson
@ 2024-02-18 17:46 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2024-02-18 17:46 UTC (permalink / raw)
To: Robin Jarry
Cc: David Marchand, dev, Stephen Hemminger, Ben Magistro, stable,
Bruce Richardson
29/01/2024 14:17, Bruce Richardson:
> On Mon, Jan 29, 2024 at 01:55:36PM +0100, David Marchand wrote:
> > On Mon, Jan 29, 2024 at 1:47 PM Robin Jarry <rjarry@redhat.com> wrote:
> > >
> > > When DPDK is used as a subproject, declare static libs to be linked with
> > > -Wl,--whole-archive along with the drivers. This is already done this
> > > way in pkg-config.
> > >
> > > Fixes: f93a605f2d6e ("build: add definitions for use as Meson subproject")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Robin Jarry <rjarry@redhat.com>
> > Tested-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-18 17:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-29 12:47 [PATCH] meson: link static libs with whole-archive in subproject Robin Jarry
2024-01-29 12:55 ` David Marchand
2024-01-29 13:17 ` Bruce Richardson
2024-02-18 17:46 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).