From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68FD643A57; Sat, 3 Feb 2024 05:26:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 402C3402BB; Sat, 3 Feb 2024 05:26:39 +0100 (CET) Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by mails.dpdk.org (Postfix) with ESMTP id 668A1402BB for ; Sat, 3 Feb 2024 05:26:38 +0100 (CET) Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3bba50cd318so2174498b6e.0 for ; Fri, 02 Feb 2024 20:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706934397; x=1707539197; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=BwGRNMYKBgm3iRyhYNF242qBuSde/6U/zQPf9XX2VyE=; b=StbQz4N51tDYnWp7zfv59XSjcy0vCnpzAfV7FUo6xEpK+ZeH3uE4OvFGtZT7faDEPY 99l4ODD3l+Nyn0MbVXsOTtpv8V4Zys20/l2RJcFoNSl5t6usJ5lp4L0HC0Gh0vvJwD/k rr8vF9j4cXd1AaiE2vzHqKFysDhl6xCuDtiaCP6N2Ex5FTGr+hzVsho5qeUrY+9b4RlR 6Q26NZJcgocKCDmQrRyVLJASUgaGgi7S1nxpHq6NKmDlLvmjcKocUYDiTXdD81xfcYR9 HK9B4L9HG2AqUvSjBBKQzA79uTrhTDvPWfyVvdJapOuRaj24sGTIirL92cVfsAa70weG 3nhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706934397; x=1707539197; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BwGRNMYKBgm3iRyhYNF242qBuSde/6U/zQPf9XX2VyE=; b=XtXvOfMU1IdJ9NNUT5ZP7StvB/pLlTUC1+GnjI6RPzV4A0AJ21wg+t5rnfC1T4ai+R KmKKvD13uep/P3e/0dUGIlfZzol362KVmm7mHI0lWZVam15pp5VtotFVw4iQDT+tbU+F 3BdV/R0cJoPJv1JOSc1+CAtXfl5cbqZiw6fNXp5/0O438Dw6bvASBQIKwGWpJmrMA9Mk j6JiefVyZtpnYreLh7UpBQgiFlPinrlpRfEZSDNzq4OLFh3LazmXbbBOjwi2dgcRJ9hA tM7Cz1NbMDKIPjyQChJJwbQBoWFLBgpryTD1rlW8rZ1BXzwKJXfwBCmovDHmtRD+UIMp +EVw== X-Gm-Message-State: AOJu0YwvvO/sfm4I81tyV1QvQJV4hDg8R+20LWS7JM0cF/sc0JsOyI0m AyelHvsDbvIw1NTfkCvxowx/xYrYepveslFv6f86CEUtiY+kzmBGZVAhRIf2GcU= X-Google-Smtp-Source: AGHT+IGYqknK5V43kapztCshvbjQzxL1dkCbio2smv5c3EGqiFuARsjFES9gf2voX+J0pFg1+d551Q== X-Received: by 2002:a05:6808:2dc8:b0:3be:c3c2:1751 with SMTP id gn8-20020a0568082dc800b003bec3c21751mr13172888oib.32.1706934397636; Fri, 02 Feb 2024 20:26:37 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUIOZpfBVM5L4xBhTwmQZh9rYQO2fafuqlUZvBMOhv7Njbn/Au/RCVIOl7//Iy9uq9Qlj7dPqcVDnnrFs2fl/NgObNAlS6O0IZFRnt9pHItByw6Hg== Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id z14-20020aa785ce000000b006dbd5a5dca9sm2457321pfn.185.2024.02.02.20.26.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:26:37 -0800 (PST) Date: Fri, 2 Feb 2024 20:26:36 -0800 From: Stephen Hemminger To: Andrew Boyer Cc: , Neel Patel , Subject: Re: [PATCH 04/13] net/ionic: fix missing volatile type for cqe pointers Message-ID: <20240202202636.450b1b38@hermes.local> In-Reply-To: <20240202193238.62669-5-andrew.boyer@amd.com> References: <20240202193238.62669-1-andrew.boyer@amd.com> <20240202193238.62669-5-andrew.boyer@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 2 Feb 2024 11:32:29 -0800 Andrew Boyer wrote: > From: Neel Patel > > This memory may be changed by the hardware, so the volatile > keyword is required for correctness. > > Fixes: e86a6fcc7cf3 ("net/ionic: add optimized non-scattered Rx/Tx") > cc: stable@dpdk.org > > Signed-off-by: Andrew Boyer > Signed-off-by: Neel Patel In general barriers are better than volatile. Volatile is a compiler not hardware construct really. https://www.kernel.org/doc/html/latest/process/volatile-considered-harmful.html