From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F216743A2A; Mon, 5 Feb 2024 23:04:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79B2D4067E; Mon, 5 Feb 2024 23:04:29 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 797E740270 for ; Mon, 5 Feb 2024 23:04:28 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1d94323d547so39654565ad.3 for ; Mon, 05 Feb 2024 14:04:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1707170667; x=1707775467; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=LYcSxm8XaQGhMscQ6azzAV82SATjwpeeitJOBirBPxg=; b=nJK0hHQejo3OsHuh1MOowp7AuUev0tQqRzEORrjoVbaCJ9MEVdpLqYKwl+OPVFByVo PCXiraN8/7OTSRjlppbCnSvqBRAWKTHYkmCqyTT3cEeS0/pa3Gq6DkrXpaH2H+4tCJ7P e5Edi5WcUM5RdhjUODOopC9dwHXfNDdX8jXRY7g2SzgCULmPBZh/SSfHHg1vcjOk+EJB c1IE9iVtGcUXIKDPbm8l+tVQfNz9D0+XHVzG+JEggpGw39PXt5dtJJ0Yw8NuXgrMm2hD /PjnUnXosweTLwPAasEJEjmeBBm93YVmwQzVHSVR86PapqNONU47ktrpl7ztY82j2x1C AM2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707170667; x=1707775467; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LYcSxm8XaQGhMscQ6azzAV82SATjwpeeitJOBirBPxg=; b=I49T3KWZI74EYpsfhRE2QCV8ScoTxUSPSvzGQKXCiRHb1bRmhNGHCqMjWJtWgCQm7i LfG8Rw3vX5Z5p8CL6q8InBHtluE6NhNQR/FtCUM3OONGA2D9Wp4SdxT2PlCwUqb7zXQj /l80bwS0+CXkN4a6OSZ3fAt6f3hyRgwOSQhNrx0DDuKPlpApwEj6pMc9GL+pbf92eQXV 9C6xHxFqGvs7uvQx9J66PB0AoZP6nwGw2r5Hwnl/Yg7z4GeBRH7r+8k8IUyTjt5Mmz4y a8oL+TDLaX4ap3X1w3Ce6uc9eVqUhhnJao0iGEIGe6ACxqxFZc+7BMvJxuP4+ICh4XXp vclg== X-Gm-Message-State: AOJu0YxkjhFoCTCPMB9axxgKaixiQH7jgjdkbvVFauzKnnSTdYV1/iYB in5dpfDa7jLa7FYwTGI+9iAHmJ4r3f3AibAbdugAkp2lZoKq8zvQnXWOIpL60/o= X-Google-Smtp-Source: AGHT+IFVqrJYwk/1y0tV7keaFURljA0PidmqdLGjXtB9ui21zc/J64KAJNeN9zekzwBYHkd+nGqCHw== X-Received: by 2002:a17:902:d50b:b0:1d9:4e4c:23d2 with SMTP id b11-20020a170902d50b00b001d94e4c23d2mr1005204plg.44.1707170667450; Mon, 05 Feb 2024 14:04:27 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXEz0t4vralu5ZLcYTJFtrjQxxtGknvOliWjpUNgFFZcoqUP2JloiN5K+hDf+NxHKKkY3ORCxhDw1sCplxV4Wbl2mAJtzSZcNru03c4CZ7QrckITIQFcSU4rvPCFSv9sA== Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id ky4-20020a170902f98400b001d9620dd3fdsm361529plb.206.2024.02.05.14.04.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 14:04:27 -0800 (PST) Date: Mon, 5 Feb 2024 14:04:25 -0800 From: Stephen Hemminger To: "Sevincer, Abdullah" Cc: "dev@dpdk.org" , Gage Eads , Timothy McDaniel Subject: Re: [PATCH v7 16/19] event/dlb2: use dedicated logtype Message-ID: <20240205140425.2a60a470@hermes.local> In-Reply-To: References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> <20240203041230.285599-17-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 5 Feb 2024 19:16:15 +0000 "Sevincer, Abdullah" wrote: > >+ DLB2_LOG_INFO("Ignoring unsupported parameters when creating device '%s'", > name); > > Hi Stephen can you modify above like this: > > DLB2_LOG_INFO(": Ignoring unsupported parameters when creating device '%s'\n", > name); > > It looks better this way the output will be like this after this modification: > > dlb2_parse_params: Ignoring unsupported parameters when creating device 'ea:00.0' I don't understand why you would say that. The message already will get a single newline and your change would add a second one. Log messages are not supposed to be double spaced, it confuses syslog. If you want to change the overall format of log messages and how it displays the function name, that is a different change. And would be done in the macro, DLB2_LOG_IMPL. The focus of this patch set is using existing format, if you want to change that please address it in another patch later.