From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6206343A2A;
Wed, 7 Feb 2024 04:14:23 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id D164842DBE;
Wed, 7 Feb 2024 04:14:21 +0100 (CET)
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
(mail-dm6nam12on2040.outbound.protection.outlook.com [40.107.243.40])
by mails.dpdk.org (Postfix) with ESMTP id 90E7A42D9D
for <dev@dpdk.org>; Wed, 7 Feb 2024 04:14:20 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=a1CIz8GSwzfTI7Im+B1ZEPjHFGOdqSyrtz7MLMJc+6cDzDInqVluCelibc0vndAY6q56ksWF0lEld5FmHPaXAE7kO88r5kdQuhYZaWjbXEXDZpFBdVFdpQB5ewYauz1133DunIkXs7ah48h3z31DMOHL1PHwaSpE2PMy9gCWM32ik+K0pchonZIoV34q6XQWSvVIPiuQO/4t1A6piW4s14PTx9FvdTlaAdjC2DDODAa0wpQKdnTDyWruYc3ws3PrJvrGQsP78qtPDTPQnHwkyO11INlHNkxWHxNPPNSsoFD54htyD5rAh7p1OuuO5uo7rZPsCmwMKcZax2kTlJFpCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=KZ6oICy5KqkhfY18QjOol/NtvCNsb3uhrZVW/XHP7vw=;
b=QUp2qaWwJ1m9yBQEvUNeD0TZUKm9Q8PUh0UAGpi9VmVP2JAgAjwWriZxPwj9etTQNNy2wrYihXKvB3kMDxFGHyC7CKuIp9DJpaKqPFj4uxwsyWVWtlteDPulsCm5aLqzVnV49j+2OLW6Hka63JExX46DB6T2ILoApoBlEhnsf280gRw7dlyFKRcPGkYEnwuIwY5Ftb0l3vkBSJXE8D+MzDR7OKw8QxgUNIap689NhBaApCUkd8WajSGyv/B09Alc6HlaSFyni3kXkPQocLhI1Vc/uq/aguzal6cxqAsh0d3NA5JsAbVoL6PtI7N1Q8JfUsOPUMlrqWUe1oC4aOMExA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass
(p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;
dkim=none (message not signed); arc=none (0)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=KZ6oICy5KqkhfY18QjOol/NtvCNsb3uhrZVW/XHP7vw=;
b=Q+iecznTxwNo3R4OPUPf0+oPcn4Xs23U8WCrQPWG4l6EtILKw/LeTBV+5joQmpUQuf4vvsNX+ff6XR43Fs+DsUjCgRk0LSrlp4Apk7TEJXzBYfCdBxSr4FgF7jE1e6f6cNQE6shGi1cYa+IvkDIXlJ+Gt36AEpWkOEu82/L3EGo=
Received: from DM6PR02CA0145.namprd02.prod.outlook.com (2603:10b6:5:332::12)
by PH8PR12MB7304.namprd12.prod.outlook.com (2603:10b6:510:217::20) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.15; Wed, 7 Feb
2024 03:14:18 +0000
Received: from CO1PEPF000044F7.namprd21.prod.outlook.com
(2603:10b6:5:332:cafe::2c) by DM6PR02CA0145.outlook.office365.com
(2603:10b6:5:332::12) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36 via Frontend
Transport; Wed, 7 Feb 2024 03:14:18 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17)
smtp.mailfrom=amd.com; dkim=none (message not signed)
header.d=none;dmarc=pass action=none header.from=amd.com;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
165.204.84.17 as permitted sender) receiver=protection.outlook.com;
client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Received: from SATLEXMB04.amd.com (165.204.84.17) by
CO1PEPF000044F7.mail.protection.outlook.com (10.167.241.197) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.20.7292.0 via Frontend Transport; Wed, 7 Feb 2024 03:14:18 +0000
Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com
(10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 6 Feb
2024 21:14:13 -0600
From: Andrew Boyer <andrew.boyer@amd.com>
To: <dev@dpdk.org>
CC: Andrew Boyer <andrew.boyer@amd.com>
Subject: [PATCH v3 03/13] net/ionic: don't auto-enable Rx scatter-gather a
second time
Date: Tue, 6 Feb 2024 19:13:07 -0800
Message-ID: <20240207031317.32293-4-andrew.boyer@amd.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20240207031317.32293-1-andrew.boyer@amd.com>
References: <20240202193238.62669-1-andrew.boyer@amd.com>
<20240207031317.32293-1-andrew.boyer@amd.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.180.168.240]
X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com
(10.181.40.145)
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CO1PEPF000044F7:EE_|PH8PR12MB7304:EE_
X-MS-Office365-Filtering-Correlation-Id: e5292af0-85c2-4ad7-0ac8-08dc278adf31
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: gKQMxP7O7JOhAMuu/JSUq/Y9ubYkifuhnRvltpUxQAw9IpgjNOVAs+TVgHeS6SYPgRmajsOpFSbkzmVbok0UsckoPUGpPP4g4gJ0YQOc/RTXGpoF7adREP/ThF5JoyGmxU75f448WqqFllbv1rGDdtL02hO8AGZPpSmBiQdXbsPRDlPW2ia7nNcsfu9WN1hgTc2f28rKClF8k4O+8YJexfCUmNyAaREfpS06TWM90GK2pz+JuYgrUAQtQ50opOYZTBg0n4fcq61/uI9QIXaYbjL+PKio+jd/y4FzWzKfoXrcZYFd/dE7fEcEYN1+c1E6QmeceWfyX6gg+folqYnoH9iJV0GhRkn3jMguS3jnbYsdmIlcXpXtsKRQ0lL2KUh3djvwWaKpHHA3+AugMUbFdM+lKoJtYJ70dLK7wQ0s0KEZrZuODMOr0e7iLu2n9CWP3XdLQqyf4d9XI6QITD0sKsuYYvGRH3bSTCbuqL7ipoFEpnOIRnZRNiuBQBleqRCTJmH7jgYBf15F75p5hpM72DmRhsWPSQ9xKpekCWUSKIXV7Ha2mgsmvBgUxq44r/m6SA+yaRaBqck5yi6+ErFrlwtZG9Qkgv5O4ZmIYXVW6D1nN8jNk+c7sZrbo8Nkkf8nPvWWtkZRe6MZEUpIBDNxiX2nyOSNGpoXw33GZQBccfBOXcAaJ6CadFh+NkU1helFqMRXGZnwe/W+bdTq3WwfxJgSSZG1QMrbzFpJJiOaQRf/QtdvtVU/owvd03ui0dc4sa+s1RDL54OGDM14bLwsxA==
X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;
IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;
SFS:(13230031)(4636009)(136003)(376002)(346002)(39860400002)(396003)(230922051799003)(186009)(1800799012)(451199024)(82310400011)(64100799003)(46966006)(36840700001)(40470700004)(41300700001)(16526019)(26005)(47076005)(86362001)(336012)(1076003)(6666004)(478600001)(70206006)(8676002)(44832011)(4326008)(2906002)(70586007)(5660300002)(426003)(2616005)(316002)(6916009)(83380400001)(82740400003)(4744005)(81166007)(356005)(36860700001)(8936002)(36756003)(40460700003)(40480700001)(36900700001);
DIR:OUT; SFP:1101;
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 03:14:18.1552 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e5292af0-85c2-4ad7-0ac8-08dc278adf31
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];
Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F7.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7304
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
The receive side will enable scatter-gather if required based on the
mbuf size. If the client already enabled it in the config, it does
not need to be enabled again. This reduces log output.
Signed-off-by: Andrew Boyer <andrew.boyer@amd.com>
---
drivers/net/ionic/ionic_lif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c
index 25b490deb6..fe2112c057 100644
--- a/drivers/net/ionic/ionic_lif.c
+++ b/drivers/net/ionic/ionic_lif.c
@@ -768,7 +768,8 @@ ionic_rx_qcq_alloc(struct ionic_lif *lif, uint32_t socket_id, uint32_t index,
max_mtu = rte_le_to_cpu_32(lif->adapter->ident.lif.eth.max_mtu);
/* If mbufs are too small to hold received packets, enable SG */
- if (max_mtu > hdr_seg_size) {
+ if (max_mtu > hdr_seg_size &&
+ !(lif->features & IONIC_ETH_HW_RX_SG)) {
IONIC_PRINT(NOTICE, "Enabling RX_OFFLOAD_SCATTER");
lif->eth_dev->data->dev_conf.rxmode.offloads |=
RTE_ETH_RX_OFFLOAD_SCATTER;
--
2.17.1