From: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
To: hujiayu.hu@foxmail.com
Cc: dev@dpdk.org, Kumara Parameshwaran <kumaraparamesh92@gmail.com>
Subject: [PATCH v6] gro : packets not getting flushed in heavy-weight mode API
Date: Sun, 11 Feb 2024 10:25:11 +0530 [thread overview]
Message-ID: <20240211045511.1221879-1-kumaraparamesh92@gmail.com> (raw)
In-Reply-To: <20240117195228.423261-1-kumaraparamesh92@gmail.com>
In heavy-weight mode GRO which is based on timer, the GRO packets
will not be flushed in spite of timer expiry if there is no packet
in the current poll. If timer mode GRO is enabled the
rte_gro_timeout_flush API should be invoked.
Signed-off-by: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
---
v1:
Changes to make sure that the GRO flush API is invoked if there are no packets in
current poll and timer expiry.
v2:
Fix code organisation issue
v3:
Fix warnings
v4:
Fix error and warnings
v5:
Fix compilation issue when GRO is not defined
v6:
Address review comments
app/test-pmd/csumonly.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
index c103e54111..21b45b4ba4 100644
--- a/app/test-pmd/csumonly.c
+++ b/app/test-pmd/csumonly.c
@@ -863,16 +863,22 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
/* receive a burst of packet */
nb_rx = common_fwd_stream_receive(fs, pkts_burst, nb_pkt_per_burst);
+#ifndef RTE_LIB_GRO
if (unlikely(nb_rx == 0))
return false;
-
+#else
+ gro_enable = gro_ports[fs->rx_port].enable;
+ if (unlikely(nb_rx == 0)) {
+ if (!gro_enable || (gro_flush_cycles == GRO_DEFAULT_FLUSH_CYCLES))
+ return false;
+ if ((rte_gro_get_pkt_count(current_fwd_lcore()->gro_ctx) == 0))
+ return false;
+ }
+#endif
rx_bad_ip_csum = 0;
rx_bad_l4_csum = 0;
rx_bad_outer_l4_csum = 0;
rx_bad_outer_ip_csum = 0;
-#ifdef RTE_LIB_GRO
- gro_enable = gro_ports[fs->rx_port].enable;
-#endif
txp = &ports[fs->tx_port];
tx_offloads = txp->dev_conf.txmode.offloads;
--
2.25.1
next prev parent reply other threads:[~2024-02-11 4:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 19:52 [PATCH v1] " Kumara Parameshwaran
2024-01-17 19:57 ` kumaraparameshwaran rathinavel
2024-01-17 20:14 ` [PATCH v2] " Kumara Parameshwaran
2024-01-17 20:20 ` [PATCH v3] " Kumara Parameshwaran
2024-01-17 20:24 ` [PATCH v4] " Kumara Parameshwaran
2024-01-18 8:36 ` [PATCH v5] " Kumara Parameshwaran
2024-02-07 22:57 ` Ferruh Yigit
2024-02-11 4:55 ` Kumara Parameshwaran [this message]
2024-02-12 15:05 ` [PATCH v6] " Ferruh Yigit
2024-02-16 3:40 ` [PATCH v7] app/testpmd : fix " Kumara Parameshwaran
2024-02-16 4:13 ` Stephen Hemminger
2024-02-16 3:47 ` [PATCH v8] " Kumara Parameshwaran
2024-02-16 13:56 ` Ferruh Yigit
2024-02-21 18:02 ` Ferruh Yigit
2024-02-22 11:15 ` kumaraparameshwaran rathinavel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240211045511.1221879-1-kumaraparamesh92@gmail.com \
--to=kumaraparamesh92@gmail.com \
--cc=dev@dpdk.org \
--cc=hujiayu.hu@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).