From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F29543AFA; Mon, 12 Feb 2024 19:03:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5CAB402E4; Mon, 12 Feb 2024 19:03:19 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 4E90B402BF for ; Mon, 12 Feb 2024 19:03:18 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 5A35E20B2000; Mon, 12 Feb 2024 10:03:17 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5A35E20B2000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707760997; bh=kxa3MAMRQAfEtwjKQLKSGTdyM1Dj+jOTXbW5y4w1DB0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R0ZJ28sp54lGSnUKOfDSBt+YS4tSQWocZ/DTUsDbjAL6mMZn38137F+Iiz5Uzuq3/ MTBNV9UYikp9UnWvcmbnuSRcjCAXVSpQkm++9VsaRrMbSXAzg+oIR648Xs4rnLVPZS TS7eML1B4g4A54NieMzv+ZyU5TkA7eR3I779BQk0= Date: Mon, 12 Feb 2024 10:03:17 -0800 From: Tyler Retzlaff To: dev@dpdk.org Cc: Matan Azrad , Ori Kam , Suanming Mou , Viacheslav Ovsiienko Subject: Re: [PATCH] net/mlx5: remove non constant size from type cast Message-ID: <20240212180317.GB1977@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1699896038-28106-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1699896038-28106-1-git-send-email-roretzla@linux.microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org ping this one seems pretty obvious, maintainers could you please take a look? thanks On Mon, Nov 13, 2023 at 09:20:38AM -0800, Tyler Retzlaff wrote: > Placing a non-constant size in the subscript [size] of a type cast is > causing unnecessary generation of a VLA. Remove size and just provide [] > indicating the type is an array of unspecified size. > > Signed-off-by: Tyler Retzlaff > --- > drivers/net/mlx5/mlx5_rxq.c | 5 ++--- > drivers/net/mlx5/mlx5_txq.c | 2 +- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index 88b2dc5..f0ab77d 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -1951,9 +1951,8 @@ struct mlx5_rxq_ctrl * > tmpl->rxq.mp = rx_seg[0].mp; > tmpl->rxq.elts_n = log2above(desc); > tmpl->rxq.rq_repl_thresh = MLX5_VPMD_RXQ_RPLNSH_THRESH(desc_n); > - tmpl->rxq.elts = (struct rte_mbuf *(*)[desc_n])(tmpl + 1); > - tmpl->rxq.mprq_bufs = > - (struct mlx5_mprq_buf *(*)[desc])(*tmpl->rxq.elts + desc_n); > + tmpl->rxq.elts = (struct rte_mbuf *(*)[])(tmpl + 1); > + tmpl->rxq.mprq_bufs = (struct mlx5_mprq_buf *(*)[])(*tmpl->rxq.elts + desc_n); > tmpl->rxq.idx = idx; > if (conf->share_group > 0) { > tmpl->rxq.shared = 1; > diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c > index b584055..3d219c4 100644 > --- a/drivers/net/mlx5/mlx5_txq.c > +++ b/drivers/net/mlx5/mlx5_txq.c > @@ -64,7 +64,7 @@ > const uint16_t elts_m = elts_n - 1; > uint16_t elts_head = txq_ctrl->txq.elts_head; > uint16_t elts_tail = txq_ctrl->txq.elts_tail; > - struct rte_mbuf *(*elts)[elts_n] = &txq_ctrl->txq.elts; > + struct rte_mbuf *(*elts)[] = &txq_ctrl->txq.elts; > > DRV_LOG(DEBUG, "port %u Tx queue %u freeing WRs", > PORT_ID(txq_ctrl->priv), txq_ctrl->txq.idx); > -- > 1.8.3.1