From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4B05543B10;
	Tue, 13 Feb 2024 20:20:45 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3913642E2D;
	Tue, 13 Feb 2024 20:20:45 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 2332942E2D
 for <dev@dpdk.org>; Tue, 13 Feb 2024 20:20:43 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 741B320B2000; Tue, 13 Feb 2024 11:20:42 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 741B320B2000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1707852042;
 bh=3h1d8f4YmIp4F1zRRaCVKR0XBtD+pr7L/2IyxZ2tLII=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=dY2LDQNcHgG2luIBPs9X1+PLiyWKTZifeD1/C+tTqkXkyq7YFxr2oH+LWZV5unoib
 cSdhQuAOBO0O696zeFVCmiOGA4vCoqTfJp3w30sIrvTrC08mjZco/Lca/4orAPfGyM
 HMA4Xiynw9/UifeB3czLvW2pbs3y2IM+IMkpA4aQ=
Date: Tue, 13 Feb 2024 11:20:42 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
 Sameh Gobriel <sameh.gobriel@intel.com>,
 Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
 Yipeng Wang <yipeng1.wang@intel.com>, mb@smartsharesystems.com,
 fengchengwen@huawei.com, Dodji Seketeli <dodji@redhat.com>
Subject: Re: [PATCH v2 0/4] more replacement of zero length array
Message-ID: <20240213192042.GA24086@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1706134657-17446-1-git-send-email-roretzla@linux.microsoft.com>
 <1707777366-26000-1-git-send-email-roretzla@linux.microsoft.com>
 <CAJFAV8wNDj7f0Qzwp3UYsYUxQH2KObBFRzNTzTOeU=A_i3FVzA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJFAV8wNDj7f0Qzwp3UYsYUxQH2KObBFRzNTzTOeU=A_i3FVzA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Feb 13, 2024 at 02:14:28PM +0100, David Marchand wrote:
> On Mon, Feb 12, 2024 at 11:36 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > Replace some missed zero length arrays not captured in the
> > original series.
> > https://patchwork.dpdk.org/project/dpdk/list/?series=30410&state=*
> >
> > Zero length arrays are a GNU extension that has been
> > superseded by flex arrays.
> >
> > https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> >
> > v2:
> >     * added additional patches for fib & pipeline libs.
> >       series-acks have been placed only against original
> >       hash and rcu patches.
> 
> There seems to be an issue with the ABI check on those changes.
> After a quick chat with Dodji, I opened a bug for libabigail.
> 
> https://sourceware.org/bugzilla/show_bug.cgi?id=31377

I double checked again and I don't see the struct in question being
embedded as a field of another struct/union.  So I don't think there should
be an ABI change here.

I'm okay with the change being merged but if there is concern I can drop
this patch from the series.

> 
> 
> -- 
> David Marchand