From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EDB343B19; Thu, 15 Feb 2024 19:25:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B16D402AD; Thu, 15 Feb 2024 19:25:30 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 7017940276 for ; Thu, 15 Feb 2024 19:25:29 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d780a392fdso10491235ad.3 for ; Thu, 15 Feb 2024 10:25:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1708021528; x=1708626328; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Bp12EIsGDJlxfR9S8MIg0+81PaG13ChKgkzRrlY0HYI=; b=VLFbQmy5/lsn+zVWdKS7UbngIVp6lagzzZ/nnahuc4SVwSnhBq1BuLOtboLtn6fOCv sv4jYZlMWIYGQlOw/IIHTwQgeRev/kN05gaQt59OgKHt3VE74DHBvUvVeD1kv4Jq2Vey PuHhKWyiRQvkLPhSpH//WJZjaZPbldRJMHldU0yQ3qQPI9/bBiSB+LelHQay8YV7kvQk MnXO5cpXQzz0uXVKCfKBXKth+nb67I1sBO9HryGfIABCCGs4UzpL3dDjPZge0iU7t9Ou xNsXugJFDjwHM8+U3zZrrR1763I1kiKtGSdE3XjwJrhhpDpr/efyt3mdM9BAWw1B2VM1 bjvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708021528; x=1708626328; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bp12EIsGDJlxfR9S8MIg0+81PaG13ChKgkzRrlY0HYI=; b=Qf+AlfjDrof5h1fxsoqJ/qjeSFuEzERhMt1IO05jN0xFbpK+K2kXlBzp3tNIP89Bkh 5AVxmaeFaujb5i5SnC/PqB7xeEyhOray9dXobqLzN6zbpNuobIL7pD9M9Ephav1wQHyz /XWCwgpKff95gb7seHXWvircX2sbJJaCjIn0ZTNRylvMcITZFe7an0rc4wdZ8YvEmdut QgkqVjuFLIcOjlHHdJ7tMZg1vckKH4wpM5RNTO43PHZ27kfd2EMiopiCEINv/WPAxciB ETJB7G+qeInqBJtyDPADTXhZFEgyc2zXtyZnzECFGwLvISGIniv2IlhkRWTrx6lUJuhB Qpwg== X-Forwarded-Encrypted: i=1; AJvYcCXXIT+xjnAMlgWre+52wXxMhDYdd5zlamPT3OCgRufscx+XI9A+9r0Old6oKcWdoxCGUhf4oZb+RKuXEeM= X-Gm-Message-State: AOJu0YzOnOGh47qUUWfLP4SuPJqGJDtRMuSyXbWAT0h1Y4ub2wnM+Hep Y6lrbCNXd/gQAk7y3oa3qMGADQdc6YNO8C/LZGhWS+tOAcQEKFVpvgAdQOdHfgs= X-Google-Smtp-Source: AGHT+IF8eEhvqUbpDZgLa0aTPQkPk/L9G6t8UiIPwsABSzx1SThGnBlBm4NdzbTQ7GNV8ffDYjAA0Q== X-Received: by 2002:a17:90a:db17:b0:298:c368:d2b8 with SMTP id g23-20020a17090adb1700b00298c368d2b8mr2330143pjv.24.1708021528361; Thu, 15 Feb 2024 10:25:28 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mg17-20020a17090b371100b00299101c1341sm1570257pjb.18.2024.02.15.10.25.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 10:25:28 -0800 (PST) Date: Thu, 15 Feb 2024 10:25:26 -0800 From: Stephen Hemminger To: Alan Elder Cc: Ferruh Yigit , Long Li , Andrew Rybchenko , "dev@dpdk.org" Subject: Re: [PATCH v5] net/netvsc: fix parsing of VLAN metadata Message-ID: <20240215102526.2740b40b@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 15 Feb 2024 18:12:35 +0000 Alan Elder wrote: > +/* VLAN header fields */ > +#define RTE_VLAN_DEI_SHIFT 12 > +#define RTE_VLAN_PRI_SHIFT 13 > +#define RTE_VLAN_PRI_MASK 0xe000 /* Priority Code Point */ > +#define RTE_VLAN_DEI_MASK 0x1000 /* Drop Eligible Indicator */ > +#define RTE_VLAN_ID_MASK 0x0fff /* VLAN Identifier */ > + > +#define RTE_VLAN_TCI_ID(vlan_tci) ((vlan_tci) & RTE_VLAN_ID_MASK) > +#define RTE_VLAN_TCI_PRI(vlan_tci) (((vlan_tci) & RTE_VLAN_PRI_MASK) >> \ > + RTE_VLAN_PRI_SHIFT) > +#define RTE_VLAN_TCI_DEI(vlan_tci) (((vlan_tci) & RTE_VLAN_DEI_MASK) >> \ > + RTE_VLAN_DEI_SHIFT) > +#define RTE_VLAN_TCI_MAKE(id, pri, dei) ((id) | \ > + ((pri) << RTE_VLAN_PRI_SHIFT) | \ > + ((dei) << RTE_VLAN_DEI_SHIFT)) > + With current DPDK standard max line length 100, the lines may not need to be broken any more.