From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55C9A43AF7; Sat, 17 Feb 2024 19:11:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E713C400D7; Sat, 17 Feb 2024 19:11:27 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id EAB3F40042 for ; Sat, 17 Feb 2024 19:11:25 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1d94b222a3aso30034595ad.2 for ; Sat, 17 Feb 2024 10:11:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1708193485; x=1708798285; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ao4OwaWO7++IV92jo2iJaYXJreashoBTXEb9gpx70PE=; b=Np4DsqIviuHcKMfZ4wySc3HL2S/MBrEA0GUqpye1COKGb8If4Z2ccC0Cva3pBZa5v6 HnmALZzzxOOph99pRuV4ST3zUIUK/cTRiP3dLo6JCyiviPeTtTF+shEDExdU7+yhc73W 6NFMtmW7tVkWrTrtxiuuBxsFav4b63cIw9XIKBUDQz7MQHq2klANeBpv5PEb3BQxmHb7 aTfWF0Me/0z+MulhC2ub3bt1UZg3wVeJ1hIlJTEZ0de5dTnn6dSdxaPDhadrTkWSCPls rGU38hUIcA/j4jF0ch3Lj/irNjqWa//NhXG3IWhcY3t81cmsaR/l/OAqKPlK49Z2o20E b0zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708193485; x=1708798285; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ao4OwaWO7++IV92jo2iJaYXJreashoBTXEb9gpx70PE=; b=EyHEdsQVVyUfBhfAGKzv54sQIh16zZiN+hKjn5RukgdM+ZPSruwECgnVF/EaQqDU8r H67T9cp5kES9iDmktLewPH3AXLLQSDEOP/7kWXTzK4+4oOY5GuCDsQIJ/btiSumABc6l b1h/haRVXm5s2ED9lnHRa8zm3xOyrySJXmRldiTW43RCWdzCqNiO53l7KPhQogmJvwj/ s7m99AmPsGWdVnGWX/y0lJJ8JR/6o4LqMFliPKLQzy/57bwIoM6B2WoyYAgprzXJXG3C gZiD/h11+qSDs61mEf/uOYdPCMv/gRzsQ1XfxwhQ+D1t31m2kp+/v3ypFmcZfpRParLa KjWA== X-Forwarded-Encrypted: i=1; AJvYcCVd5DpUlHWaCDXH08G2mi0cgx0tUxWlgN3rUVq/2sx5oiv8WW7a5cMtBt+jNboyWN4cDLZN+z3uc/9Rt1A= X-Gm-Message-State: AOJu0YzN36gYf2YyB+Xx/tCl1AMokSGWpqyefZf5sX2VsKrHwUDPA//k HP0EZ9hpw1H9H8Xra2tvbNYNOUSC6AxeZpVvh7u8E97UpuO+erLztIYhlehHMjY= X-Google-Smtp-Source: AGHT+IH+/2Fc8kkD2+//U8lHH1+A8P/BRVaFJkDsXBWLtEeG8A4paUyRm4iPlYOOnttWEOliWOxCNw== X-Received: by 2002:a17:902:ba94:b0:1d9:c367:205d with SMTP id k20-20020a170902ba9400b001d9c367205dmr7519375pls.53.1708193484919; Sat, 17 Feb 2024 10:11:24 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id jw19-20020a170903279300b001d9b537ad0bsm1691242plb.275.2024.02.17.10.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Feb 2024 10:11:24 -0800 (PST) Date: Sat, 17 Feb 2024 10:11:22 -0800 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: "Chaoyong He" , , , "Long Wu" , "Peng Zhang" Subject: Re: [PATCH] net/nfp: add support of UDP fragmentation offload Message-ID: <20240217101122.37734606@hermes.local> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F228@smartserver.smartshare.dk> References: <20240217015410.2163102-1-chaoyong.he@corigine.com> <20240217084725.5a1c6f34@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9F228@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 17 Feb 2024 19:02:30 +0100 Morten Br=C3=B8rup wrote: > Not formally... it follows the official DPDK Coding Style [1]. >=20 > [1]: https://doc.dpdk.org/guides/contributing/coding_style.html#general >=20 > > Should be: > >=20 > > if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) =3D=3D 0 && > > (ol_flags & RTE_MBUF_F_TX_UDP_SEG) =3D=3D 0) > > goto clean_txd; =20 >=20 > This indentation style is mentioned as an alternative in the guide. But t= he example in the guide also uses two tabs for a similar long comparison. >=20 > Personally, I also prefer the style suggested by Stephen, so we might wan= t to update the Coding Style. ;-) The two tabs is an Intel thing, and I prefer the kernel, line up the condit= ional style. We really should have a style that can be describe by clang format. Other projects like VPP have a target that reformats the code and uses one = of the clang format templates.