From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EAF243B4C; Mon, 19 Feb 2024 18:26:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D19AB40275; Mon, 19 Feb 2024 18:26:47 +0100 (CET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id B663340263 for ; Mon, 19 Feb 2024 18:26:46 +0100 (CET) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-6d9f94b9186so3735141b3a.0 for ; Mon, 19 Feb 2024 09:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1708363606; x=1708968406; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Pq3YAiXqKA7ktSKdU/PaNNJwdeoZmcReRFdwDugIdSo=; b=JL/vyC1srys//24PBURF76wlZoz5buxoohuqp869itYBvVenuOToAvtD0hod+in+lU NC/xOCwe8JchOJ6K68zYsuS2KJzcs2shYDqYcl4Q+9NPAfsM0OWoEiaUXJ6ZihZvRzd7 ZwBDVKeLTnfzeSt8Ku+VLj+uv/FlxnTosmZ84BqpWqR5aVwiMHXPsKHAozudYuG0M0EL XNTzaTxbU6pG5mcdLIZQEBoP7s3cY41xVF57YF7k6vYVisQ4UF8XPPOC0ZNQWbkLvZeP ZobcIJwAogITWwnDoX9bA7PIIqJ8nGra/ItHWJDq7F5+rAJTx3bKuKJmePuFTZifJSi3 dcKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708363606; x=1708968406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pq3YAiXqKA7ktSKdU/PaNNJwdeoZmcReRFdwDugIdSo=; b=pCNc1RVcM4KJ9lvQHum/zNSBV0XsMvV4LbQMKIuIa+jHoZnaYLGPyzU+T6vmofrpxo b1RX/Po4nB1jwUl4A5xEeiUz/ACtxMvJDH6RMoKj6LffOX7jrydD/udQeVGabJhwfPRx Z/LXieLZY1Gmp6vOGvB+xQ2m5pWbOsePSP7qoq2dJ66YkQLZbg+vFvQHtDGJ93G975uy AISpVLzdWUuu4AJ2a0o17w5c5dNitLsNvhtynlKR4VCSDuPfOPBYQR6qUjxKS5BNTYBq TLarffmCALUXftF9jB4yU9yn4nYL52GT0sIZ5Ip8aFFcJQ/v5KD9XswD00Qfiv+aCzLA 3nKg== X-Forwarded-Encrypted: i=1; AJvYcCX3huQZT0L1iM9P/FT4khvmIXZ0t9IPbx9RnuRZGW5sHy8GItokmjLydhf/P0g8NnfuJu9Wm9dK4DjOFoM= X-Gm-Message-State: AOJu0YwxatgdItfjnbVjpbIEPj4sUvRxNBkXfhYDzCIgNSPPLS0GkcQM Hn4KrXFfxgeI7nvwUTIcyeMW7FJN17XWqb0nsy17oUDVCUeZASUyu1c0Ld9TlzQ= X-Google-Smtp-Source: AGHT+IHKEoUIuaCaiW27nDcnJwufxuLmoZX9PgCeqB9oQKPedhoANLCXsJBEA/KrsV+LCa0zvsKmJw== X-Received: by 2002:a05:6a21:3989:b0:19c:ae59:1602 with SMTP id ad9-20020a056a21398900b0019cae591602mr16900454pzc.53.1708363605775; Mon, 19 Feb 2024 09:26:45 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id a1-20020aa78e81000000b006e414faff99sm3263812pfr.180.2024.02.19.09.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 09:26:45 -0800 (PST) Date: Mon, 19 Feb 2024 09:26:43 -0800 From: Stephen Hemminger To: Rushil Gupta Cc: junfeng.guo@intel.com, jeroendb@google.com, joshwash@google.com, ferruh.yigit@amd.com, dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH] net/gve: Change ERR to DEBUG to prevent flooding of logs for Tx-Dqo. Message-ID: <20240219092643.4f0a0cac@hermes.local> In-Reply-To: <20240219024436.1010010-1-rushilg@google.com> References: <20240219024436.1010010-1-rushilg@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 19 Feb 2024 02:44:35 +0000 Rushil Gupta wrote: > This was causing failure for testpmd runs (for queues >=15) > presumably due to flooding of logs due to descriptor ring being > overwritten. > > Fixes: a01854 ("net/gve: fix dqo bug for chained descriptors") > Cc: stable@dpdk.org > > Signed-off-by: Rushil Gupta > Reviewed-by: Joshua Washington Isn't this still an error. What about the descriptor overwritten is there an mbuf leak? Maybe a statistic would be better than a message?