From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94F3343BF8; Mon, 26 Feb 2024 21:54:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7EF5042E21; Mon, 26 Feb 2024 21:54:41 +0100 (CET) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id 0AFBF40293 for ; Mon, 26 Feb 2024 21:54:40 +0100 (CET) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6e4d869b019so1653113b3a.0 for ; Mon, 26 Feb 2024 12:54:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1708980879; x=1709585679; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jniDC0JheCn1pCi/13aTvU3rxnSuWIjQmKVwJkLN8ho=; b=ry0EbwbmEmYCeOK64234kbDjbTaLp2HIm49YkqM/Pn90dDxv+5CJ6dLmx2HgoKuAZu FE3V8ygBA6CuP7VjSutVxKYiKkyYWhtAPxR0Pu+G/ISHEaEw2U8tVARPiWtE5kzmJygK ADIdcGTSUSn52KyUO3kxekLhUFqo/xnuwwjne0zDObdyUxoC8VsBJ7hgNKVbD14aovFB 19JbbtQV+LTMNsoxw/QeAp6/BDws5hmepFqpbzyANVBwP6SVQ8EyiX/5gBKMDfRVKw9C REd9FSPJNi83FhmzKEZefaGAB4S4FyFzYihpodJ9E8bcSkWjXA350M07AWhOrDmZWg8G yE7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708980879; x=1709585679; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jniDC0JheCn1pCi/13aTvU3rxnSuWIjQmKVwJkLN8ho=; b=AfUhaB1Gf0GsBlAzt11xtw+aJoXY+hIK4KY+vBvW78MwJzLFFENDR3tFH9//FG5dKI xXKhei2jm6BfpbpIyN1p3S+69ZtorQHlQLJpo2p8TubhwyTsTQrwnpyy44LaQuQEMfPc NocFnfr+8JFfuoXvcRiAoC6GmmOp9lSZSdBu2kfZsjpbqw+ughPdQKqI3ZKjrsdyuSAP 9nvW42Y/X/UUhzFc2iORQyjjSu9WDR5xkfsZPb0vJjCuAIDB70eHogcSlyOB9IgfKOqL lEUca4cMRnQPwPPDglw1QIangLyLn6nHC7of4bpycrIjNtBQm101qpHVHMPMPgDSi28J N3rA== X-Gm-Message-State: AOJu0Yzf1ELN1Z9gwqi/tC+xYKcj3FEY+PDd8MXD8AAylh5La0dryCuC AqKpIH7isalA8/7mSrgI76gwatsfzGxrXETQyWDcwaXBLjN8teEY0kg0EFsOQSo= X-Google-Smtp-Source: AGHT+IGgDUBdjcWae1qqRfJsLSeljI7IV01Hc2j+sPLilxJu+RyxM1hYEWxHt/Ou7I7NZ9yh5kuHjw== X-Received: by 2002:a05:6a00:9287:b0:6e5:2e25:3495 with SMTP id jw7-20020a056a00928700b006e52e253495mr4410342pfb.32.1708980879126; Mon, 26 Feb 2024 12:54:39 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id t2-20020a62d142000000b006de050cf904sm4684438pfl.22.2024.02.26.12.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 12:54:38 -0800 (PST) Date: Mon, 26 Feb 2024 12:54:36 -0800 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, Anatoly Burakov , Ashish Gupta , Chenbo Xia , Cristian Dumitrescu , David Hunt , Fan Zhang , Hemant Agrawal , Honnappa Nagarahalli , Jasvinder Singh , Jerin Jacob , Konstantin Ananyev , Maxime Coquelin , Reshma Pattan , Sachin Saxena , Sivaprasad Tummala , Srikanth Yalavarthi , Sunil Kumar Kori , bruce.richardson@intel.com, mb@smartsharesystems.com, thomas@monjalon.net Subject: Re: [PATCH v3 00/16] stop using variadic argument pack extension Message-ID: <20240226125436.046684e7@hermes.local> In-Reply-To: <1708978786-6740-1-git-send-email-roretzla@linux.microsoft.com> References: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com> <1708978786-6740-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 26 Feb 2024 12:19:30 -0800 Tyler Retzlaff wrote: > RTE_LOG_LINE cannot be augmented with a prefix format and arguments > without the user of RTE_LOG_LINE using the args... and ## args compiler > extension to conditionally remove trailing comma when the macro receives > only a single argument. > > Provide a new/similar macro RTE_LOG_LINE_PREFIX that accepts the prefix > format and arguments as separate parameters allowing them to be expanded > at the correct locations inside of RTE_FMT() allowing the rest of the > non-prefix format string and arguments to be collapsed to the argument > pack which can be directly forwarded with __VA_ARGS__ avoiding the need > for conditional comma removal. > > I've done my best to manually check expansions (preprocessed) and compiled > printf of the logs to validate correct output. > > note: due to drastic change in series i have not carried any series acks > forward. The changes look good, you might want to add release note, update coding style doc, and/or update checkpatch to discourage re-introduction. Series-acked-by: Stephen Hemminger