From: Stephen Hemminger <stephen@networkplumber.org>
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH 2/2] app/pdump: handle SIGTERM and SIGHUP
Date: Tue, 27 Feb 2024 10:09:49 -0800 [thread overview]
Message-ID: <20240227100949.73742a13@hermes.local> (raw)
In-Reply-To: <PH0PR11MB5877C7AE36E24803E6FBA856FF592@PH0PR11MB5877.namprd11.prod.outlook.com>
On Tue, 27 Feb 2024 09:59:37 +0000
"Pattan, Reshma" <reshma.pattan@intel.com> wrote:
> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > + sigaction(SIGHUP, NULL, &origaction);
>
> Why do we need this ? Can't be this direct sigaction(SIGHUP, &action, NULL) without a below if code?
> Can you please explain how this works.
>
> > + if (origaction.sa_handler == SIG_DFL)
> > + sigaction(SIGHUP, &action, NULL);
> >
>
If sighup is being ignored already (for example being run by nohup)
then the program should keep ignoring SIGHUP.
This is the method used in tshark and dumpcap utilities in wireshark
and it made sense.
next prev parent reply other threads:[~2024-02-27 18:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 20:49 [PATCH 0/2] dumpcap,pdump handle cleanup signals Stephen Hemminger
2024-02-26 20:49 ` [PATCH 1/2] app/dumpcap: handle SIGTERM and SIGHUP Stephen Hemminger
2024-02-26 20:49 ` [PATCH 2/2] app/pdump: " Stephen Hemminger
2024-02-27 9:59 ` Pattan, Reshma
2024-02-27 18:09 ` Stephen Hemminger [this message]
2024-05-29 16:08 ` [PATCH v2 0/2] Fix pdump and dumpcap leaks on SIGTERM Stephen Hemminger
2024-05-29 16:08 ` [PATCH v2 1/2] app/dumpcap: handle SIGTERM and SIGHUP Stephen Hemminger
2024-05-29 16:08 ` [PATCH v2 2/2] app/pdump: " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227100949.73742a13@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).