From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5632943C0E;
Tue, 27 Feb 2024 17:01:27 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 31F8E40ED2;
Tue, 27 Feb 2024 17:01:22 +0100 (CET)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
[67.231.156.173])
by mails.dpdk.org (Postfix) with ESMTP id 3CE2140E09
for <dev@dpdk.org>; Tue, 27 Feb 2024 17:01:20 +0100 (CET)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id
41RFgnUq005646; Tue, 27 Feb 2024 08:01:19 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=
pfpt0220; bh=JVWgL8psaPxL5HGtThqn1i9VQilfFbZGx2Kjs5aCMXw=; b=GyY
chwGVEXcTL3a4cL+dehzT+fN1dSsgHAskoIPTzFceoISqns9TqvXE8x6d8qQDF97
1vrXYIfnJnI6dzENWJn83mZYdsrQBGiO2Pyy0y6mez8TZAzI+ot0j4RyEAGiE4ya
Z5qkjgmPMTy4zNkqurc4RfjZrfRTRO8EfZCC8D3KtRK7gZPPeZ9l2ywAewiOFfZH
ZrqnCnX1Kcy0hWf84wEAQI7Br2Lv+8mFNWE0bGtg0/ibDACntI1guUISQKm7ILmG
LO8rdSukEkz2K5RPONotLopJdRDHG1m/PrMLoV1FwvKAwdWa+t9kzrQafJkYfKPg
Ls1BqIOYAY3IyOy9DjQ==
Received: from dc5-exch05.marvell.com ([199.233.59.128])
by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3whjm682vc-2
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
Tue, 27 Feb 2024 08:01:18 -0800 (PST)
Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH05.marvell.com
(10.69.176.209) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Tue, 27 Feb
2024 08:00:59 -0800
Received: from DC5-EXCH05.marvell.com (10.69.176.209) by
DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id
15.0.1497.48; Tue, 27 Feb 2024 08:00:58 -0800
Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com
(10.69.176.209) with Microsoft SMTP Server id 15.2.1258.12 via Frontend
Transport; Tue, 27 Feb 2024 08:00:58 -0800
Received: from cavium-OptiPlex-5090-BM14.. (unknown [10.28.36.157])
by maili.marvell.com (Postfix) with ESMTP id 327B43F71E1;
Tue, 27 Feb 2024 08:00:54 -0800 (PST)
From: Amit Prakash Shukla <amitprakashs@marvell.com>
To: Cheng Jiang <honest.jiang@foxmail.com>, Chengwen Feng
<fengchengwen@huawei.com>
CC: <dev@dpdk.org>, <jerinj@marvell.com>, <anoobj@marvell.com>, Kevin Laatz
<kevin.laatz@intel.com>, Bruce Richardson <bruce.richardson@intel.com>,
"Pavan Nikhilesh" <pbhagavatula@marvell.com>, Gowrishankar Muthukrishnan
<gmuthukrishn@marvell.com>
Subject: [PATCH v9 3/4] app/dma-perf: validate copied memory
Date: Tue, 27 Feb 2024 21:30:30 +0530
Message-ID: <20240227160031.3931694-4-amitprakashs@marvell.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20240227160031.3931694-1-amitprakashs@marvell.com>
References: <cover.1700650397.git.gmuthukrishn@marvell.com>
<20240227160031.3931694-1-amitprakashs@marvell.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Proofpoint-ORIG-GUID: dTGwiB6xHyk2cjd5skLQRK4MErPEtDMX
X-Proofpoint-GUID: dTGwiB6xHyk2cjd5skLQRK4MErPEtDMX
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
definitions=2024-02-27_01,2024-02-27_01,2023-05-22_02
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Validate copied memory to ensure DMA copy did not fail.
Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
---
app/test-dma-perf/benchmark.c | 21 ++++++++++++++++++++-
app/test-dma-perf/main.c | 16 +++++++++++-----
app/test-dma-perf/main.h | 2 +-
3 files changed, 32 insertions(+), 7 deletions(-)
diff --git a/app/test-dma-perf/benchmark.c b/app/test-dma-perf/benchmark.c
index 4370d71134..0047e2f4b8 100644
--- a/app/test-dma-perf/benchmark.c
+++ b/app/test-dma-perf/benchmark.c
@@ -12,6 +12,7 @@
#include <rte_dmadev.h>
#include <rte_malloc.h>
#include <rte_lcore.h>
+#include <rte_random.h>
#include "main.h"
@@ -407,6 +408,11 @@ setup_memory_env(struct test_configure *cfg, struct rte_mbuf ***srcs,
return -1;
}
+ for (i = 0; i < nr_buf; i++) {
+ memset(rte_pktmbuf_mtod((*srcs)[i], void *), rte_rand(), buf_size);
+ memset(rte_pktmbuf_mtod((*dsts)[i], void *), 0, buf_size);
+ }
+
if (cfg->transfer_dir == RTE_DMA_DIR_DEV_TO_MEM ||
cfg->transfer_dir == RTE_DMA_DIR_MEM_TO_DEV) {
ext_buf_info = rte_malloc(NULL, sizeof(struct rte_mbuf_ext_shared_info), 0);
@@ -443,7 +449,7 @@ setup_memory_env(struct test_configure *cfg, struct rte_mbuf ***srcs,
return 0;
}
-void
+int
mem_copy_benchmark(struct test_configure *cfg, bool is_dma)
{
uint32_t i;
@@ -461,6 +467,7 @@ mem_copy_benchmark(struct test_configure *cfg, bool is_dma)
uint32_t avg_cycles_total;
float mops, mops_total;
float bandwidth, bandwidth_total;
+ int ret = 0;
if (setup_memory_env(cfg, &srcs, &dsts) < 0)
goto out;
@@ -534,6 +541,16 @@ mem_copy_benchmark(struct test_configure *cfg, bool is_dma)
rte_eal_mp_wait_lcore();
+ for (i = 0; i < (nr_buf / nb_workers) * nb_workers; i++) {
+ if (memcmp(rte_pktmbuf_mtod(srcs[i], void *),
+ rte_pktmbuf_mtod(dsts[i], void *),
+ cfg->buf_size.cur) != 0) {
+ printf("Copy validation fails for buffer number %d\n", i);
+ ret = -1;
+ goto out;
+ }
+ }
+
mops_total = 0;
bandwidth_total = 0;
avg_cycles_total = 0;
@@ -599,4 +616,6 @@ mem_copy_benchmark(struct test_configure *cfg, bool is_dma)
rte_dma_stop(ldm->dma_ids[i]);
}
}
+
+ return ret;
}
diff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c
index 051f76a6f9..df05bcd7df 100644
--- a/app/test-dma-perf/main.c
+++ b/app/test-dma-perf/main.c
@@ -101,20 +101,24 @@ open_output_csv(const char *rst_path_ptr)
return 0;
}
-static void
+static int
run_test_case(struct test_configure *case_cfg)
{
+ int ret = 0;
+
switch (case_cfg->test_type) {
case TEST_TYPE_DMA_MEM_COPY:
- mem_copy_benchmark(case_cfg, true);
+ ret = mem_copy_benchmark(case_cfg, true);
break;
case TEST_TYPE_CPU_MEM_COPY:
- mem_copy_benchmark(case_cfg, false);
+ ret = mem_copy_benchmark(case_cfg, false);
break;
default:
printf("Unknown test type. %s\n", case_cfg->test_type_str);
break;
}
+
+ return ret;
}
static void
@@ -159,8 +163,10 @@ run_test(uint32_t case_id, struct test_configure *case_cfg)
case_cfg->scenario_id++;
printf("\nRunning scenario %d\n", case_cfg->scenario_id);
- run_test_case(case_cfg);
- output_csv(false);
+ if (run_test_case(case_cfg) < 0)
+ printf("\nTest fails! skipping this scenario.\n");
+ else
+ output_csv(false);
if (var_entry->op == OP_ADD)
var_entry->cur += var_entry->incr;
diff --git a/app/test-dma-perf/main.h b/app/test-dma-perf/main.h
index 745c24b7fe..1123e7524a 100644
--- a/app/test-dma-perf/main.h
+++ b/app/test-dma-perf/main.h
@@ -66,6 +66,6 @@ struct test_configure {
struct test_vchan_dev_config vchan_dev;
};
-void mem_copy_benchmark(struct test_configure *cfg, bool is_dma);
+int mem_copy_benchmark(struct test_configure *cfg, bool is_dma);
#endif /* MAIN_H */
--
2.34.1