[PATCH] crypto/ipsec_mb: update Arm IPsec-MB library tag

[PATCH] crypto/ipsec_mb: update Arm IPsec-MB library tag

[Wathsala Vithanage]

Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2023.10.13
in snow3g and zuc documentation. Tag SECLIB-IPSEC-2023.10.13 updates
IPSec-MB library version to 1.4.

Signed-off-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Jack Bond-Preston <Jack.Bond-Preston@arm.com>
---
 doc/guides/cryptodevs/snow3g.rst | 2 +-
 doc/guides/cryptodevs/zuc.rst    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/guides/cryptodevs/snow3g.rst b/doc/guides/cryptodevs/snow3g.rst
index 3392932653..e255b1c2c7 100644
--- a/doc/guides/cryptodevs/snow3g.rst
+++ b/doc/guides/cryptodevs/snow3g.rst
@@ -54,7 +54,7 @@ can be downloaded from `<https://github.com/01org/intel-ipsec-mb/archive/v1.5.zi
 
 For Arm system, ARM64 port of the multi-buffer library can be downloaded from
 `<https://gitlab.arm.com/arm-reference-solutions/ipsec-mb/-/tree/main/>`_. The
-latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2023.06.20.
+latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2023.10.13.
 
 After downloading the library, the user needs to unpack and compile it
 on their system before building DPDK:
diff --git a/doc/guides/cryptodevs/zuc.rst b/doc/guides/cryptodevs/zuc.rst
index a414b5ad2c..24454b23a5 100644
--- a/doc/guides/cryptodevs/zuc.rst
+++ b/doc/guides/cryptodevs/zuc.rst
@@ -53,7 +53,7 @@ can be downloaded from `<https://github.com/01org/intel-ipsec-mb/archive/v1.5.zi
 
 For Arm system, ARM64 port of the multi-buffer library can be downloaded from
 `<https://gitlab.arm.com/arm-reference-solutions/ipsec-mb/-/tree/main/>`_. The
-latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2023.06.20.
+latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2023.10.13.
 
 After downloading the library, the user needs to unpack and compile it
 on their system before building DPDK:
-- 
2.25.1

RE: [EXTERNAL] [PATCH] crypto/ipsec_mb: update Arm IPsec-MB library tag

[Akhil Goyal]

> Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2023.10.13
> in snow3g and zuc documentation. Tag SECLIB-IPSEC-2023.10.13 updates
> IPSec-MB library version to 1.4.
> 
> Signed-off-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Jack Bond-Preston <Jack.Bond-Preston@arm.com>
> ---
I believe this patch would need a rework due to the issue found in 
https://patches.dpdk.org/project/dpdk/patch/20240228113301.934291-1-brian.dooley@intel.com/

RE: [EXTERNAL] [PATCH] crypto/ipsec_mb: update Arm IPsec-MB library tag

[Akhil Goyal]

> Subject: RE: [EXTERNAL] [PATCH] crypto/ipsec_mb: update Arm IPsec-MB library
> tag
> 
> > Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2023.10.13
> > in snow3g and zuc documentation. Tag SECLIB-IPSEC-2023.10.13 updates
> > IPSec-MB library version to 1.4.
> >
> > Signed-off-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Reviewed-by: Jack Bond-Preston <Jack.Bond-Preston@arm.com>
> > ---
> I believe this patch would need a rework due to the issue found in
> https://patches.dpdk.org/project/dpdk/patch/20240228113301.934291-1-
> brian.dooley@intel.com/
Hi Wathsala,
Any update on the updated tag and this patch?

RE: [EXTERNAL] [PATCH] crypto/ipsec_mb: update Arm IPsec-MB library tag

[Wathsala Wathawana Vithanage]

> Hi Wathsala,
> Any update on the updated tag and this patch?

Hi Akhil,
Tag SECLIB-IPSEC-2024.03.05 has been created.

[PATCH V2] doc/ipsec_mb: update Arm IPsec-MB library tag

[Wathsala Vithanage]

Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.03.05
in snow3g and zuc documentation. Tag SECLIB-IPSEC-2024.03.05 updates
IPSec-MB library version to 1.4.

Signed-off-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Jack Bond-Preston <Jack.Bond-Preston@arm.com>
---
 doc/guides/cryptodevs/snow3g.rst | 2 +-
 doc/guides/cryptodevs/zuc.rst    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/guides/cryptodevs/snow3g.rst b/doc/guides/cryptodevs/snow3g.rst
index 3392932653..6587fd3f3c 100644
--- a/doc/guides/cryptodevs/snow3g.rst
+++ b/doc/guides/cryptodevs/snow3g.rst
@@ -54,7 +54,7 @@ can be downloaded from `<https://github.com/01org/intel-ipsec-mb/archive/v1.5.zi
 
 For Arm system, ARM64 port of the multi-buffer library can be downloaded from
 `<https://gitlab.arm.com/arm-reference-solutions/ipsec-mb/-/tree/main/>`_. The
-latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2023.06.20.
+latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2024.03.05.
 
 After downloading the library, the user needs to unpack and compile it
 on their system before building DPDK:
diff --git a/doc/guides/cryptodevs/zuc.rst b/doc/guides/cryptodevs/zuc.rst
index a414b5ad2c..d5b9bb6da5 100644
--- a/doc/guides/cryptodevs/zuc.rst
+++ b/doc/guides/cryptodevs/zuc.rst
@@ -53,7 +53,7 @@ can be downloaded from `<https://github.com/01org/intel-ipsec-mb/archive/v1.5.zi
 
 For Arm system, ARM64 port of the multi-buffer library can be downloaded from
 `<https://gitlab.arm.com/arm-reference-solutions/ipsec-mb/-/tree/main/>`_. The
-latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2023.06.20.
+latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2024.03.05.
 
 After downloading the library, the user needs to unpack and compile it
 on their system before building DPDK:
-- 
2.25.1

[PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag

[Jack Bond-Preston]

Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.03.12
in snow3g and zuc documentation.

Signed-off-by: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
Reviewed-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
---
 .mailmap                         | 1 +
 doc/guides/cryptodevs/snow3g.rst | 2 +-
 doc/guides/cryptodevs/zuc.rst    | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.mailmap b/.mailmap
index 58cca13ef6..ac90b71a04 100644
--- a/.mailmap
+++ b/.mailmap
@@ -574,6 +574,7 @@ Jacek Bułatek <jacekx.bulatek@intel.com>
 Jacek Naczyk <jacek.naczyk@intel.com>
 Jacek Piasecki <jacekx.piasecki@intel.com>
 Jacek Siuda <jck@semihalf.com>
+Jack Bond-Preston <jack.bond-preston@arm.com> <jack.bond-preston@foss.arm.com>
 Jacob Keller <jacob.e.keller@intel.com>
 Jakub Chylkowski <jakubx.chylkowski@intel.com>
 Jakub Grajciar <jgrajcia@cisco.com>
diff --git a/doc/guides/cryptodevs/snow3g.rst b/doc/guides/cryptodevs/snow3g.rst
index 3392932653..9c00aa03fa 100644
--- a/doc/guides/cryptodevs/snow3g.rst
+++ b/doc/guides/cryptodevs/snow3g.rst
@@ -54,7 +54,7 @@ can be downloaded from `<https://github.com/01org/intel-ipsec-mb/archive/v1.5.zi
 
 For Arm system, ARM64 port of the multi-buffer library can be downloaded from
 `<https://gitlab.arm.com/arm-reference-solutions/ipsec-mb/-/tree/main/>`_. The
-latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2023.06.20.
+latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2024.03.12.
 
 After downloading the library, the user needs to unpack and compile it
 on their system before building DPDK:
diff --git a/doc/guides/cryptodevs/zuc.rst b/doc/guides/cryptodevs/zuc.rst
index a414b5ad2c..49a5eada46 100644
--- a/doc/guides/cryptodevs/zuc.rst
+++ b/doc/guides/cryptodevs/zuc.rst
@@ -53,7 +53,7 @@ can be downloaded from `<https://github.com/01org/intel-ipsec-mb/archive/v1.5.zi
 
 For Arm system, ARM64 port of the multi-buffer library can be downloaded from
 `<https://gitlab.arm.com/arm-reference-solutions/ipsec-mb/-/tree/main/>`_. The
-latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2023.06.20.
+latest version of the library supported by this PMD is tagged as SECLIB-IPSEC-2024.03.12.
 
 After downloading the library, the user needs to unpack and compile it
 on their system before building DPDK:
-- 
2.34.1

RE: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag

[Akhil Goyal]

> Subject: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag
> 
> Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.03.12
> in snow3g and zuc documentation.
> 
> Signed-off-by: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
> Reviewed-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
Is this tag verified in CI?

Re: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag

[Patrick Robb]

We are rebuilding from this tag right now. I know the IPSEC update is
now postponed until after 24.03, but once this install is done, do you
want me to issue retests for all the recent patches which had failed
for ARM on this library previously? Then I guess it will be verified
as you say.

On Thu, Mar 14, 2024 at 2:50 PM Akhil Goyal <gakhil@marvell.com> wrote:
>
> > Subject: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag
> >
> > Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.03.12
> > in snow3g and zuc documentation.
> >
> > Signed-off-by: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
> > Reviewed-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
> Is this tag verified in CI?

RE: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag

[Akhil Goyal]

> Subject: Re: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library
> tag
> 
> We are rebuilding from this tag right now. I know the IPSEC update is
> now postponed until after 24.03, but once this install is done, do you
> want me to issue retests for all the recent patches which had failed
> for ARM on this library previously? Then I guess it will be verified
> as you say.
> 
Yes, IPsec-mb update is postponed.
But, I remember Bryan highlighted an issue in existing library.
Just wanted to check if this tag can be used in the current release or
Are we good without any changes. 

> On Thu, Mar 14, 2024 at 2:50 PM Akhil Goyal <gakhil@marvell.com> wrote:
> >
> > > Subject: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library
> tag
> > >
> > > Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.03.12
> > > in snow3g and zuc documentation.
> > >
> > > Signed-off-by: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
> > > Reviewed-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
> > Is this tag verified in CI?

Re: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag

[Patrick Robb]

On Thu, Mar 14, 2024 at 4:04 PM Akhil Goyal <gakhil@marvell.com> wrote:
>
>
>
> > Subject: Re: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library
> > tag
> >
> > We are rebuilding from this tag right now. I know the IPSEC update is
> > now postponed until after 24.03, but once this install is done, do you
> > want me to issue retests for all the recent patches which had failed
> > for ARM on this library previously? Then I guess it will be verified
> > as you say.
> >
> Yes, IPsec-mb update is postponed.
> But, I remember Bryan highlighted an issue in existing library.
> Just wanted to check if this tag can be used in the current release or
> Are we good without any changes.

Okay, triggered a DPDK main "periodic run" on the CI now that we are
running from SECLIB-IPSEC-2024.03.12 and I see it passed. So it looks
like this tag can be used with the current release.

Otherwise, I will take the opportunity to just trigger retests for all
series which failed the crypto tests on ARM in recent weeks, just so
we know whether the new library makes a difference (it should), even
though the new requirement won't go through.

RE: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag

[Akhil Goyal]

> > > Subject: Re: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB
> library
> > > tag
> > >
> > > We are rebuilding from this tag right now. I know the IPSEC update is
> > > now postponed until after 24.03, but once this install is done, do you
> > > want me to issue retests for all the recent patches which had failed
> > > for ARM on this library previously? Then I guess it will be verified
> > > as you say.
> > >
> > Yes, IPsec-mb update is postponed.
> > But, I remember Bryan highlighted an issue in existing library.
> > Just wanted to check if this tag can be used in the current release or
> > Are we good without any changes.
> 
> Okay, triggered a DPDK main "periodic run" on the CI now that we are
> running from SECLIB-IPSEC-2024.03.12 and I see it passed. So it looks
> like this tag can be used with the current release.
> 
> Otherwise, I will take the opportunity to just trigger retests for all
> series which failed the crypto tests on ARM in recent weeks, just so
> we know whether the new library makes a difference (it should), even
> though the new requirement won't go through.

Thanks Patrick for testing this out.

Applied to dpdk-next-crypto