From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 272DB43B6F; Wed, 28 Feb 2024 18:59:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 106A540EE4; Wed, 28 Feb 2024 18:59:31 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 7561B4003C for ; Wed, 28 Feb 2024 18:59:29 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id C74BD20B74C0; Wed, 28 Feb 2024 09:59:28 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C74BD20B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1709143168; bh=qsAxl8KTeRJB7BSzjaxtiMGQDqo8I80H+8i7eqGXALc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nKnxD44hq9KeIQ/amFF+t+1wx08wD69a4DPfYQ+bccPdyxEe8MPjvGn7pCI8XkBLd w+80/a/J+4RTiTbchMw/2+bNMUZa0xob0a3c6fvD9su6V7Jtu4xlsTR1iXyWFbqukm 3XQo+4GMMCG2+w1z6C2ib0U16gQuLdZ8K7JK9MvA= Date: Wed, 28 Feb 2024 09:59:28 -0800 From: Tyler Retzlaff To: David Marchand Cc: dev@dpdk.org, Anatoly Burakov , Ashish Gupta , Chenbo Xia , Cristian Dumitrescu , David Hunt , Fan Zhang , Hemant Agrawal , Honnappa Nagarahalli , Jasvinder Singh , Jerin Jacob , Konstantin Ananyev , Maxime Coquelin , Reshma Pattan , Sachin Saxena , Sivaprasad Tummala , Srikanth Yalavarthi , Stephen Hemminger , Sunil Kumar Kori , bruce.richardson@intel.com, mb@smartsharesystems.com, thomas@monjalon.net Subject: Re: [PATCH v3 00/16] stop using variadic argument pack extension Message-ID: <20240228175928.GA12255@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com> <1708978786-6740-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 28, 2024 at 06:29:14PM +0100, David Marchand wrote: > On Mon, Feb 26, 2024 at 9:20 PM Tyler Retzlaff > wrote: > > > > RTE_LOG_LINE cannot be augmented with a prefix format and arguments > > without the user of RTE_LOG_LINE using the args... and ## args compiler > > extension to conditionally remove trailing comma when the macro receives > > only a single argument. > > > > Provide a new/similar macro RTE_LOG_LINE_PREFIX that accepts the prefix > > format and arguments as separate parameters allowing them to be expanded > > at the correct locations inside of RTE_FMT() allowing the rest of the > > non-prefix format string and arguments to be collapsed to the argument > > pack which can be directly forwarded with __VA_ARGS__ avoiding the need > > for conditional comma removal. > > > > I've done my best to manually check expansions (preprocessed) and compiled > > printf of the logs to validate correct output. > > > > note: due to drastic change in series i have not carried any series acks > > forward. > > > > v3: > > * remove leading _ from RTE_LOG_COMMA the macro is not internal > > * add doxygen comment for existing RTE_LOG{,DP}_LINE function-like > > macros, based on RTE_LOG{,DP} comments. > > * add doxygen comment for new RTE_LOG{,DP}_LINE_PREFIX function-like > > macros, based on RTE_LOG{,DP} comments. > > * merge 2 vhost patches into a single patch (mistake in previous > > submission) > > I find this new helper less tricky to use and easier to read than the > RTE_FMT_* stuff that gets copy/pasted everywhere. > The changes are quite mechanical, so even though we are past -rc1, +1 > for me on the series. > > Can we finish the job and convert remaining macros that prefix messages in lib/? I didn't realize I missed any. do you have a list or a regex that points me at them. I was just searching for use of args... Happy to make the conversion of the others in the next rev. ty > > > -- > David Marchand