From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1795E43BCF;
	Fri,  1 Mar 2024 19:10:46 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 06F7042D68;
	Fri,  1 Mar 2024 19:10:46 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id E3C28402B8
 for <dev@dpdk.org>; Fri,  1 Mar 2024 19:10:43 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 45D2D20B74C0; Fri,  1 Mar 2024 10:10:43 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 45D2D20B74C0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1709316643;
 bh=tCXrTMZFIXTNCdX4scKhRTFUpkM5XUt/ztQzCiV/PPg=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=XDiB4SNeBseUBANoNFz+9RuHcSCGAASXEScGfB6OmoCuHCeV7YbcwiYDBXPF8uuMJ
 aN+H6l0NKUL+twD9tYRTXn26AeqODXrj52pIU8fVu0Gs6rx/RcYg3Xt80DSeL8otpE
 SaUKhjx5CHfXPl6pWCIpPF52CMBPDk6qYzO/DEuU=
Date: Fri, 1 Mar 2024 10:10:43 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Devendra Singh Rawat <dsinghrawat@marvell.com>,
 Alok Prasad <palok@marvell.com>
Subject: Re: [PATCH 4/6] net/qede: replace use of rand()
Message-ID: <20240301181043.GB983@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20240301175842.159967-1-stephen@networkplumber.org>
 <20240301175842.159967-5-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240301175842.159967-5-stephen@networkplumber.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, Mar 01, 2024 at 09:57:09AM -0800, Stephen Hemminger wrote:
> The function of rand() is a weak random number generator.
> Use the DPDK rte_rand() instead.
> 
> Note: this doesn't matter for real security, since most drivers
> use a fixed RSS default key.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>