From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4CA7E43BCF;
	Fri,  1 Mar 2024 19:11:45 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3E57B433D2;
	Fri,  1 Mar 2024 19:11:45 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 59C0242D68
 for <dev@dpdk.org>; Fri,  1 Mar 2024 19:11:43 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id BAC4B20B74C0; Fri,  1 Mar 2024 10:11:42 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BAC4B20B74C0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1709316702;
 bh=t9vAINe7VfWWcelpAsU1WUkv3wpWoT9bgo19zA7NC6U=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=BbRt8BZahIsT+eD8pBsLEe1CiRfLsF3Y4JP2s0UcyNOhyGXVi9/CcAGaC2t5rV2ju
 U57kpGx7o6MOWz9GYBbFt9/ys1FyLN5AVuzWs4TF/s2mHlE5ckj616YWP1deilefyV
 SKOQYFjKeLZll04gMdO/DHegN94pZ7L+ABp09vC4=
Date: Fri, 1 Mar 2024 10:11:42 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, hernan.vargas@intel.com,
 Nicolas Chautru <nicolas.chautru@intel.com>
Subject: Re: [PATCH 6/6] baseband/fpga_5gnr: don't use rand()
Message-ID: <20240301181142.GD983@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20240301175842.159967-1-stephen@networkplumber.org>
 <20240301175842.159967-7-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240301175842.159967-7-stephen@networkplumber.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, Mar 01, 2024 at 09:57:11AM -0800, Stephen Hemminger wrote:
> The function rand is very weak and should not be used.
> Use the DPDK rte_rand() which is seeded from entropy instead.
> 
> Coverity issue: 414987
> Fixes: b3d326e438f1 ("baseband/fpga_5gnr_fec: add FPGA mutex")
> Cc: hernan.vargas@intel.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>