DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] common/cnxk: fix loopback port dataflow issue
@ 2024-03-04 12:33 Rahul Bhansali
  2024-03-04 16:35 ` Jerin Jacob
  0 siblings, 1 reply; 2+ messages in thread
From: Rahul Bhansali @ 2024-03-04 12:33 UTC (permalink / raw)
  To: dev, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori,
	Satha Rao, Harman Kalra
  Cc: jerinj, Rahul Bhansali

With loopback interface and IPsec Inbound traffic, getting
NIX_CQERRINT_CPT_DROP interrupt and dataflow is stopped.
This is due to flow control configuration is skipped as
roc_nix_is_esw() returns true for loopback device also.

Fixes: 978dc3a13f7b ("common/cnxk: base support for eswitch VF")
Fixes: f812768a9e66 ("net/cnxk: support eswitch VF as ethernet device")

Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
---
 drivers/common/cnxk/roc_nix.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/common/cnxk/roc_nix.c b/drivers/common/cnxk/roc_nix.c
index 20202788b5..041621dfaa 100644
--- a/drivers/common/cnxk/roc_nix.c
+++ b/drivers/common/cnxk/roc_nix.c
@@ -385,8 +385,9 @@ sdp_lbk_id_update(struct plt_pci_device *pci_dev, struct nix *nix)
 		nix->sdp_link = true;
 		break;
 	case PCI_DEVID_CNXK_RVU_AF_VF:
-	case PCI_DEVID_CNXK_RVU_ESWITCH_VF:
 		nix->lbk_link = true;
+		break;
+	case PCI_DEVID_CNXK_RVU_ESWITCH_VF:
 		nix->esw_link = true;
 		break;
 	default:
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] common/cnxk: fix loopback port dataflow issue
  2024-03-04 12:33 [PATCH] common/cnxk: fix loopback port dataflow issue Rahul Bhansali
@ 2024-03-04 16:35 ` Jerin Jacob
  0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2024-03-04 16:35 UTC (permalink / raw)
  To: Rahul Bhansali
  Cc: dev, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori,
	Satha Rao, Harman Kalra, jerinj

On Mon, Mar 4, 2024 at 6:10 PM Rahul Bhansali <rbhansali@marvell.com> wrote:
>
> With loopback interface and IPsec Inbound traffic, getting
> NIX_CQERRINT_CPT_DROP interrupt and dataflow is stopped.
> This is due to flow control configuration is skipped as
> roc_nix_is_esw() returns true for loopback device also.
>
> Fixes: 978dc3a13f7b ("common/cnxk: base support for eswitch VF")
> Fixes: f812768a9e66 ("net/cnxk: support eswitch VF as ethernet device")
>
> Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>

Applied to dpdk-next-net-mrvl/for-main. Thanks


> ---
>  drivers/common/cnxk/roc_nix.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_nix.c b/drivers/common/cnxk/roc_nix.c
> index 20202788b5..041621dfaa 100644
> --- a/drivers/common/cnxk/roc_nix.c
> +++ b/drivers/common/cnxk/roc_nix.c
> @@ -385,8 +385,9 @@ sdp_lbk_id_update(struct plt_pci_device *pci_dev, struct nix *nix)
>                 nix->sdp_link = true;
>                 break;
>         case PCI_DEVID_CNXK_RVU_AF_VF:
> -       case PCI_DEVID_CNXK_RVU_ESWITCH_VF:
>                 nix->lbk_link = true;
> +               break;
> +       case PCI_DEVID_CNXK_RVU_ESWITCH_VF:
>                 nix->esw_link = true;
>                 break;
>         default:
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-04 16:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-04 12:33 [PATCH] common/cnxk: fix loopback port dataflow issue Rahul Bhansali
2024-03-04 16:35 ` Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).