From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AB6A43C0C; Thu, 7 Mar 2024 17:49:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47E6C42EB5; Thu, 7 Mar 2024 17:49:37 +0100 (CET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 8C06B40272 for ; Thu, 7 Mar 2024 17:49:35 +0100 (CET) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6e5760eeb7aso842899b3a.1 for ; Thu, 07 Mar 2024 08:49:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709830175; x=1710434975; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=xSpz8ca7cXsFrunahWk3QBKQ6wOlQ1rnBvmJWXVhEbc=; b=FBZ+UpM2gev+Locsio4G9jwgc87+OIuYdT+lZK1OCnnV7j983RSsPy8oIdPQxWgZNx E3xu+mgyhQLG5fXgq3/SANPIV/rjrI0wH55xFI/OHfujuoxEuqI3kwQ7VY3+SjwgyKDj Fwc5LUlj7+cFlNumG4jW/wL6andCx3KMa2lAND7o8FkSJk/0zNailJoFwJzBwtbrc2Ed G4Hnll++xuCdXZL1R3Baf4SKKGzq9bAk1cD4du1zAfQppg8iyaWmCD0U00aLwJvT6EDc F8YdAwdyPfMKmd5hzdjCpI1jgaNHNKDeDa/ZsBiVcgcNGTrbhft77IZoK0Tw1lQxePzE vReQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709830175; x=1710434975; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xSpz8ca7cXsFrunahWk3QBKQ6wOlQ1rnBvmJWXVhEbc=; b=Ot4sG8YK/k/Kmru7te3wTqCW/j5h1BXbzs34BgCwRBlNFLQf+brhcAnwayiy0yeicm 7FlO+8Wkk65cCch5uZ4HQu2K+GsisQltWfKnylAUfRCNnY9NgPyJ1nzvJ104JH+1e0lU ZfyuB8LcHh9SBFiIcWOx97SE2p27CzhuHr5TGcCJQ+60EYOnuFHmgCtHLgq39h8hCv0L Uxhxgg9d6h/THsZqk8TAQVcy3M+pohSv9Ap3A3r2MMtKI443ye2EwhRrGASK2yq0gA5E knRg3NuD9gG6FNS5z38JJibadaTJP/QAfTlkqGK3yQAsgHiOZo+cDaejunqpyqNf/8e6 DGRA== X-Forwarded-Encrypted: i=1; AJvYcCWxIIvNiUis7RDdh+qMDQYlRDp7jVomJGPByEMYPLBD4r8cr9oKzK6TZrpfpfpq84rgGKMJzMI9r2q5ASo= X-Gm-Message-State: AOJu0Yw065K2ZRHDF0b3ZScUNgm0xNZ2if1dkZ99rLbDNHy+xEFy8RGM 2/fFfh/qKsFqCjk7Ggs2CTMMYnFrNa64FmfjXckcTTcfYtbW1F8DFGQQnFKzIAU= X-Google-Smtp-Source: AGHT+IGV5F4uGml3SIopzjAFAU3WTqZn1bZ06qmRg02BS1my1cIxGG4yAbtTcV5AY0PUgnwW3zq8yg== X-Received: by 2002:a05:6a00:1ac7:b0:6e6:27d3:96ab with SMTP id f7-20020a056a001ac700b006e627d396abmr11942607pfv.16.1709830174734; Thu, 07 Mar 2024 08:49:34 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id p13-20020a635b0d000000b005c6e8fa9f24sm13016543pgb.49.2024.03.07.08.49.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 08:49:34 -0800 (PST) Date: Thu, 7 Mar 2024 08:49:32 -0800 From: Stephen Hemminger To: David Marchand Cc: Tyler Retzlaff , dev@dpdk.org, Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin Subject: Re: [PATCH] hash: make gfni stubs inline Message-ID: <20240307084932.535d2a2c@hermes.local> In-Reply-To: References: <20240304184508.89956-1-stephen@networkplumber.org> <20240305175300.GC18937@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 7 Mar 2024 11:32:36 +0100 David Marchand wrote: > On Tue, Mar 5, 2024 at 6:53=E2=80=AFPM Tyler Retzlaff > wrote: > > > > On Tue, Mar 05, 2024 at 11:14:45AM +0100, David Marchand wrote: =20 > > > On Mon, Mar 4, 2024 at 7:45=E2=80=AFPM Stephen Hemminger > > > wrote: =20 > > > > > > > > This reverts commit 07d836e5929d18ad6640ebae90dd2f81a2cafb71. > > > > > > > > Tyler found build issues with MSVC and the thash gfni stubs. > > > > The problem would be link errors from missing symbols. =20 > > > > > > Trying to understand this link error. > > > Does it come from the fact that rte_thash_gfni/rte_thash_gfni_bulk > > > declarations are hidden under RTE_THASH_GFNI_DEFINED in > > > rte_thash_gfni.h? > > > > > > If so, why not always expose those two symbols unconditionnally and > > > link with the stub only when ! RTE_THASH_GFNI_DEFINED. =20 > > > > So I don't have a lot of background of this lib. > > > > I think we understand that we can't conditionally expose symbols. That's > > what windows was picking up because it seems none of our CI's ever end > > up with RTE_THASH_GFNI_DEFINED but my local test system did and failed. > > (my experiments showed that Linux would complain too if it was defined)= =20 >=20 > I can't reproduce a problem when I build (gcc/clang) for a target that > has GFNI/AVX512F. > binutils ld seems to just ignore unknown symbols in the map. Turns out MSVC linker does not. That is why Tyler complained.