From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0282443C0C; Thu, 7 Mar 2024 17:53:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C10EA4067E; Thu, 7 Mar 2024 17:53:20 +0100 (CET) Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) by mails.dpdk.org (Postfix) with ESMTP id DF4DE40272 for ; Thu, 7 Mar 2024 17:53:18 +0100 (CET) Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-3c19b7d9de7so636062b6e.2 for ; Thu, 07 Mar 2024 08:53:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709830398; x=1710435198; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=U/j4L0kLSEV17VWFyp1gglfeb2MT8BHvwo1ZIy05rXA=; b=gOQkNg6XCwYQBppk71se1MqsgG7/fTo9GAsiXPoCX6yeieuPsgD+AOAlR1w5C4jDni opA7qafIi6URoa13B1LK/Fw95oVkQNcpS+IkzCyuk/dXjQJz511Kf3GVLwY+m/n1C3r3 z75XiBikixd1M27HG6EYc3tbLYii27tIQVtGa51X6qQK7iw1JtnLoSteP2SmG+UZM27Y HF9f/YvcQ06SNe7prpZRWA3h9RRG6Ac+9Ul83tWr+rlPsvT76LMT9Uy7ibBVY7PKLpsO O23x+jd3alYsY2J3a7mdV1ubftxB2kPIjP4CbSt1kaKmH4DQWeB5WWUE7p/iHfwWfPER 3bCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709830398; x=1710435198; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U/j4L0kLSEV17VWFyp1gglfeb2MT8BHvwo1ZIy05rXA=; b=Igx2hzEAzO07YfQXUxa0peXU/PzCofYWTffFNLPfWtGpd+NcIrSzi0VbJICHUIWdRV kvnSJrHvoGC8414E029ksdCfNwJECHT5dX6PHYd3AvGD21homZqOOeeTioTAuWwZCYrH 23nZqZRclXbBgmJf7LliHIfI4uGoAcFF55QKq5EbGl9s2VoKjznIZJjeCsHNtdZrV+SA KAQ8VxA+FDt8S/BX9wsMbpTz1UaUMIjKJceoGti/5gWFwbB8+6K0Op8JQnPK2IwH2e5e r0zap6MRfyb7ki/aF/lu48+0NKFxnbedT2FxAwINuQTCPlv27gb5mcAKwmLIEh/0l4pq itOg== X-Gm-Message-State: AOJu0Yyena2e+QrxSH8Q2caU8P0A5qHgFn+007f/ul1Vy6vcHBwo3cKO yx6Ec93cN+2M+TXPTzQtW8trED09saSjKQ3KUxsxWyATG3KwUHU+p440g4g4VzA= X-Google-Smtp-Source: AGHT+IEZ9WDxbIckDjRB2/F1Ldc/kQqPy041IBzRhhUC9rJO7RYTEOsA1QOZppd3GRqNL5qet44duA== X-Received: by 2002:a05:6808:14c8:b0:3c1:d10b:33fa with SMTP id f8-20020a05680814c800b003c1d10b33famr10156823oiw.10.1709830398187; Thu, 07 Mar 2024 08:53:18 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id ca10-20020a056a02068a00b005dccf9e3b74sm1053050pgb.92.2024.03.07.08.53.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 08:53:17 -0800 (PST) Date: Thu, 7 Mar 2024 08:53:16 -0800 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org Subject: Re: [PATCH] net/tap: allow more that 4 queues Message-ID: <20240307085316.7457efc2@hermes.local> In-Reply-To: <33a18d63-192c-4b2c-ad1c-3c75d713bc33@amd.com> References: <20240229175620.122949-1-stephen@networkplumber.org> <20240306122104.143a7424@hermes.local> <33a18d63-192c-4b2c-ad1c-3c75d713bc33@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 7 Mar 2024 10:25:48 +0000 Ferruh Yigit wrote: > > I got 4 queues setup, but looks like they are trash in secondary. > > Probably best to revert this and fix it by bumping RTE_MP_MAX_FD_NUM. > > This is better, but does take some ABI issue handling. > > > > We can increase RTE_MP_MAX_FD_NUM but still there will be a limit. > > Can't it be possible to update 'rte_mp_sendmsg()' to support multiple > 'rte_mp_sendmsg()' calls in this patch? > > Also need to check if fds size is less than 'RTE_PMD_TAP_MAX_QUEUES' > with multiple 'rte_mp_sendmsg()' call support. Kernel allows up to 253 fd's to be passed. So for tap that would limit it to 126 queues; because TAP dups the fd's for rx and tx but that could be fixable. Tap should have a static assert about max queues and this as well. Increasing RTE_MP_MAX_FD_NUM would also fix similar issues in af_xdp PMD and when af_packet gets MP support.