From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAED843C21; Thu, 7 Mar 2024 21:23:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F2C6402BA; Thu, 7 Mar 2024 21:23:51 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 25EFE40272 for ; Thu, 7 Mar 2024 21:23:50 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-29baec5f751so45810a91.0 for ; Thu, 07 Mar 2024 12:23:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709843029; x=1710447829; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=iy0TAwb5Ezlxc7Mt3zbjOitWWHmFSCUEyFqhQWEGrhY=; b=WHjlx9YWv1ZK0v9lkTyhPNe8ZcJXy7Fh9elvrdjNqNaxlOtAfBO5lf7Z/wR9v3/ctC vib1w2PwozpLYIQLJtyU8aq/AkZxb8P9CCLgLh0fiWtIQ/4kegZztkWhXNssU3FP2J70 I8qRMY/lUcyKZ+7JaDHvWrE+u7nix+HVxZ7JPJl+QVpwEqhMhkF3ujXrbNdoWPUp5pxm t0KBHtHL0xZ9FfV/d4rnUWCQ3AEVRc9X939pq+Cl9Uw9+FB5jBeKxZhlizgwMcgKHO18 ovorX+tKYUZVdk03VwkpzSuZqZPmgjN/xpUUUNmEt1mnj1wTYW+GIF5Junlj92VdN8It cupA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709843029; x=1710447829; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iy0TAwb5Ezlxc7Mt3zbjOitWWHmFSCUEyFqhQWEGrhY=; b=CBX+ABEUG68p+r896958OoIXEbs/0+QHrbi4Ldru02SDbv/6bYXCpK+hVaVPhUDI70 QSiUxNNlYz+9R5nFCtNf6+uClNjEpTsR13es8bP15Gauy8TNQbt0o2/GlAhZ/BmpeETQ dcd709zNsTrszxnIPs84GiTGA16GKQWcN3SiYHR691GL1DGQtA/bS0iWazToqx5ugvUx Y8REwu8j/6wweclknPfZbPLjkOmRlXdG0AG/vmC6w9eVuwTiAQLkNUDZ8BDZx2ks7jtM PUMupBSaKtn5HNjjAaTGtVyUqUuJtHnfExwrX4uUWeGwJu/GS2qBFDpaxqyQPLVLiLlH DIjQ== X-Forwarded-Encrypted: i=1; AJvYcCXVLkZHY6jMfvzGqxUUvGR/U/zp2I9FaHX7/FLmwDfpizbWy8gVpm8ydRLti9wL5m6UdJfip4DQoc3danY= X-Gm-Message-State: AOJu0Yxi0I+PcaQjriyRinLZcODZje4tjaVvTrcdCxj48TVXEw9MGPez 0pOBsqJDlSm8gLcrQCzAdB4uIph9we01oRUhaZsHX7w715st/+tNCxExwDaLtag= X-Google-Smtp-Source: AGHT+IFmasX4GWI1TvGsiazI+xINzy3WKG361ufW/llhe1y/Wtrs7+xaDzBR5jS7oFzyUIq8MdS5qA== X-Received: by 2002:a17:90b:1e46:b0:29b:84e6:70c with SMTP id pi6-20020a17090b1e4600b0029b84e6070cmr3548335pjb.2.1709843029130; Thu, 07 Mar 2024 12:23:49 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id cx11-20020a17090afd8b00b0029b9f35648asm971452pjb.24.2024.03.07.12.23.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 12:23:48 -0800 (PST) Date: Thu, 7 Mar 2024 12:23:46 -0800 From: Stephen Hemminger To: David Marchand Cc: Tyler Retzlaff , dev@dpdk.org, Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin Subject: Re: [PATCH v3] hash: put GFNI stubs back Message-ID: <20240307122346.4bddb0d7@hermes.local> In-Reply-To: References: <20240304184508.89956-1-stephen@networkplumber.org> <20240307013715.114013-1-stephen@networkplumber.org> <20240307173651.GA13790@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 7 Mar 2024 18:59:11 +0100 David Marchand wrote: > On Thu, Mar 7, 2024 at 6:37=E2=80=AFPM Tyler Retzlaff > wrote: > > On Wed, Mar 06, 2024 at 05:36:42PM -0800, Stephen Hemminger wrote: =20 > > > Make the GFNI stub functions always built. This solves the conditional > > > linking problem. If GFNI is available, they will never get used. > > > > > > Fixes: 07d836e5929d ("hash: uninline GFNI stubs") > > > Signed-off-by: Stephen Hemminger =20 > > Tested-by: Tyler Retzlaff =20 >=20 > Applied with the edits I mentionned previously. >=20 >=20 I noticed that there is an still an unnecessary inclusion of rte_log.h in rte_thash_gfni.h but that doesn't matter.