From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 594F843C12;
	Thu,  7 Mar 2024 19:36:52 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3C580402BA;
	Thu,  7 Mar 2024 19:36:52 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 3876D40272
 for <dev@dpdk.org>; Thu,  7 Mar 2024 19:36:50 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 5CE1B20B74C0; Thu,  7 Mar 2024 10:36:49 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5CE1B20B74C0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1709836609;
 bh=yfkCpFl6InBYZTL7OhrxVAjUvzhN15zrqWbP2lEXxxk=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=h19feENmml53px2dqiBnNsOowsstXriC08Q3UczaqXEwLrbH5yCHaT7JgCh4Vdg0S
 5YfTpOkIBGjzIWkiIO3wCrv0kdYB//asbe1x1jxuAU6YB5SOJrdU/s8/OuCwGiiNDk
 LweZlgy7fmBBVhbuxsPD8xJXDWQ2g+cuURfyY+Po=
Date: Thu, 7 Mar 2024 10:36:49 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, bluca@debian.org,
 Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2] test/lcores: reduce cpu consumption
Message-ID: <20240307183649.GA22674@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20240307113324.845309-1-david.marchand@redhat.com>
 <20240307141608.1450695-1-david.marchand@redhat.com>
 <CAJFAV8xxnqEGFrksqsd-_vUtmHMm_-b-+Q_J6h=D06QS-4NFyg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJFAV8xxnqEGFrksqsd-_vUtmHMm_-b-+Q_J6h=D06QS-4NFyg@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Mar 07, 2024 at 07:06:26PM +0100, David Marchand wrote:
> On Thu, Mar 7, 2024 at 3:16 PM David Marchand <david.marchand@redhat.com> wrote:
> >
> > Busy looping on RTE_MAX_LCORES threads is too heavy in some CI or build
> > systems running the fast-test testsuite.
> > Ask for a reschedule at the threads synchronisation points.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > Acked-by: Luca Boccassi <bluca@debian.org>
> 
> Ideally, this test should be rewritten with some kind of OS-agnostic
> synchronisation/scheduling API (mutex?).
> But I think it will be enough for now.

It's okay, I'll eventually get to this :)

> 
> I updated the code comment as requested by Stephen.
> 
> Applied, thanks.
> 
> -- 
> David Marchand