From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CEBE43BC7; Fri, 8 Mar 2024 17:26:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2FF7402B4; Fri, 8 Mar 2024 17:26:36 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id F270B40291 for ; Fri, 8 Mar 2024 17:26:34 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1dcc7f4717fso8207435ad.0 for ; Fri, 08 Mar 2024 08:26:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709915194; x=1710519994; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=or/QN66/Xvt0NKJhh5JUdbnoCwe2H4Qv8DYq6ftxisg=; b=wYli98NRbZR6Upea6mnMW0BUEsvrXrSNtT/3gHGL378OvG77zXWxyX3GzKFAwljNX/ wmqnDLpatBIFC3zC0NxeQL+opCRr7u73rp+KOG4gXXn96TH/BD8uU1s7ruLwWEoKA70C uu5miInJeJJ6mI15MuAZ5rWbx3jkICl0njxrjZrR29b2oCLCZ2CYR7XBvl3ag6aCouES YVdWtaeZ5PRZY5coVpiRxwY56XFI69cBLWdFDcKms0EQTA+N2DrRxPm52WfvH1TYP2GM hX0t30m2U+0SXX9qUWOJbE4TROxxJcTHMcNLjIiTFKct0kiMl33annL7m/5WSh9Rpen3 BivA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709915194; x=1710519994; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=or/QN66/Xvt0NKJhh5JUdbnoCwe2H4Qv8DYq6ftxisg=; b=YlcSIGH3XxroVh8hfgCYsGQQEct2vjVlHJ2KlRyLtzwGBbBFt5NVEH3Mb0oGZeW4eT s+v4ctXRKLqlQ/ySFwrH5CsLOk5jWXsQ5L952uI+cQQwX4q9LcIKT+TLfLpoDQMniarY kzQFJOEw1ZmCyfEytH1MYv3aVOMJeZLk0xk5Ir/6tTEJZroZiBW1jA0FSeUaG+zYjZ9/ jvjzEe9BDBJTYGruEt6XHJVo937XNbwMXmRnSakHqdKuSHgbbhjksTFe2PYP/B/eyLEG FuKPe+VljKTiPIQWulcWLKe4BP6pFTs/Xr5IgOqm6DJXDFcRFb1LUOsgBR4/WJjPceXB GjJQ== X-Gm-Message-State: AOJu0YwlUqVmFqROnT1d90N6Z0BmvMepVxJ13/rx+PlpCoQtyCqo6Ms2 WeuvLIUSCrfBjU6fA+QaXhljMER+N/X9YkY3Na9g+1oWAyx8T4OJEFGE3gMRdGA= X-Google-Smtp-Source: AGHT+IHZlGdGxvOV76vEZHqKkOGl1WgMnzr31o3T9MB6tk8vRhIxhCidCIxqyp9aEyAp+S2azdoVqA== X-Received: by 2002:a17:902:cccd:b0:1dd:75c6:faa6 with SMTP id z13-20020a170902cccd00b001dd75c6faa6mr135263ple.6.1709915194094; Fri, 08 Mar 2024 08:26:34 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id h6-20020a170902eec600b001dd63494820sm1957814plb.166.2024.03.08.08.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 08:26:33 -0800 (PST) Date: Fri, 8 Mar 2024 08:26:31 -0800 From: Stephen Hemminger To: "Singh, Aman Deep" Cc: , Huisong Li , Yuying Zhang Subject: Re: [PATCH v2 3/3] testpmd: replace EAL logtype TESTPMD_LOG Message-ID: <20240308082631.0ff461d9@hermes.local> In-Reply-To: References: <20231211172437.61958-1-stephen@networkplumber.org> <20240216033743.150800-1-stephen@networkplumber.org> <20240216033743.150800-4-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 8 Mar 2024 19:05:32 +0530 "Singh, Aman Deep" wrote: > > if (ret) { > > - RTE_LOG(ERR, EAL, "can not get port by device %s!\n", > > - device_name); > > + fprintf(stderr, "Can not get port by device %s!\n", device_name); > > Any specific reason to use fprintf() here rather than TESTPMD_LOG No. Just that was done in earlier version.