From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA98A43C94; Tue, 12 Mar 2024 18:26:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 722CB40EE2; Tue, 12 Mar 2024 18:26:26 +0100 (CET) Received: from mail-ua1-f99.google.com (mail-ua1-f99.google.com [209.85.222.99]) by mails.dpdk.org (Postfix) with ESMTP id 4B96840ED9 for ; Tue, 12 Mar 2024 18:26:25 +0100 (CET) Received: by mail-ua1-f99.google.com with SMTP id a1e0cc1a2514c-7dae66def19so100611241.0 for ; Tue, 12 Mar 2024 10:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1710264384; x=1710869184; darn=dpdk.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=93fItQ901Ui9+D2axs7+S+uRXChQxKuAS2hricrm7VY=; b=W4oGyG5El/JJ/LPKh9axJ0rM5CNI8XOSMVoT8tTFFHs5OYutHzOLeu7lZTBfYMFDpq ZfjcgMdpZEz8Qxl8Vk7/axHtXUVrJMFiTRBSsrgWxcV4TjDAGEyHeZnT8c+3CfwewRC0 cEwFZF31PUuGUwRoGeppqJbgfwSNU+ChRLNa0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710264384; x=1710869184; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=93fItQ901Ui9+D2axs7+S+uRXChQxKuAS2hricrm7VY=; b=Y/thl3wuNS5OFS80QFWGRTiiupkHN+U02OUZ3E8gXw3ZdBmNkIseg1wYAXepjAANoA FWWkoYZIP3MO3WXBUAW/9W1EdPcCOnt/3vHcm093P1GWVP5Oat4I1w6a9QeOoi3hQ7Nu rkNsP8GtMfjG1scTUtFc1dx1M0z0cp3iuJr3HVHT0aKUlPOqUA7qCKoL2ETNkQdNfNlU Uanj69gDu4D5kxKOUQYpLMzpNW+m00Gx6VuJzaoxSeAe/Oy2OWOVTY+LTKJ38EniqsgF I+/6p9+mSp9XmVQo408hYObn9z3HG7IADJuQ0cAxSR0BeFWlqIU1QhYIc0gZpYh/ybYL /COA== X-Gm-Message-State: AOJu0YzSCSyWYUeBvrZYZ1jXwBAKC2SqKokE3ahiZNbTshk9Qxwx50r5 5uNvdAy+C1o5kQKSt2f/LUH+f0M1kQ6tdPXuw8TSR41CpI4IeIv1aEFiNFEb4U3moycnnhUtSwN vroKCTtabHTrFO2xc/iD2EhzF8FtsXQi3UAYVWAAK5kt7cqrT X-Google-Smtp-Source: AGHT+IFfHeBmkyHR8gztMqnbKbdXz8oitAYxm+3n6Ynpd3pqkEH5oVKvDeYDIQI5O9K3mrelCaaLxGuYJvLZ X-Received: by 2002:a05:6102:21c8:b0:473:df7:1084 with SMTP id r8-20020a05610221c800b004730df71084mr1177980vsg.29.1710264383171; Tue, 12 Mar 2024 10:26:23 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id w20-20020ab055d4000000b007db0d250347sm470438uaa.2.2024.03.12.10.26.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2024 10:26:23 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Received: from iol.unh.edu (unknown [IPv6:2606:4100:3880:1271:90f9:1b64:f6e6:867f]) by postal.iol.unh.edu (Postfix) with ESMTP id A71456052471; Tue, 12 Mar 2024 13:26:22 -0400 (EDT) From: jspewock@iol.unh.edu To: Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, thomas@monjalon.net, wathsala.vithanage@arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, Luca.Vizzarro@arm.com Cc: dev@dpdk.org, Jeremy Spewock Subject: [PATCH v1 0/2] Improve interactive shell output gathering Date: Tue, 12 Mar 2024 13:25:56 -0400 Message-ID: <20240312172558.11844-1-jspewock@iol.unh.edu> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jeremy Spewock When the interactive shell was originally added, the gathering of output was implented in a way that was trying to be flexible enough to gather output until a given string was found anywhere in the output. It has been found more recently that this greater flexibility provides less guarantees when writing tools that implement the shell and ultimately can lead to unexpected behaviour. This is especially true when sending multi-line commands into the shell which is desirable in some cases. To account for this, the prompt will strictly be expected at the end of a line from the output. There were also some quality of life changes made to this system such as better wrapping of errors to privde some more useful output. Jeremy Spewock (2): dts: Improve output gathering in interactive shells dts: Add missing docstring from XML-RPC server dts/framework/exception.py | 7 +++ .../remote_session/interactive_shell.py | 26 +++++++---- .../testbed_model/traffic_generator/scapy.py | 46 ++++++++++++++++++- 3 files changed, 70 insertions(+), 9 deletions(-) -- 2.43.2