From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9463343C94;
	Tue, 12 Mar 2024 18:55:55 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 84FAB42DD2;
	Tue, 12 Mar 2024 18:55:55 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id BB6FE42DC1
 for <dev@dpdk.org>; Tue, 12 Mar 2024 18:55:53 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 219C420B74C0; Tue, 12 Mar 2024 10:55:53 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 219C420B74C0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1710266153;
 bh=0/J5bWM2F8QnCfQF7+4OaeEzNjGcfeHGpyc4mEdmjgY=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=MvmYUnyNnDzdtEKEKiAkNSJ5WVm5EDgKDlRpHZSuj2Gf/t0mvt6dggJzCQLzcQaEw
 Czdpqj86IIGGBUCt8wJTl/v6GdV22FGpn5ZK9fuQqu20ib8+0f0FniCYGfCfZNALlr
 mET1gZTeSuZH9H1dkW3jqLVIXUbHcGAygRMBIhfc=
Date: Tue, 12 Mar 2024 10:55:53 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] windows: install sched.h header
Message-ID: <20240312175553.GA15867@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1703017057-22336-1-git-send-email-roretzla@linux.microsoft.com>
 <ZYKv1lHjBKmapT7o@bricha3-MOBL.ger.corp.intel.com>
 <1930676.GKX7oQKdZx@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1930676.GKX7oQKdZx@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Jan 30, 2024 at 05:52:54PM +0100, Thomas Monjalon wrote:
> 20/12/2023 10:11, Bruce Richardson:
> > On Tue, Dec 19, 2023 at 12:17:37PM -0800, Tyler Retzlaff wrote:
> > > rte_os.h includes sched.h so install sched.h to allow DPDK installed to
> > > DESTDIR to be usable.
> 
> Why other files don't need to be exported as well?

after reviewing all other files it was found that only sched.h is being
included by an installed / public header. all other headers in
windows/include are used internally only.
> 
> > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > > ---
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> That's a fix which may need to be backported.

found the commit that added sched.h and added a Fixes tag.

thanks!