From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: David Marchand <david.marchand@redhat.com>,
dev@dpdk.org, stable@dpdk.org,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Bernard Iremonger <bernard.iremonger@intel.com>
Subject: Re: [PATCH 2/4] app/testpmd: fix burst option parsing
Date: Wed, 13 Mar 2024 09:32:13 -0700 [thread overview]
Message-ID: <20240313093213.18636f52@hermes.local> (raw)
In-Reply-To: <18743010-a6ae-43c0-9a39-a2a9a6b56e4b@amd.com>
On Wed, 13 Mar 2024 12:09:01 +0000
Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> > Which is really close to the existing log message.
> >
> > if (rec_nb_pkts == 0)
> > rte_exit(EXIT_FAILURE,
> > "PMD does not
> > recommend a burst size. "
> > "Provided
> > value must be between "
> > "1 and %d\n",
> > MAX_PKT_BURST);
> >
> > I am unconvinced, but if you think strongly for this, I won't debate more.
> >
> >
>
> Yes it is close, and I don't have strong opinion on this,
>
> But existing message says "PMD does not recommend a burst size.", I
> think this may be confusing for user.
>
> If I see that message I would either debug relevant driver code or
> communicate with driver maintainer for it. But that is not the case,
> just failed to get recommended burst size and problem is in testpmd.
>
> Anyway, my concern is existing message can be misleading for user.
Maybe shorter:
"PMD does not provide required burst size\n"
next prev parent reply other threads:[~2024-03-13 16:32 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 14:48 [PATCH 0/4] testpmd options parsing cleanup David Marchand
2024-03-08 14:48 ` [PATCH 1/4] app/testpmd: fix stats-period option check David Marchand
2024-03-12 16:43 ` Ferruh Yigit
2024-03-08 14:48 ` [PATCH 2/4] app/testpmd: fix burst option parsing David Marchand
2024-03-12 16:47 ` Ferruh Yigit
2024-03-13 7:24 ` David Marchand
2024-03-13 10:37 ` Ferruh Yigit
2024-03-13 11:13 ` David Marchand
2024-03-13 12:09 ` Ferruh Yigit
2024-03-13 16:32 ` Stephen Hemminger [this message]
2024-03-08 14:48 ` [PATCH 3/4] app/testpmd: check queue count for related options David Marchand
2024-03-12 16:59 ` Ferruh Yigit
2024-03-13 7:37 ` David Marchand
2024-03-13 10:42 ` Ferruh Yigit
2024-03-13 11:10 ` David Marchand
2024-03-13 12:18 ` Ferruh Yigit
2024-03-08 14:48 ` [PATCH 4/4] app/testpmd: enhance getopt_long usage David Marchand
2024-03-12 17:03 ` Ferruh Yigit
2024-03-13 16:51 ` David Marchand
2024-03-13 17:20 ` David Marchand
2024-03-13 23:28 ` Ferruh Yigit
2024-03-13 23:28 ` Ferruh Yigit
2024-03-14 9:17 ` [PATCH v2 0/6] testpmd options parsing cleanup David Marchand
2024-03-14 9:17 ` [PATCH v2 1/6] app/testpmd: fix stats-period option check David Marchand
2024-03-14 9:17 ` [PATCH v2 2/6] app/testpmd: fix burst option parsing David Marchand
2024-03-14 9:22 ` Ferruh Yigit
2024-03-14 9:17 ` [PATCH v2 3/6] app/testpmd: fix error message for invalid option David Marchand
2024-03-14 9:23 ` Ferruh Yigit
2024-03-14 9:17 ` [PATCH v2 4/6] app/testpmd: enhance queue count check David Marchand
2024-03-14 9:23 ` Ferruh Yigit
2024-03-14 9:17 ` [PATCH v2 5/6] app/testpmd: remove dead code for disabling cmdline library David Marchand
2024-03-14 11:33 ` Ferruh Yigit
2024-03-14 9:17 ` [PATCH v2 6/6] app/testpmd: enhance getopt_long usage David Marchand
2024-03-14 11:43 ` Ferruh Yigit
2024-03-14 12:43 ` [PATCH v2 0/6] testpmd options parsing cleanup Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240313093213.18636f52@hermes.local \
--to=stephen@networkplumber.org \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=ivan.ilchenko@oktetlabs.ru \
--cc=stable@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).