From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66FAA43CA0; Wed, 13 Mar 2024 17:32:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF00040A84; Wed, 13 Mar 2024 17:32:17 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 18AE4406BC for ; Wed, 13 Mar 2024 17:32:16 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1dd955753edso80095ad.1 for ; Wed, 13 Mar 2024 09:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1710347535; x=1710952335; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=CF5L4amQxOrGOE178GAQeq5HxQC0VqT4rD+3A1APXDQ=; b=JCQ+xG/2RFkcTclBhmbt1nwAhH+tPevHeft/RPikFP8m1LpOyRP349uLBk8/BPI6p4 3CY9kgs2TFq4nKIy4J0yUOTaMdbhGf73GEZ5I7xLJtCYYYytiIJStKgyZ5fhtVnBpfIx iloUAZqqIk6SSB3AKBEG7aDPqVhmZJKjHaGfCP83BQ5wxh+o2vth68w+vKJy/BJ/Zc6p sGqWJGUs6qo65Ds8I/2A5TVtID5cpwl12sNwdym3QFnAX3tJEDc7bXykXBrRnESpDBpe 9k1idhpvkJc7pRO9kJ8hDlZGZiQ1pVGelLOkfeMOnOrzw+wzTYiJj7VqTEjQLPUgIy3k 4xKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710347535; x=1710952335; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CF5L4amQxOrGOE178GAQeq5HxQC0VqT4rD+3A1APXDQ=; b=BwwESuoNNsaeJi1fc1cu57/uwPDFH2sbMjJJyMcgbu5KYQHEH+QxJPaALIbCl8Uh7D Ia2o6x9CKaLxzYXrG1iWSsL4sb2iuoIyQY98pWSz2Mht2SkO1hHHpeg/zThrGciA2Xxn Z9P+wbJLgVKaOCx0TR/eRjxbLjLmdoBvvapkil43S6T6/Qx590TIgT5JMGZ3eB+dPV+y MZLc+XsJypID6sG78BpFp2ZRwxifaRyZZRWHdY63teF78+6+7eIsIt5d9i9xXCHqDAzU 8p/TOplSZJmrgViQJHQEYtXYNPCoDa4Zf8z2ZxsRf6PfyQlrmncmcO4aA+O7U4MGkXDg X3hA== X-Forwarded-Encrypted: i=1; AJvYcCWJ/xSIQP0trFZN3hR4mDv4N7DyYCSo2PPi4NjutnwN23CAjdCWD+Kj5NKBFH5I1EffHQGtuMv2pvybv/Y= X-Gm-Message-State: AOJu0Yzzt+j5QH9h5BPKW3ImsX9iw8OCV3cdkkhyubWOJvcIUgDrulEK eAgAhpwGdjF0Fl+n/uIM8ub+ypewbkoJkoRIalplIodi78HvxBYTixiukyl5EtQ= X-Google-Smtp-Source: AGHT+IEejfToan/nOr0YIJAx+ur9hkJzn45Ea2KMDXwP1jWmQ3ztzdke2HNOtoYviri+iq4sPGQ68A== X-Received: by 2002:a17:902:d486:b0:1dd:7d20:63ef with SMTP id c6-20020a170902d48600b001dd7d2063efmr14830613plg.11.1710347535177; Wed, 13 Mar 2024 09:32:15 -0700 (PDT) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id y15-20020a17090264cf00b001dd744f97d0sm9021854pli.273.2024.03.13.09.32.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 09:32:15 -0700 (PDT) Date: Wed, 13 Mar 2024 09:32:13 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: David Marchand , dev@dpdk.org, stable@dpdk.org, Aman Singh , Yuying Zhang , Ivan Ilchenko , Andrew Rybchenko , Bernard Iremonger Subject: Re: [PATCH 2/4] app/testpmd: fix burst option parsing Message-ID: <20240313093213.18636f52@hermes.local> In-Reply-To: <18743010-a6ae-43c0-9a39-a2a9a6b56e4b@amd.com> References: <20240308144841.3615262-1-david.marchand@redhat.com> <20240308144841.3615262-3-david.marchand@redhat.com> <92e9792e-9054-4c8e-a409-739176707175@amd.com> <70c06f94-bba1-48f3-8c59-9e523ff0498d@amd.com> <18743010-a6ae-43c0-9a39-a2a9a6b56e4b@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 13 Mar 2024 12:09:01 +0000 Ferruh Yigit wrote: > > Which is really close to the existing log message. > > > > if (rec_nb_pkts == 0) > > rte_exit(EXIT_FAILURE, > > "PMD does not > > recommend a burst size. " > > "Provided > > value must be between " > > "1 and %d\n", > > MAX_PKT_BURST); > > > > I am unconvinced, but if you think strongly for this, I won't debate more. > > > > > > Yes it is close, and I don't have strong opinion on this, > > But existing message says "PMD does not recommend a burst size.", I > think this may be confusing for user. > > If I see that message I would either debug relevant driver code or > communicate with driver maintainer for it. But that is not the case, > just failed to get recommended burst size and problem is in testpmd. > > Anyway, my concern is existing message can be misleading for user. Maybe shorter: "PMD does not provide required burst size\n"