From: Mingjin Ye <mingjinx.ye@intel.com>
To: dev@dpdk.org
Cc: Mingjin Ye <mingjinx.ye@intel.com>,
stable@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>
Subject: [PATCH 1/3] bus/vdev: revert fix devargs in secondary process
Date: Thu, 14 Mar 2024 09:36:28 +0000 [thread overview]
Message-ID: <20240314093630.1066948-2-mingjinx.ye@intel.com> (raw)
In-Reply-To: <20240314093630.1066948-1-mingjinx.ye@intel.com>
The asan tool detected a memory leak in the vdev driver
alloc_devargs. The previous commit was that when inserting
a vdev device, the primary process alloc devargs and the
secondary process looks for devargs. This causes the
device to not be created if the secondary process does
not initialise the vdev device. And, this is not the
root cause.
Therefore the following commit was reverted accordingly.
Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process")
After restoring this commit, the memory leak still exists.
A new patch has since fixed this issue.
Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process")
Cc: stable@dpdk.org
Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
---
drivers/bus/vdev/vdev.c | 21 +--------------------
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 14cf856237..38d05a9fe9 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args)
return devargs;
}
-static struct rte_devargs *
-vdev_devargs_lookup(const char *name)
-{
- struct rte_devargs *devargs;
- char dev_name[32];
-
- RTE_EAL_DEVARGS_FOREACH("vdev", devargs) {
- devargs->bus->parse(devargs->name, &dev_name);
- if (strcmp(dev_name, name) == 0) {
- VDEV_LOG(INFO, "devargs matched %s", dev_name);
- return devargs;
- }
- }
- return NULL;
-}
-
static int
insert_vdev(const char *name, const char *args,
struct rte_vdev_device **p_dev,
@@ -291,10 +275,7 @@ insert_vdev(const char *name, const char *args,
if (name == NULL)
return -EINVAL;
- if (rte_eal_process_type() == RTE_PROC_PRIMARY)
- devargs = alloc_devargs(name, args);
- else
- devargs = vdev_devargs_lookup(name);
+ devargs = alloc_devargs(name, args);
if (!devargs)
return -ENOMEM;
--
2.25.1
next prev parent reply other threads:[~2024-03-14 9:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 9:36 [PATCH 0/3] fix insert dev core dump Mingjin Ye
2024-03-14 9:36 ` Mingjin Ye [this message]
2024-06-19 20:12 ` [PATCH 1/3] bus/vdev: revert fix devargs in secondary process Thomas Monjalon
2024-03-14 9:36 ` [PATCH 2/3] bus/vdev: revert fix devargs after multi-process bus scan Mingjin Ye
2024-06-19 20:15 ` Thomas Monjalon
2024-06-20 6:10 ` Ye, MingjinX
2024-07-11 15:56 ` Burakov, Anatoly
2024-03-14 9:36 ` [PATCH 3/3] net/vdev: fix insert vdev core dump Mingjin Ye
2024-03-15 5:51 ` Jiang, YuX
2024-06-19 20:16 ` Thomas Monjalon
2024-06-20 6:41 ` Ye, MingjinX
2024-07-11 16:10 ` Burakov, Anatoly
2024-07-12 2:18 ` Ye, MingjinX
2024-07-12 8:38 ` Burakov, Anatoly
2024-07-16 9:53 ` [PATCH v2] " Mingjin Ye
2024-07-22 12:39 ` Burakov, Anatoly
2024-07-23 15:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240314093630.1066948-2-mingjinx.ye@intel.com \
--to=mingjinx.ye@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).