From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 95C8B43CAD;
	Thu, 14 Mar 2024 17:30:33 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6170440E28;
	Thu, 14 Mar 2024 17:30:33 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 84FB440297
 for <dev@dpdk.org>; Thu, 14 Mar 2024 17:30:32 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id B419720B74C0; Thu, 14 Mar 2024 09:30:31 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B419720B74C0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1710433831;
 bh=AxWg8tczkc3PQK9yDBJILAScftBCIoDj9VOuBd6FLes=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=RWigrC7CfDTMVFpfI1sQCQndFEywrc0EU1TUwhF3d4NDqHkbaxeJwbKL9HBQu+wV/
 yWjaHvh9RVUSWOxZ34PdZkkeKDcrCsXPzZ6WGzZFX2dEhVKwVL3wD6ZB3vFqulwxWM
 CMMwzSJ2CVzuD8pauwofVkVO0/C46Rz7bbenXHXY=
Date: Thu, 14 Mar 2024 09:30:31 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 Sameh Gobriel <sameh.gobriel@intel.com>,
 Stephen Hemminger <stephen@networkplumber.org>,
 Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
 Yipeng Wang <yipeng1.wang@intel.com>
Subject: Re: [PATCH] hash: remove return statement from function returning void
Message-ID: <20240314163031.GA27730@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1709932817-29583-1-git-send-email-roretzla@linux.microsoft.com>
 <CAJFAV8wnFA57HJh5Tp7bTJySKkyQ+tfRiQLuricKNYe3zfSLLA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJFAV8wnFA57HJh5Tp7bTJySKkyQ+tfRiQLuricKNYe3zfSLLA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Mar 14, 2024 at 04:58:54PM +0100, David Marchand wrote:
> Hello Tyler,
> 
> On Fri, Mar 8, 2024 at 10:20 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > rte_thash_gfni_bulk and rte_thash_gfni_bulk_stub both return void.
> > Remove superfluous return statement from rte_thash_gfni_bulk.
> >
> > Fixes: 944a03a5cfc1 ("hash: fix MSVC link on GFNI stubs")
> > Cc: stephen@networkplumber.org
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> >  lib/hash/rte_thash_gfni.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/hash/rte_thash_gfni.h b/lib/hash/rte_thash_gfni.h
> > index edae2e8..132f375 100644
> > --- a/lib/hash/rte_thash_gfni.h
> > +++ b/lib/hash/rte_thash_gfni.h
> > @@ -71,7 +71,7 @@
> >  rte_thash_gfni_bulk(const uint64_t *mtrx, int len, uint8_t *tuple[],
> >         uint32_t val[], uint32_t num)
> >  {
> > -       return rte_thash_gfni_bulk_stub(mtrx, len, tuple, val, num);
> > +       rte_thash_gfni_bulk_stub(mtrx, len, tuple, val, num);
> >  }
> 
> I am surprised the CI did not catch it.
> I need to pass -pedantic when compiling with this header, but no code
> does this in-tree.
> How did you catch this issue?

MSVC warns about it (and hundreds of other things). Benefits of compiling the
same code with a compiler not sharing the same lineage.

> 
> 
> -- 
> David Marchand