From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0BB5A43CBD;
	Fri, 15 Mar 2024 21:02:30 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 96966402C3;
	Fri, 15 Mar 2024 21:02:29 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 4AA45402BC
 for <dev@dpdk.org>; Fri, 15 Mar 2024 21:02:27 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 49EF620B74C0; Fri, 15 Mar 2024 13:02:26 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 49EF620B74C0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1710532946;
 bh=4jCNQxN98QiiIjRDPs/qpXP4rVYqCoLdW5M80GsUiVE=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=CmOyhLAM8hTZDk2Cd3Exs+aYifKTIjq3JlccbPMIefuYvP/SlW4HGziUniYrievhu
 2fNPfDYb7/aSYsEuFHdY7bGCSlVXJ9B8T78OkZT6P/YwF/iGh2sknPvfLWg1fPjs75
 2Jaf4lry2YDe+XHXPfA3bh2/yeestnlo9CKcOZTo=
Date: Fri, 15 Mar 2024 13:02:26 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [PATCH] windows: make getopt functions have const properties
Message-ID: <20240315200226.GA32570@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20240315151407.7517-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240315151407.7517-1-stephen@networkplumber.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, Mar 15, 2024 at 08:14:06AM -0700, Stephen Hemminger wrote:
> Having different prototypes on different platforms can lead
> to lots of unnecessary workarounds.  Looks like the version of
> getopt used from windows was based on an older out of date
> version from FreeBSD.
> 
> This patch changes getopt, getopt_long, etc to have the same const
> attributes as Linux and FreeBSD. The changes are derived from
> the current FreeBSD version of getopt_long.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>