From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
Subject: [PATCH] app/testpmd: dump TCI when asking for VLAN insertion
Date: Mon, 18 Mar 2024 09:02:37 +0100 [thread overview]
Message-ID: <20240318080237.2170473-1-david.marchand@redhat.com> (raw)
I got some report for users that VLAN insertion was not working as the
only thing they could see in verbose mode was a 0x0800 ethertype even
though the RTE_MBUF_F_TX_VLAN flag was shown.
Dump the VLAN TCI from mbuf metadata when VLAN insertion is requested.
This should enhance the situation.
Before:
src=76:4E:EA:3F:78:1D - dst=50:7C:6F:3C:10:5B - pool=mb_pool_1 -
type=0x0800 - length=64 - nb_segs=1 -
sw ptype: L2_ETHER L3_IPV4 L4_UDP -
l2_len=14 - l3_len=20 - l4_len=8 - Send queue=0x0
ol_flags: RTE_MBUF_F_TX_VLAN RTE_MBUF_F_TX_L4_NO_CKSUM
After:
src=76:4E:EA:3F:78:1D - dst=50:7C:6F:3C:10:5B - pool=mb_pool_1 -
type=0x0800 - length=64 - nb_segs=1 - VLAN tci=0x2a -
sw ptype: L2_ETHER L3_IPV4 L4_UDP -
l2_len=14 - l3_len=20 - l4_len=8 - Send queue=0x0
ol_flags: RTE_MBUF_F_TX_VLAN RTE_MBUF_F_TX_L4_NO_CKSUM
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
app/test-pmd/util.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c
index 5aa69ed545..bf9b639d95 100644
--- a/app/test-pmd/util.c
+++ b/app/test-pmd/util.c
@@ -180,11 +180,13 @@ dump_pkt_burst(uint16_t port_id, uint16_t queue, struct rte_mbuf *pkts[],
if (is_timestamp_enabled(mb))
MKDUMPSTR(print_buf, buf_size, cur_len,
" - timestamp %"PRIu64" ", get_timestamp(mb));
- if (ol_flags & RTE_MBUF_F_RX_QINQ)
+ if ((is_rx && (ol_flags & RTE_MBUF_F_RX_QINQ) != 0) ||
+ (!is_rx && (ol_flags & RTE_MBUF_F_TX_QINQ) != 0))
MKDUMPSTR(print_buf, buf_size, cur_len,
" - QinQ VLAN tci=0x%x, VLAN tci outer=0x%x",
mb->vlan_tci, mb->vlan_tci_outer);
- else if (ol_flags & RTE_MBUF_F_RX_VLAN)
+ else if ((is_rx && (ol_flags & RTE_MBUF_F_RX_VLAN) != 0) ||
+ (!is_rx && (ol_flags & RTE_MBUF_F_TX_VLAN) != 0))
MKDUMPSTR(print_buf, buf_size, cur_len,
" - VLAN tci=0x%x", mb->vlan_tci);
if (!is_rx && (ol_flags & RTE_MBUF_DYNFLAG_TX_METADATA))
--
2.44.0
next reply other threads:[~2024-03-18 8:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 8:02 David Marchand [this message]
2024-03-20 14:01 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318080237.2170473-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).