From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53A5C43D09; Wed, 20 Mar 2024 20:12:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4DB6402CE; Wed, 20 Mar 2024 20:12:22 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 31463402C7 for ; Wed, 20 Mar 2024 20:12:21 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 26B9820B74C0; Wed, 20 Mar 2024 12:12:20 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 26B9820B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1710961940; bh=KWKZxoo5z18+slBao4+yFLXhUOaJFJed/6E7IxHGGhA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V18IN/12eeUf8C4Nq5ZBrk9xLrwpjwgmRloh8fPC59jovdYchWhPS316LfO4WlyBT UvbRM4b8E1qqRJX7XjHKSmnkhFArSxE3+Nn9dIl984UFIHoBT741/9t8H11+oQujZO JZNHdmwa9lmaf2ZntQQd1tZ8EW3FsWBsLvCqwwf4= Date: Wed, 20 Mar 2024 12:12:20 -0700 From: Tyler Retzlaff To: David Marchand Cc: dev@dpdk.org, Bruce Richardson , Stephen Hemminger , Thomas Monjalon , Ferruh Yigit , Akhil Goyal , Jerin Jacob Kollanukkaran , Morten =?iso-8859-1?Q?Br=F8rup?= Subject: Re: [PATCH 00/83] move alignment attribute on types Message-ID: <20240320191220.GB12261@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1710949096-5786-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 20, 2024 at 06:41:30PM +0100, David Marchand wrote: > Hello Tyler, > > On Wed, Mar 20, 2024 at 4:38 PM Tyler Retzlaff > wrote: > > > > The current location used for __rte_aligned(a) for alignment of types > > and variables is not compatible with MSVC. There is only a single > > location accepted by both toolchains. > > > > After having established this as the conventional standard for lib/* > > this series is intended to convert the remainder of the source tree to > > use the same location for __rte_aligned(a) and alignas(a) for > > consistency. > > The series looks good to me. > > We may have some misses because of drivers wrapping in their own > stuff, but I am not sure those are fixable (this touches some base > drivers..) > drivers/common/cnxk/roc_platform.h:#define __plt_aligned __rte_aligned > drivers/common/dpaax/compat.h:#define ____cacheline_aligned > __rte_aligned(L1_CACHE_BYTES) > drivers/common/cnxk/roc_platform.h:#define __plt_cache_aligned > __rte_cache_aligned > drivers/net/ena/base/ena_plat_dpdk.h:#define ____cacheline_aligned > __rte_cache_aligned > drivers/net/gve/base/gve_osdep.h:#define ____cacheline_aligned > __rte_cache_aligned Yes, I know about these and I made the call to leave them untouched for now. The cnxk drivers aren't built on windows and i didn't want to interfere with some out of tree abstraction they may be using for testing. > > I also noticed memif: > drivers/net/memif/memif.h:typedef struct __rte_packed __rte_aligned(128) This should be okay, I also have to address __rte_packed (series coming soon). So long as there are no objections I would propose this series merged as soon as possible (after release) assuming CI doesn't identify anything of concern. if there is follow up to do with cnxk/dpaax i'm happy to do it as a separate series. ty